| Message ID | 20220822184701.25246-3-Sergey.Semin@baikalelectronics.ru |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | PCI: dwc: Add generic resources and Baikal-T1 support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 19 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Mon, Aug 22, 2022 at 09:46:43PM +0300, Serge Semin wrote: > In accordance with the way the device DT-node is actually defined in > arch/arm64/boot/dts/toshiba/tmpv7708.dtsi and the way the device is probed > by the DW PCIe driver there are two IRQs it actually has. It's MSI IRQ the > DT-bindings lack. Let's extend the interrupts property constraints then > and fix the schema example so one would be acceptable by the actual device > DT-bindings. > > Fixes: 17c1b16340f0 ("dt-bindings: pci: Add DT binding for Toshiba Visconti PCIe controller") > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > --- > > Changelog v5: > - This is a new patch added on the v5 release of the patchset. > --- > .../devicetree/bindings/pci/toshiba,visconti-pcie.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) No need for this to be in this series. Acked-by: Rob Herring <robh@kernel.org>
> -----Original Message----- > From: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Sent: Tuesday, August 23, 2022 3:47 AM > To: Rob Herring <robh+dt@kernel.org>; Rob Herring <robh@kernel.org>; > Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Bjorn Helgaas > <bhelgaas@google.com>; Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>; > Jingoo Han <jingoohan1@gmail.com>; Gustavo Pimentel > <gustavo.pimentel@synopsys.com>; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ > ◯ＡＣＴ) <nobuhiro1.iwamatsu@toshiba.co.jp> > Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>; Serge Semin > <fancer.lancer@gmail.com>; Alexey Malahov > <Alexey.Malahov@baikalelectronics.ru>; Pavel Parkhomenko > <Pavel.Parkhomenko@baikalelectronics.ru>; Krzysztof Wilczyński > <kw@linux.com>; Frank Li <Frank.Li@nxp.com>; Manivannan Sadhasivam > <manivannan.sadhasivam@linaro.org>; linux-pci@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-arm-kernel@lists.infradead.org > Subject: [PATCH v5 02/20] dt-bindings: visconti-pcie: Fix interrupts array max > constraints > > In accordance with the way the device DT-node is actually defined in > arch/arm64/boot/dts/toshiba/tmpv7708.dtsi and the way the device is probed > by the DW PCIe driver there are two IRQs it actually has. It's MSI IRQ the > DT-bindings lack. Let's extend the interrupts property constraints then and fix > the schema example so one would be acceptable by the actual device > DT-bindings. > > Fixes: 17c1b16340f0 ("dt-bindings: pci: Add DT binding for Toshiba Visconti > PCIe controller") > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Thanks for this patch. Acked-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> Best regards, Nobuhiro
diff --git a/Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml b/Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml index 30b6396d83c8..aea0e2bcdd77 100644 --- a/Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml @@ -36,7 +36,7 @@ properties: - const: mpu interrupts: - maxItems: 1 + maxItems: 2 clocks: items: @@ -94,8 +94,9 @@ examples: #interrupt-cells = <1>; ranges = <0x81000000 0 0x40000000 0 0x40000000 0 0x00010000>, <0x82000000 0 0x50000000 0 0x50000000 0 0x20000000>; - interrupts = <GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "intr"; + interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "msi", "intr"; interrupt-map-mask = <0 0 0 7>; interrupt-map = <0 0 0 1 &gic GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH
In accordance with the way the device DT-node is actually defined in arch/arm64/boot/dts/toshiba/tmpv7708.dtsi and the way the device is probed by the DW PCIe driver there are two IRQs it actually has. It's MSI IRQ the DT-bindings lack. Let's extend the interrupts property constraints then and fix the schema example so one would be acceptable by the actual device DT-bindings. Fixes: 17c1b16340f0 ("dt-bindings: pci: Add DT binding for Toshiba Visconti PCIe controller") Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> --- Changelog v5: - This is a new patch added on the v5 release of the patchset. --- .../devicetree/bindings/pci/toshiba,visconti-pcie.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)