diff mbox series

[1/3] dt-bindings: irqchip: ti,sci-inta: Fix warning '#interrupt-cells' was unexpected

Message ID 20220819190729.32358-2-a-nandan@ti.com
State Not Applicable, archived
Headers show
Series Fix ti,sci-inta/intr and mmc dtbs_check warnings for TI K3 platforms | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 2 warnings, 9 lines checked
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Apurva Nandan Aug. 19, 2022, 7:07 p.m. UTC
#interrupt-cells = <0> property is required in device tree for
ti,sci-inta nodes, or else we will have following warning when building
device tree files with W=2 warning level.

arch/arm64/boot/dts/ti/k3-j721e-main.dtsi:147.51-156.5: Warning (interrupt_provider): /bus@100000/main-navss/interrupt-controller@33d00000: Missing #interrupt-cells in interrupt provider

And further, #interrupt-cells is required to be in yaml bindings as well
to prevent following schema warnings:

k3-j721e-common-proc-board.dtb: interrupt-controller@33d00000: Unevaluated properties are not allowed ('#interrupt-cells' was unexpected)
From schema: linux/Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.yaml

Add #interrupt-cells property in ti,sci-inta.yaml

Signed-off-by: Apurva Nandan <a-nandan@ti.com>
---
 .../devicetree/bindings/interrupt-controller/ti,sci-inta.yaml  | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rob Herring Aug. 22, 2022, 7:14 p.m. UTC | #1
On Sat, 20 Aug 2022 00:37:27 +0530, Apurva Nandan wrote:
> #interrupt-cells = <0> property is required in device tree for
> ti,sci-inta nodes, or else we will have following warning when building
> device tree files with W=2 warning level.
> 
> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi:147.51-156.5: Warning (interrupt_provider): /bus@100000/main-navss/interrupt-controller@33d00000: Missing #interrupt-cells in interrupt provider
> 
> And further, #interrupt-cells is required to be in yaml bindings as well
> to prevent following schema warnings:
> 
> k3-j721e-common-proc-board.dtb: interrupt-controller@33d00000: Unevaluated properties are not allowed ('#interrupt-cells' was unexpected)
> From schema: linux/Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.yaml
> 
> Add #interrupt-cells property in ti,sci-inta.yaml
> 
> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
> ---
>  .../devicetree/bindings/interrupt-controller/ti,sci-inta.yaml  | 3 +++
>  1 file changed, 3 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.yaml b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.yaml
index 88c46e61732e..1151518859bd 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.yaml
@@ -59,6 +59,9 @@  properties:
 
   interrupt-controller: true
 
+  '#interrupt-cells':
+    const: 0
+
   msi-controller: true
 
   ti,interrupt-ranges: