| Message ID | 20220812084120.376042-1-martyn.welch@collabora.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v4,1/2] dt-bindings: arm: fsl: Add MSC SM2S-IMX8PLUS SoM and SM2-MB-EP1 Carrier | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 12/08/2022 11:41, Martyn Welch wrote: > Add DT compatible strings for a combination of the 14N0600E variant of > the Avnet (MSC branded) SM2S-IMX8PLUS SoM on it's own and in combination > with the SM2-MB-EP1 carrier board. > > Signed-off-by: Martyn Welch <martyn.welch@collabora.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 12/08/2022 11:41, Martyn Welch wrote: > Add device trees for one of a number of MSC's (parent company, Avnet) > variants of the SM2S-IMX8PLUS system on module along with the compatible > SM2S-SK-AL-EP1 carrier board. As the name suggests, this family of SoMs use > the NXP i.MX8MP SoC and provide the SMARC module interface. > > Signed-off-by: Martyn Welch <martyn.welch@collabora.com> > --- > > Changes in v2 > - Added compatibles > - Removed underscores from node names > - Make node names more generic > - Reorder properties > - Fix issues found by dtbs_check in these files > > Changes in v3: > - Switched to avnet vendor string in compatibles > - Corrected patch description > > Changes in v4: > - Switched from phy-reset-gpios to reset-gpios, removing duplication > - Removed unneeded sdma1 node > > arch/arm64/boot/dts/freescale/Makefile | 1 + > .../freescale/imx8mp-msc-sm2s-14N0600E.dts | 72 ++ > .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 53 ++ > .../boot/dts/freescale/imx8mp-msc-sm2s.dtsi | 812 ++++++++++++++++++ > 4 files changed, 938 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s.dtsi > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index 8bf7f7ecebaa..139c8b95c9c9 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -83,6 +83,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mn-venice-gw7902.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw74xx.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts > new file mode 100644 > index 000000000000..9e976e8baaee > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts > @@ -0,0 +1,72 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2022 Avnet Embedded GmbH > + */ > +/dts-v1/; > + > +#include "imx8mp-msc-sm2s.dtsi" > + > +/ { > + model = "MSC SM2S-IMX8PLUS-QC6-14N0600E SoM"; > + compatible = "avnet,sm2s-imx8mp-14N0600E", "avnet,sm2s-imx8mp", > + "fsl,imx8mp"; This does not match your bindings. Please test your DTS. Best regards, Krzysztof
On Fri, 2022-08-12 at 12:47 +0300, Krzysztof Kozlowski wrote: > On 12/08/2022 11:41, Martyn Welch wrote: > > Add device trees for one of a number of MSC's (parent company, > > Avnet) > > variants of the SM2S-IMX8PLUS system on module along with the > > compatible > > SM2S-SK-AL-EP1 carrier board. As the name suggests, this family of > > SoMs use > > the NXP i.MX8MP SoC and provide the SMARC module interface. > > > > Signed-off-by: Martyn Welch <martyn.welch@collabora.com> > > --- > > > > Changes in v2 > > - Added compatibles > > - Removed underscores from node names > > - Make node names more generic > > - Reorder properties > > - Fix issues found by dtbs_check in these files > > > > Changes in v3: > > - Switched to avnet vendor string in compatibles > > - Corrected patch description > > > > Changes in v4: > > - Switched from phy-reset-gpios to reset-gpios, removing > > duplication > > - Removed unneeded sdma1 node > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > .../freescale/imx8mp-msc-sm2s-14N0600E.dts | 72 ++ > > .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 53 ++ > > .../boot/dts/freescale/imx8mp-msc-sm2s.dtsi | 812 > > ++++++++++++++++++ > > 4 files changed, 938 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- > > 14N0600E.dts > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- > > ep1.dts > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc- > > sm2s.dtsi > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > > b/arch/arm64/boot/dts/freescale/Makefile > > index 8bf7f7ecebaa..139c8b95c9c9 100644 > > --- a/arch/arm64/boot/dts/freescale/Makefile > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > @@ -83,6 +83,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mn-venice- > > gw7902.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw74xx.dtb > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- > > 14N0600E.dts b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- > > 14N0600E.dts > > new file mode 100644 > > index 000000000000..9e976e8baaee > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts > > @@ -0,0 +1,72 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (C) 2022 Avnet Embedded GmbH > > + */ > > +/dts-v1/; > > + > > +#include "imx8mp-msc-sm2s.dtsi" > > + > > +/ { > > + model = "MSC SM2S-IMX8PLUS-QC6-14N0600E SoM"; > > + compatible = "avnet,sm2s-imx8mp-14N0600E", "avnet,sm2s- > > imx8mp", > > + "fsl,imx8mp"; > > This does not match your bindings. Please test your DTS. > Hi Krzysztof, I'm not sure I follow. This is the DTS for the SoM. The only way I can test the SoM at the moment is on combination with the "EP1" carrier board. That has been tested. The strings match those specified in the bindings unless I'm being blind to something. I guess I can build the DTB for just the SoM and boot with that or thinking about it, rename this as a .dtsi, given that it's unlikely that anyone is going to have a carrier barebones enough that it could be considered just the SoM? Martyn > Best regards, > Krzysztof
On 12/08/2022 14:35, Martyn Welch wrote: > On Fri, 2022-08-12 at 12:47 +0300, Krzysztof Kozlowski wrote: >> On 12/08/2022 11:41, Martyn Welch wrote: >>> Add device trees for one of a number of MSC's (parent company, >>> Avnet) >>> variants of the SM2S-IMX8PLUS system on module along with the >>> compatible >>> SM2S-SK-AL-EP1 carrier board. As the name suggests, this family of >>> SoMs use >>> the NXP i.MX8MP SoC and provide the SMARC module interface. >>> >>> Signed-off-by: Martyn Welch <martyn.welch@collabora.com> >>> --- >>> >>> Changes in v2 >>> - Added compatibles >>> - Removed underscores from node names >>> - Make node names more generic >>> - Reorder properties >>> - Fix issues found by dtbs_check in these files >>> >>> Changes in v3: >>> - Switched to avnet vendor string in compatibles >>> - Corrected patch description >>> >>> Changes in v4: >>> - Switched from phy-reset-gpios to reset-gpios, removing >>> duplication >>> - Removed unneeded sdma1 node >>> >>> arch/arm64/boot/dts/freescale/Makefile | 1 + >>> .../freescale/imx8mp-msc-sm2s-14N0600E.dts | 72 ++ >>> .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 53 ++ >>> .../boot/dts/freescale/imx8mp-msc-sm2s.dtsi | 812 >>> ++++++++++++++++++ >>> 4 files changed, 938 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- >>> 14N0600E.dts >>> create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- >>> ep1.dts >>> create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc- >>> sm2s.dtsi >>> >>> diff --git a/arch/arm64/boot/dts/freescale/Makefile >>> b/arch/arm64/boot/dts/freescale/Makefile >>> index 8bf7f7ecebaa..139c8b95c9c9 100644 >>> --- a/arch/arm64/boot/dts/freescale/Makefile >>> +++ b/arch/arm64/boot/dts/freescale/Makefile >>> @@ -83,6 +83,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mn-venice- >>> gw7902.dtb >>> dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb >>> dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb >>> dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb >>> +dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb >>> dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb >>> dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb >>> dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw74xx.dtb >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- >>> 14N0600E.dts b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- >>> 14N0600E.dts >>> new file mode 100644 >>> index 000000000000..9e976e8baaee >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dts >>> @@ -0,0 +1,72 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * Copyright (C) 2022 Avnet Embedded GmbH >>> + */ >>> +/dts-v1/; >>> + >>> +#include "imx8mp-msc-sm2s.dtsi" >>> + >>> +/ { >>> + model = "MSC SM2S-IMX8PLUS-QC6-14N0600E SoM"; >>> + compatible = "avnet,sm2s-imx8mp-14N0600E", "avnet,sm2s- >>> imx8mp", >>> + "fsl,imx8mp"; >> >> This does not match your bindings. Please test your DTS. >> > > Hi Krzysztof, > > I'm not sure I follow. This is the DTS for the SoM. SoMs usually do not have DTSes because they cannot be run on their own. SoMs almost always require a baseboard/carrier. Therefore this should not be DTS, but that was not my comment. > The only way I can > test the SoM at the moment is on combination with the "EP1" carrier > board. ... so you basically say it cannot be a DTS. > That has been tested. The strings match those specified in the > bindings unless I'm being blind to something. Test the DTS - make dtbs_check (there are several variations/arguments/helpers): Documentation/devicetree/bindings/writing-schema.rst > > I guess I can build the DTB for just the SoM But you just did it, didn't you? This is a DTS. > and boot with that or > thinking about it, rename this as a .dtsi, given that it's unlikely > that anyone is going to have a carrier barebones enough that it could > be considered just the SoM? Anyway, I wanted DT bindings tests for DTS. Not actual tests on hardware, because the compatibles do not matter in that aspect. Best regards, Krzysztof
On Fri, 2022-08-12 at 16:42 +0300, Krzysztof Kozlowski wrote: > On 12/08/2022 14:35, Martyn Welch wrote: > > On Fri, 2022-08-12 at 12:47 +0300, Krzysztof Kozlowski wrote: > > > On 12/08/2022 11:41, Martyn Welch wrote: > > > > Add device trees for one of a number of MSC's (parent company, > > > > Avnet) > > > > variants of the SM2S-IMX8PLUS system on module along with the > > > > compatible > > > > SM2S-SK-AL-EP1 carrier board. As the name suggests, this family > > > > of > > > > SoMs use > > > > the NXP i.MX8MP SoC and provide the SMARC module interface. > > > > > > > > Signed-off-by: Martyn Welch <martyn.welch@collabora.com> > > > > --- > > > > > > > > Changes in v2 > > > > - Added compatibles > > > > - Removed underscores from node names > > > > - Make node names more generic > > > > - Reorder properties > > > > - Fix issues found by dtbs_check in these files > > > > > > > > Changes in v3: > > > > - Switched to avnet vendor string in compatibles > > > > - Corrected patch description > > > > > > > > Changes in v4: > > > > - Switched from phy-reset-gpios to reset-gpios, removing > > > > duplication > > > > - Removed unneeded sdma1 node > > > > > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > > .../freescale/imx8mp-msc-sm2s-14N0600E.dts | 72 ++ > > > > .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 53 ++ > > > > .../boot/dts/freescale/imx8mp-msc-sm2s.dtsi | 812 > > > > ++++++++++++++++++ > > > > 4 files changed, 938 insertions(+) > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc- > > > > sm2s- > > > > 14N0600E.dts > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc- > > > > sm2s- > > > > ep1.dts > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-msc- > > > > sm2s.dtsi > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > > > > b/arch/arm64/boot/dts/freescale/Makefile > > > > index 8bf7f7ecebaa..139c8b95c9c9 100644 > > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > > @@ -83,6 +83,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mn-venice- > > > > gw7902.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw74xx.dtb > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- > > > > 14N0600E.dts b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- > > > > 14N0600E.dts > > > > new file mode 100644 > > > > index 000000000000..9e976e8baaee > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s- > > > > 14N0600E.dts > > > > @@ -0,0 +1,72 @@ > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > +/* > > > > + * Copyright (C) 2022 Avnet Embedded GmbH > > > > + */ > > > > +/dts-v1/; > > > > + > > > > +#include "imx8mp-msc-sm2s.dtsi" > > > > + > > > > +/ { > > > > + model = "MSC SM2S-IMX8PLUS-QC6-14N0600E SoM"; > > > > + compatible = "avnet,sm2s-imx8mp-14N0600E", "avnet,sm2s- > > > > imx8mp", > > > > + "fsl,imx8mp"; > > > > > > This does not match your bindings. Please test your DTS. > > > > > > > Hi Krzysztof, > > > > I'm not sure I follow. This is the DTS for the SoM. > > SoMs usually do not have DTSes because they cannot be run on their > own. > SoMs almost always require a baseboard/carrier. Therefore this should > not be DTS, but that was not my comment. > OK, so does making this as dtsi resolve the issue for you? I assume as a dtsi I would also need to remove the model and compatible? > > The only way I can > > test the SoM at the moment is on combination with the "EP1" carrier > > board. > > ... so you basically say it cannot be a DTS. > > > That has been tested. The strings match those specified in the > > bindings unless I'm being blind to something. > > Test the DTS - make dtbs_check (there are several > variations/arguments/helpers): > Documentation/devicetree/bindings/writing-schema.rst > Yep, ran that. > > > > I guess I can build the DTB for just the SoM > > But you just did it, didn't you? This is a DTS. > As you can see from the patch, I didn't add that file directly to the Makefile, so dtbs_check didn't check it directly. > > > > and boot with that or > > thinking about it, rename this as a .dtsi, given that it's unlikely > > that anyone is going to have a carrier barebones enough that it > > could > > be considered just the SoM? > > Anyway, I wanted DT bindings tests for DTS. Not actual tests on > hardware, because the compatibles do not matter in that aspect. > The tests threw quite a few errors that seemed to be related to the imx8mp.dtsi. The only ones that seemed to be related to the files I've created seem to be the result of including optional pins in the pin muxing, which need to be there AFAIK, but seem to be resulting in warnings from the tool. Martyn > Best regards, > Krzysztof
On 12/08/2022 18:03, Martyn Welch wrote: > The tests threw quite a few errors that seemed to be related to the > imx8mp.dtsi. The only ones that seemed to be related to the files I've > created seem to be the result of including optional pins in the pin > muxing, which need to be there AFAIK, but seem to be resulting in > warnings from the tool. Your DTS defined three compatibles which were not documented by the bindings change, therefore I expect the warning from schema. To be sure, I just run it and it is clearly visible: /home/krzk/dev/linux/linux/out/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-14N0600E.dtb: /: compatible: 'oneOf' conditional failed, one must be fixed: ['avnet,sm2s-imx8mp-14N0600E', 'avnet,sm2s-imx8mp', 'fsl,imx8mp'] is too long ['avnet,sm2s-imx8mp-14N0600E', 'avnet,sm2s-imx8mp', 'fsl,imx8mp'] is too short It's not possible to miss it, it's the biggest warning... Best regards, Krzysztof
On Fri, 2022-08-12 at 20:31 +0300, Krzysztof Kozlowski wrote: > On 12/08/2022 18:03, Martyn Welch wrote: > > The tests threw quite a few errors that seemed to be related to the > > imx8mp.dtsi. The only ones that seemed to be related to the files > > I've > > created seem to be the result of including optional pins in the pin > > muxing, which need to be there AFAIK, but seem to be resulting in > > warnings from the tool. > > Your DTS defined three compatibles which were not documented by the > bindings change, therefore I expect the warning from schema. > > To be sure, I just run it and it is clearly visible: > > /home/krzk/dev/linux/linux/out/arch/arm64/boot/dts/freescale/imx8mp- > msc-sm2s-14N0600E.dtb: > /: compatible: 'oneOf' conditional failed, one must be fixed: > > ['avnet,sm2s-imx8mp-14N0600E', 'avnet,sm2s-imx8mp', > 'fsl,imx8mp'] is > too long > > ['avnet,sm2s-imx8mp-14N0600E', 'avnet,sm2s-imx8mp', > 'fsl,imx8mp'] is > too short > > > It's not possible to miss it, it's the biggest warning... > This is the sum total of what I'm getting when running it: $ make dtbs_check warning: python package 'yamllint' not installed, skipping CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json DTC arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb CHECK arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: ecspi1grp:fsl,pins:0: [488, 1096, 1372, 0, 0, 130, 484, 1092, 1376, 0, 0, 130, 480, 1088, 1368, 0, 0, 130, 492, 1100, 1380, 0, 0, 262144, 172, 780, 0, 5, 0, 262144] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: ecspi2grp:fsl,pins:0: [504, 1112, 1388, 0, 1, 130, 500, 1108, 1392, 0, 1, 130, 496, 1104, 1384, 0, 1, 130, 508, 1116, 1396, 0, 1, 262144, 176, 784, 0, 5, 0, 262144] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: eqosgrp:fsl,pins:0: [84, 692, 0, 0, 0, 3, 88, 696, 1424, 0, 1, 3, 124, 732, 0, 0, 0, 145, 128, 736, 0, 0, 0, 145, 132, 740, 0, 0, 0, 145, 136, 744, 0, 0, 0, 145, 120, 728, 0, 0, 0, 145, 116, 724, 0, 0, 0, 145, 104, 712, 0, 0, 0, 31, 100, 708, 0, 0, 0, 31, 96, 704, 0, 0, 0, 31, 92, 700, 0, 0, 0, 31, 108, 716, 0, 0, 0, 31, 112, 720, 0, 0, 0, 31] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: fecgrp:fsl,pins:0: [344, 952, 0, 4, 0, 3, 348, 956, 1404, 4, 1, 3, 352, 960, 1408, 4, 1, 145, 356, 964, 1412, 4, 1, 145, 360, 968, 0, 4, 0, 145, 364, 972, 0, 4, 0, 145, 372, 980, 0, 4, 0, 145, 368, 976, 1416, 4, 1, 145, 376, 984, 0, 4, 0, 31, 380, 988, 0, 4, 0, 31, 384, 992, 0, 4, 0, 31, 388, 996, 0, 4, 0, 31, 392, 1000, 0, 4, 0, 31, 396, 1004, 0, 4, 0, 31] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: flexcan1grp:fsl,pins:0: [312, 920, 0, 6, 0, 340, 316, 924, 1356, 6, 0, 340] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: flexcan2grp:fsl,pins:0: [324, 932, 1360, 6, 0, 340, 320, 928, 0, 6, 0, 340] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: flexspi0grp:fsl,pins:0: [224, 832, 0, 1, 0, 450, 228, 836, 0, 1, 0, 130, 248, 856, 0, 1, 0, 130, 252, 860, 0, 1, 0, 130, 256, 864, 0, 1, 0, 130, 260, 868, 0, 1, 0, 130, 280, 888, 0, 5, 0, 25] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: i2c1grp:fsl,pins:0: [512, 1120, 1444, 0, 2, 1073742275, 516, 1124, 1448, 0, 2, 1073742275] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: i2c2grp:fsl,pins:0: [520, 1128, 1452, 0, 2, 1073742275, 524, 1132, 1456, 0, 2, 1073742275] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: i2c3grp:fsl,pins:0: [528, 1136, 1460, 0, 4, 1073742275, 532, 1140, 1464, 0, 4, 1073742275] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: i2c4grp:fsl,pins:0: [536, 1144, 1468, 0, 5, 1073742275, 540, 1148, 1472, 0, 5, 1073742275] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: i2c5grp:fsl,pins:0: [468, 1076, 1476, 2, 2, 1073742275, 472, 1080, 1480, 2, 2, 1073742275] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: i2c6grp:fsl,pins:0: [300, 908, 1484, 3, 1, 1073742275, 304, 912, 1488, 3, 1, 1073742275] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: uart1grp:fsl,pins:0: [544, 1152, 1512, 0, 4, 73, 548, 1156, 0, 0, 0, 73] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: uart2grp:fsl,pins:0: [164, 772, 0, 5, 0, 452, 168, 776, 0, 5, 0, 452, 552, 1160, 1520, 0, 6, 73, 556, 1164, 0, 0, 0, 73] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: uart3grp:fsl,pins:0: [180, 788, 0, 5, 0, 452, 184, 792, 0, 5, 0, 452, 560, 1168, 1528, 0, 6, 73, 564, 1172, 0, 0, 0, 73] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: uart4grp:fsl,pins:0: [568, 1176, 1536, 0, 8, 73, 572, 1180, 0, 0, 0, 73] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: usdhc2-gpiogrp:fsl,pins:0: [188, 796, 0, 5, 0, 452, 220, 828, 0, 5, 0, 452] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: usdhc2grp:fsl,pins:0: [192, 800, 0, 0, 0, 400, 196, 804, 0, 0, 0, 464, 200, 808, 0, 0, 0, 464, 204, 812, 0, 0, 0, 464, 208, 816, 0, 0, 0, 464, 212, 820, 0, 0, 0, 464, 36, 644, 0, 1, 0, 193] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: usdhc2-100mhzgrp:fsl,pins:0: [192, 800, 0, 0, 0, 404, 196, 804, 0, 0, 0, 468, 200, 808, 0, 0, 0, 468, 204, 812, 0, 0, 0, 468, 208, 816, 0, 0, 0, 468, 212, 820, 0, 0, 0, 468, 36, 644, 0, 1, 0, 193] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: usdhc2-200mhzgrp:fsl,pins:0: [192, 800, 0, 0, 0, 406, 196, 804, 0, 0, 0, 470, 200, 808, 0, 0, 0, 470, 204, 812, 0, 0, 0, 470, 208, 816, 0, 0, 0, 470, 212, 820, 0, 0, 0, 470, 36, 644, 0, 1, 0, 193] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: usdhc3grp:fsl,pins:0: [292, 900, 1540, 2, 1, 400, 296, 904, 1548, 2, 1, 464, 264, 872, 1552, 2, 1, 464, 268, 876, 1556, 2, 1, 464, 272, 880, 1560, 2, 1, 464, 276, 884, 1564, 2, 1, 464, 284, 892, 1568, 2, 1, 464, 236, 844, 1572, 2, 1, 464, 240, 848, 1576, 2, 1, 464, 244, 852, 1580, 2, 1, 464, 232, 840, 1584, 2, 1, 400] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: usdhc3-100mhzgrp:fsl,pins:0: [292, 900, 1540, 2, 1, 404, 296, 904, 1548, 2, 1, 468, 264, 872, 1552, 2, 1, 468, 268, 876, 1556, 2, 1, 468, 272, 880, 1560, 2, 1, 468, 276, 884, 1564, 2, 1, 468, 284, 892, 1568, 2, 1, 468, 236, 844, 1572, 2, 1, 468, 240, 848, 1576, 2, 1, 468, 244, 852, 1580, 2, 1, 468, 232, 840, 1584, 2, 1, 404] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: usdhc3-200mhzgrp:fsl,pins:0: [292, 900, 1540, 2, 1, 406, 296, 904, 1548, 2, 1, 470, 264, 872, 1552, 2, 1, 470, 268, 876, 1556, 2, 1, 470, 272, 880, 1560, 2, 1, 470, 276, 884, 1564, 2, 1, 470, 284, 892, 1568, 2, 1, 470, 236, 844, 1572, 2, 1, 470, 240, 848, 1576, 2, 1, 470, 244, 852, 1580, 2, 1, 470, 232, 840, 1584, 2, 1, 406] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: pinctrl@30330000: smarcgpiosgrp:fsl,pins:0: [64, 672, 0, 0, 0, 25, 332, 940, 0, 5, 0, 25, 336, 944, 0, 5, 0, 25, 340, 948, 0, 5, 0, 25, 444, 1052, 0, 5, 0, 25, 464, 1072, 0, 5, 0, 25, 400, 1008, 0, 5, 0, 25, 60, 668, 0, 0, 0, 25, 408, 1016, 0, 5, 0, 25, 412, 1020, 0, 5, 0, 25, 416, 1024, 0, 5, 0, 25, 440, 1048, 0, 5, 0, 25, 404, 1012, 0, 5, 0, 25, 328, 936, 0, 5, 0, 25] is too long From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp- pinctrl.yaml arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30000000/iomuxc-gpr@30340000: failed to match any schema with compatible: ['fsl,imx8mp-iomuxc-gpr', 'syscon'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30000000/anatop@30360000: failed to match any schema with compatible: ['fsl,imx8mp-anatop', 'fsl,imx8mm-anatop', 'syscon'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30000000/anatop@30360000: failed to match any schema with compatible: ['fsl,imx8mp-anatop', 'fsl,imx8mm-anatop', 'syscon'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30000000/snvs@30370000: failed to match any schema with compatible: ['fsl,sec-v4.0-mon', 'syscon', 'simple-mfd'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30000000/snvs@30370000/snvs-rtc-lp: failed to match any schema with compatible: ['fsl,sec-v4.0-mon-rtc-lp'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30000000/snvs@30370000/snvs-powerkey: failed to match any schema with compatible: ['fsl,sec-v4.0-pwrkey'] /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: gpc@303a0000: 'oneOf' conditional failed, one must be fixed: 'interrupts' is a required property 'interrupts-extended' is a required property From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30800000/crypto@30900000: failed to match any schema with compatible: ['fsl,sec-v4.0'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30800000/crypto@30900000/jr@1000: failed to match any schema with compatible: ['fsl,sec-v4.0-job-ring'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30800000/crypto@30900000/jr@2000: failed to match any schema with compatible: ['fsl,sec-v4.0-job-ring'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30800000/crypto@30900000/jr@3000: failed to match any schema with compatible: ['fsl,sec-v4.0-job-ring'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30800000/dma-controller@30bd0000: failed to match any schema with compatible: ['fsl,imx8mp-sdma', 'fsl,imx8mq-sdma'] arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /soc@0/bus@30800000/dma-controller@30bd0000: failed to match any schema with compatible: ['fsl,imx8mp-sdma', 'fsl,imx8mq-sdma'] /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: usb-phy@381f0040: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: usb@32f10100: 'power-domains' does not match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+' From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: usb-phy@382f0040: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml /home/martyn/Documents/geh0003/linux- upstream/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb: usb@32f10108: 'power-domains' does not match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+' From schema: /home/martyn/Documents/geh0003/linux- upstream/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb:0:0: /extcon- usb0: failed to match any schema with compatible: ['linux,extcon-usb- gpio'] Unless I'm missing something, that's all from dtsi I'm including, not from the files I'm trying to add (with the possible exception of the tools not understanding that pinctrl nodes might have optional entities in them. Do you have patch 1 of the series in your tree?: https://lore.kernel.org/linux-devicetree/20220812084120.376042-1-martyn.welch@collabora.com/ I thought that was exactly what that was doing... Martyn > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 7431579ab0e8..81d90dc83385 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -936,6 +936,13 @@ properties: - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules - const: fsl,imx8mp + - description: Avnet (MSC Branded) Boards with SM2S i.MX8M Plus Modules + items: + - const: avnet,sm2s-imx8mp-14N0600E-ep1 # SM2S-IMX8PLUS-14N0600E on SM2-MB-EP1 Carrier Board + - const: avnet,sm2s-imx8mp-14N0600E # 14N0600E variant of SM2S-IMX8PLUS SoM + - const: avnet,sm2s-imx8mp # SM2S-IMX8PLUS SoM + - const: fsl,imx8mp + - description: Engicam i.Core MX8M Plus SoM based boards items: - enum:
Add DT compatible strings for a combination of the 14N0600E variant of the Avnet (MSC branded) SM2S-IMX8PLUS SoM on it's own and in combination with the SM2-MB-EP1 carrier board. Signed-off-by: Martyn Welch <martyn.welch@collabora.com> --- Changes in v2: - New addition Changes in v3: - Switch to avnet vendor - Shortened descriptive comment Changes in v4: - No changes Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++ 1 file changed, 7 insertions(+)