| Message ID | 20220810143613.482724-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | dt-bindings: chrome: google,cros-ec-type: restrict allowed properties | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Hi Krzysztof, On Aug 10 17:36, Krzysztof Kozlowski wrote: > Describe exactly what properties are allowed in Google Chrome OS EC Type > C port, so the schema can properly validate the DTS. Existing DTS > defines always connectors with unit addresses, not a sole "connector" > child. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Micro-nit: the tag in the commit message is missing a trailing "c" in "cros-ec-typec". Other than that, Acked-by: Prashant Malani <pmalani@chromium.org>
On 10/08/2022 21:36, Prashant Malani wrote: > Hi Krzysztof, > > On Aug 10 17:36, Krzysztof Kozlowski wrote: >> Describe exactly what properties are allowed in Google Chrome OS EC Type >> C port, so the schema can properly validate the DTS. Existing DTS >> defines always connectors with unit addresses, not a sole "connector" >> child. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Micro-nit: the tag in the commit message is missing a trailing "c" in > "cros-ec-typec". Other than that, Thanks. > > Acked-by: Prashant Malani <pmalani@chromium.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml b/Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml index 2d98f7c4d3bc..50ebd8c57795 100644 --- a/Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml +++ b/Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml @@ -20,13 +20,24 @@ properties: compatible: const: google,cros-ec-typec - connector: + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + +patternProperties: + '^connector@[0-9a-f]+$': $ref: /schemas/connector/usb-connector.yaml# + unevaluatedProperties: false + properties: + reg: + maxItems: 1 required: - compatible -additionalProperties: true #fixme +additionalProperties: false examples: - |+
Describe exactly what properties are allowed in Google Chrome OS EC Type C port, so the schema can properly validate the DTS. Existing DTS defines always connectors with unit addresses, not a sole "connector" child. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Cc: Bjorn Andersson <bjorn.andersson@linaro.org> --- .../bindings/chrome/google,cros-ec-typec.yaml | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-)