| Message ID | 20220810035013.3582848-2-bjorn.andersson@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | drm/msm/dp: Support for external displays | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Tue, 09 Aug 2022 20:50:07 -0700, Bjorn Andersson wrote: > Add compatibles for the DisplayPort and Embedded DisplayPort blocks in > Qualcomm SDM845 and SC8280XP platforms. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > .../devicetree/bindings/display/msm/dp-controller.yaml | 3 +++ > 1 file changed, 3 insertions(+) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ displayport-controller@ae90000: '#clock-cells', 'data-lanes', 'opp-table', 'vdda-0p9-supply', 'vdda-1p2-supply' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r4.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r5.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r4.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r9.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dtb displayport-controller@ae90000: '#clock-cells', 'opp-table' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sc7180-idp.dtb arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb arch/arm64/boot/dts/qcom/sc7280-idp2.dtb arch/arm64/boot/dts/qcom/sc7280-idp.dtb displayport-controller@ae90000: reg: [[0, 183042048, 0, 5120]] is too short arch/arm64/boot/dts/qcom/sc7180-idp.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r4.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r5.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r4.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r9.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dtb arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb arch/arm64/boot/dts/qcom/sc7280-idp2.dtb arch/arm64/boot/dts/qcom/sc7280-idp.dtb edp@aea0000: '#address-cells', '#clock-cells', '#size-cells', 'aux-bus', 'opp-table', 'vdda-0p9-supply', 'vdda-1p2-supply' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb edp@aea0000: '#address-cells', '#clock-cells', '#size-cells', 'opp-table' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb arch/arm64/boot/dts/qcom/sc7280-idp2.dtb arch/arm64/boot/dts/qcom/sc7280-idp.dtb edp@aea0000: clock-names:0: 'core_iface' was expected arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb arch/arm64/boot/dts/qcom/sc7280-idp2.dtb arch/arm64/boot/dts/qcom/sc7280-idp.dtb edp@aea0000: clock-names:1: 'core_aux' was expected arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb arch/arm64/boot/dts/qcom/sc7280-idp2.dtb arch/arm64/boot/dts/qcom/sc7280-idp.dtb edp@aea0000: clock-names:2: 'ctrl_link' was expected arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb arch/arm64/boot/dts/qcom/sc7280-idp2.dtb arch/arm64/boot/dts/qcom/sc7280-idp.dtb edp@aea0000: clock-names:3: 'ctrl_link_iface' was expected arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb arch/arm64/boot/dts/qcom/sc7280-idp2.dtb arch/arm64/boot/dts/qcom/sc7280-idp.dtb edp@aea0000: clock-names:4: 'stream_pixel' was expected arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb arch/arm64/boot/dts/qcom/sc7280-idp2.dtb arch/arm64/boot/dts/qcom/sc7280-idp.dtb edp@aea0000: clock-names: ['core_xo', 'core_ref', 'core_iface', 'core_aux', 'ctrl_link', 'ctrl_link_iface', 'stream_pixel'] is too long arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb arch/arm64/boot/dts/qcom/sc7280-idp2.dtb arch/arm64/boot/dts/qcom/sc7280-idp.dtb edp@aea0000: clocks: [[39, 0], [42, 183], [286, 1], [286, 17], [286, 19], [286, 22], [286, 23]] is too long arch/arm64/boot/dts/qcom/sc7280-idp.dtb edp@aea0000: clocks: [[39, 0], [42, 183], [291, 1], [291, 17], [291, 19], [291, 22], [291, 23]] is too long arch/arm64/boot/dts/qcom/sc7280-idp2.dtb edp@aea0000: clocks: [[39, 0], [42, 183], [294, 1], [294, 17], [294, 19], [294, 22], [294, 23]] is too long arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb edp@aea0000: clocks: [[39, 0], [42, 183], [299, 1], [299, 17], [299, 19], [299, 22], [299, 23]] is too long arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb edp@aea0000: clocks: [[39, 0], [42, 183], [302, 1], [302, 17], [302, 19], [302, 22], [302, 23]] is too long arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb edp@aea0000: reg: [[0, 183107584, 0, 512], [0, 183108096, 0, 512], [0, 183108608, 0, 3072], [0, 183111680, 0, 1024]] is too short arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb arch/arm64/boot/dts/qcom/sc7280-idp2.dtb arch/arm64/boot/dts/qcom/sc7280-idp.dtb edp@aea0000: '#sound-dai-cells' is a required property arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb
On 10/08/2022 06:50, Bjorn Andersson wrote: > Add compatibles for the DisplayPort and Embedded DisplayPort blocks in > Qualcomm SDM845 and SC8280XP platforms. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > .../devicetree/bindings/display/msm/dp-controller.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index 94bc6e1b6451..90f9302d1731 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > @@ -16,11 +16,14 @@ description: | > properties: > compatible: > enum: > + - qcom,sdm845-dp > - qcom,sc7180-dp Alphabetical order, please. The DTS warnings from the bot look unrelated to this patch. Best regards, Krzysztof
On Wed, Aug 10, 2022 at 05:47:52PM +0300, Krzysztof Kozlowski wrote: > On 10/08/2022 06:50, Bjorn Andersson wrote: > > Add compatibles for the DisplayPort and Embedded DisplayPort blocks in > > Qualcomm SDM845 and SC8280XP platforms. > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > --- > > .../devicetree/bindings/display/msm/dp-controller.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > index 94bc6e1b6451..90f9302d1731 100644 > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > @@ -16,11 +16,14 @@ description: | > > properties: > > compatible: > > enum: > > + - qcom,sdm845-dp > > - qcom,sc7180-dp > > Alphabetical order, please. > > The DTS warnings from the bot look unrelated to this patch. Yes, but there are a ton of them and I thought Bjorn might care. Looks like the schema is pretty out of sync with reality and they don't really look like dts side fixes. Rob
On 10/08/2022 22:20, Rob Herring wrote: > On Wed, Aug 10, 2022 at 05:47:52PM +0300, Krzysztof Kozlowski wrote: >> On 10/08/2022 06:50, Bjorn Andersson wrote: >>> Add compatibles for the DisplayPort and Embedded DisplayPort blocks in >>> Qualcomm SDM845 and SC8280XP platforms. >>> >>> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> >>> --- >>> .../devicetree/bindings/display/msm/dp-controller.yaml | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>> index 94bc6e1b6451..90f9302d1731 100644 >>> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>> @@ -16,11 +16,14 @@ description: | >>> properties: >>> compatible: >>> enum: >>> + - qcom,sdm845-dp >>> - qcom,sc7180-dp >> >> Alphabetical order, please. >> >> The DTS warnings from the bot look unrelated to this patch. > > Yes, but there are a ton of them and I thought Bjorn might care. Looks > like the schema is pretty out of sync with reality and they don't really > look like dts side fixes. It's in progress by Dmitry: https://lore.kernel.org/all/20220710084133.30976-1-dmitry.baryshkov@linaro.org/ Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index 94bc6e1b6451..90f9302d1731 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml @@ -16,11 +16,14 @@ description: | properties: compatible: enum: + - qcom,sdm845-dp - qcom,sc7180-dp - qcom,sc7280-dp - qcom,sc7280-edp - qcom,sc8180x-dp - qcom,sc8180x-edp + - qcom,sc8280xp-dp + - qcom,sc8280xp-edp - qcom,sm8350-dp reg:
Add compatibles for the DisplayPort and Embedded DisplayPort blocks in Qualcomm SDM845 and SC8280XP platforms. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- .../devicetree/bindings/display/msm/dp-controller.yaml | 3 +++ 1 file changed, 3 insertions(+)