| Message ID | 20220809152534.292034-2-frieder@fris.de |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | ARM: dts: imx6ul-kontron: Improve devicetrees | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 09/08/2022 18:25, Frieder Schrempf wrote: > From: Frieder Schrempf <frieder.schrempf@kontron.de> > > This updates the bindings in order to simplify the devicetree > structure and to add names for the boards that follow the latest > convention used by Kontron marketing. > > Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de> > --- > .../devicetree/bindings/arm/fsl.yaml | 31 +++++++------------ > 1 file changed, 12 insertions(+), 19 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index ef524378d449..7c4c27d553ec 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -553,8 +553,7 @@ properties: > - engicam,imx6ul-isiot # Engicam Is.IoT MX6UL eMMC/NAND Starter kit > - fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board > - karo,imx6ul-tx6ul # Ka-Ro electronics TXUL-0010 Module > - - kontron,imx6ul-n6310-som # Kontron N6310 SOM > - - kontron,imx6ul-n6311-som # Kontron N6311 SOM > + - kontron,imx6ul-n631x-som # Kontron SL i.MX6UL (N631X SOM) Although board-level compatibles are not that important, yet still they follow the same rules as other DT bindings: no wildcards for compatibles. Therefore the change is not correct, in my opinion. Best regards, Krzysztof
Am 09.08.22 um 17:55 schrieb Krzysztof Kozlowski: > On 09/08/2022 18:25, Frieder Schrempf wrote: >> From: Frieder Schrempf <frieder.schrempf@kontron.de> >> >> This updates the bindings in order to simplify the devicetree >> structure and to add names for the boards that follow the latest >> convention used by Kontron marketing. >> >> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de> >> --- >> .../devicetree/bindings/arm/fsl.yaml | 31 +++++++------------ >> 1 file changed, 12 insertions(+), 19 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >> index ef524378d449..7c4c27d553ec 100644 >> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >> @@ -553,8 +553,7 @@ properties: >> - engicam,imx6ul-isiot # Engicam Is.IoT MX6UL eMMC/NAND Starter kit >> - fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board >> - karo,imx6ul-tx6ul # Ka-Ro electronics TXUL-0010 Module >> - - kontron,imx6ul-n6310-som # Kontron N6310 SOM >> - - kontron,imx6ul-n6311-som # Kontron N6311 SOM >> + - kontron,imx6ul-n631x-som # Kontron SL i.MX6UL (N631X SOM) > > Although board-level compatibles are not that important, yet still they > follow the same rules as other DT bindings: no wildcards for compatibles. > > Therefore the change is not correct, in my opinion. Ok, I see your point. I will look for a way to get rid of the wildcard in the compatible. Either by keeping the old names and having some duplication in the devicetree files or by renaming the compatibles altogether, as the N6xxx notation is not used nowadays anyway.
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index ef524378d449..7c4c27d553ec 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -553,8 +553,7 @@ properties: - engicam,imx6ul-isiot # Engicam Is.IoT MX6UL eMMC/NAND Starter kit - fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board - karo,imx6ul-tx6ul # Ka-Ro electronics TXUL-0010 Module - - kontron,imx6ul-n6310-som # Kontron N6310 SOM - - kontron,imx6ul-n6311-som # Kontron N6311 SOM + - kontron,imx6ul-n631x-som # Kontron SL i.MX6UL (N631X SOM) - prt,prti6g # Protonic PRTI6G Board - technexion,imx6ul-pico-dwarf # TechNexion i.MX6UL Pico-Dwarf - technexion,imx6ul-pico-hobbit # TechNexion i.MX6UL Pico-Hobbit @@ -590,23 +589,17 @@ properties: - const: phytec,imx6ul-pcl063 # PHYTEC phyCORE-i.MX 6UL - const: fsl,imx6ul - - description: Kontron N6310 S Board + - description: Kontron BL i.MX6UL (N631X S) Board items: - - const: kontron,imx6ul-n6310-s - - const: kontron,imx6ul-n6310-som + - const: kontron,imx6ul-n631x-s + - const: kontron,imx6ul-n631x-som - const: fsl,imx6ul - - description: Kontron N6311 S Board + - description: Kontron BL i.MX6UL 43 (N631X S 43) Board items: - - const: kontron,imx6ul-n6311-s - - const: kontron,imx6ul-n6311-som - - const: fsl,imx6ul - - - description: Kontron N6310 S 43 Board - items: - - const: kontron,imx6ul-n6310-s-43 - - const: kontron,imx6ul-n6310-s - - const: kontron,imx6ul-n6310-som + - const: kontron,imx6ul-n631x-s-43 + - const: kontron,imx6ul-n631x-s + - const: kontron,imx6ul-n631x-som - const: fsl,imx6ul - description: TQ-Systems TQMa6UL1 SoM on MBa6ULx board @@ -636,7 +629,7 @@ properties: - enum: - fsl,imx6ull-14x14-evk # i.MX6 UltraLiteLite 14x14 EVK Board - joz,jozacp # JOZ Access Point - - kontron,imx6ull-n6411-som # Kontron N6411 SOM + - kontron,imx6ull-n641x-som # Kontron SL i.MX6ULL (N641X SOM) - myir,imx6ull-mys-6ulx-eval # MYiR Tech iMX6ULL Evaluation Board - toradex,colibri-imx6ull # Colibri iMX6ULL Modules - toradex,colibri-imx6ull-emmc # Colibri iMX6ULL 1GB (eMMC) Module @@ -697,10 +690,10 @@ properties: - const: toradex,colibri-imx6ull-wifi # Colibri iMX6ULL Wi-Fi / BT Module - const: fsl,imx6ull - - description: Kontron N6411 S Board + - description: Kontron BL i.MX6ULL (N6411 S) Board items: - - const: kontron,imx6ull-n6411-s - - const: kontron,imx6ull-n6411-som + - const: kontron,imx6ull-n641x-s + - const: kontron,imx6ull-n641x-som - const: fsl,imx6ull - description: TQ Systems TQMa6ULLx SoM on MBa6ULx board