| Message ID | 20220806141059.2498226-4-vladimir.oltean@nxp.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Validate OF nodes for DSA shared ports | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Sat, 06 Aug 2022 17:10:52 +0300, Vladimir Oltean wrote: > Looking at b53_srab_phylink_get_caps() I get no indication of what PHY > modes does port 8 support, since it is implemented circularly based on > the p->mode retrieved from the device tree (and in PHY_INTERFACE_MODE_NA > it reports nothing to supported_interfaces). > > However if I look at the b53_switch_chips[] element for BCM58XX_DEVICE_ID, > I see that port 8 is the IMP port, and SRAB means the IMP port is > internal to the SoC. So use phy-mode = "internal" in the example. > > Note that this will make b53_srab_phylink_get_caps() go through the > "default" case and report PHY_INTERFACE_MODE_INTERNAL to > supported_interfaces, which is probably a good thing. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > --- > v2->v3: patch is new > > Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml b/Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml index 23114d691d2a..2e01371b8288 100644 --- a/Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml +++ b/Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml @@ -254,6 +254,8 @@ examples: ethernet = <&amac2>; label = "cpu"; reg = <8>; + phy-mode = "internal"; + fixed-link { speed = <1000>; full-duplex;
Looking at b53_srab_phylink_get_caps() I get no indication of what PHY modes does port 8 support, since it is implemented circularly based on the p->mode retrieved from the device tree (and in PHY_INTERFACE_MODE_NA it reports nothing to supported_interfaces). However if I look at the b53_switch_chips[] element for BCM58XX_DEVICE_ID, I see that port 8 is the IMP port, and SRAB means the IMP port is internal to the SoC. So use phy-mode = "internal" in the example. Note that this will make b53_srab_phylink_get_caps() go through the "default" case and report PHY_INTERFACE_MODE_INTERNAL to supported_interfaces, which is probably a good thing. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- v2->v3: patch is new Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml | 2 ++ 1 file changed, 2 insertions(+)