| Message ID | 20220729052112.3235325-1-masahiroy@kernel.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | dt-bindings: remove the dead code in cmd_mk_schema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 12 lines checked |
| robh/patch-applied | success |
On Fri, Jul 29, 2022 at 02:21:12PM +0900, Masahiro Yamada wrote: > Since commit 2783a7f56f99 ("dt-bindings: kbuild: Pass DT_SCHEMA_FILES to > dt-validate"), the processed schema takes all the YAML files. > > Remove the dead code. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > Documentation/devicetree/bindings/Makefile | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) I also sent out a similar patch[1]. > > diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile > index c9953f86b19d..223df2a023fd 100644 > --- a/Documentation/devicetree/bindings/Makefile > +++ b/Documentation/devicetree/bindings/Makefile > @@ -42,10 +42,8 @@ quiet_cmd_chk_bindings = CHKDT $@ > > quiet_cmd_mk_schema = SCHEMA $@ > cmd_mk_schema = f=$$(mktemp) ; \ > - $(if $(DT_MK_SCHEMA_FLAGS), \ > - printf '%s\n' $(real-prereqs), \ > - $(find_all_cmd)) > $$f ; \ > - $(DT_MK_SCHEMA) -j $(DT_MK_SCHEMA_FLAGS) @$$f > $@ ; \ > + $(find_all_cmd) > $$f ; \ > + $(DT_MK_SCHEMA) -j @$$f > $@ ; \ I want to keep DT_MK_SCHEMA_FLAGS because I'm working on a new optional flag to pass. Rob [1] https://lore.kernel.org/all/20220727211100.3249417-1-robh@kernel.org/
diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile index c9953f86b19d..223df2a023fd 100644 --- a/Documentation/devicetree/bindings/Makefile +++ b/Documentation/devicetree/bindings/Makefile @@ -42,10 +42,8 @@ quiet_cmd_chk_bindings = CHKDT $@ quiet_cmd_mk_schema = SCHEMA $@ cmd_mk_schema = f=$$(mktemp) ; \ - $(if $(DT_MK_SCHEMA_FLAGS), \ - printf '%s\n' $(real-prereqs), \ - $(find_all_cmd)) > $$f ; \ - $(DT_MK_SCHEMA) -j $(DT_MK_SCHEMA_FLAGS) @$$f > $@ ; \ + $(find_all_cmd) > $$f ; \ + $(DT_MK_SCHEMA) -j @$$f > $@ ; \ rm -f $$f define rule_chkdt
Since commit 2783a7f56f99 ("dt-bindings: kbuild: Pass DT_SCHEMA_FILES to dt-validate"), the processed schema takes all the YAML files. Remove the dead code. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- Documentation/devicetree/bindings/Makefile | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)