Message ID | 20220728143215.v3.1.I5b9006878bdabd6493b866b46dbd6149968d545b@changeid |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | [v3,1/2] dt-bindings: arm: qcom: document zoglin board | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/patch-applied | fail | build log |
Hi, On Thu, Jul 28, 2022 at 2:33 PM Bob Moragues <moragues@chromium.org> wrote: > > Zoglin is a Hoglin Chromebook with SPI Flash reduced from 64MB to 8MB. > Zoglin is identical to Hoglin except for the SPI Flash. > The actual SPI Flash is dynamically probed at and not specified in DTS. > > Reviewed-by: Douglas Anderson <dianders@chromium.org> > Acked-by: Rob Herring <robh@kernel.org> > Signed-off-by: Bob Moragues <moragues@chromium.org> A nit from my point of view is that I would have expected your Signed-off-by to be the first tag. As I understand it the tags are usually supposed to be a top-to-bottom history of what happened. You signed off on the patch and then people added reviews / acks. I don't personally think this is important enough to spin a v4 for, though the last word would be Bjorn. > --- > > Changes in v3: > - Fixed Author > - Fixed duplicate Signed-off-by Technically this should have been: Changes in v3: - Really really fixed Signed-off-by Changes in v2: - Fixed Author - Fixed duplicate Signed-off-by ...but that's also not really worth spinning for. I think this looks good now. Though unofficial (and not stable git hashes), I've been trying to keep track of some patches during this dead time till -rc1. I've put your two patches here: https://github.com/dianders/kernel-staging/commits/qcom/arm64-staging -Doug
On Thu, 28 Jul 2022 14:33:20 -0700, Bob Moragues wrote: > Zoglin is a Hoglin Chromebook with SPI Flash reduced from 64MB to 8MB. > Zoglin is identical to Hoglin except for the SPI Flash. > The actual SPI Flash is dynamically probed at and not specified in DTS. > > Applied, thanks! [1/2] dt-bindings: arm: qcom: document zoglin board commit: f72a9f525b98aca1ad134e163e070d614ff60a24 [2/2] arm64: dts: qcom: sc7280: Add support for zoglin commit: 2cb88ebe44531ba18c908e627811698c9461b4cb Best regards,
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 581485392404..63091df3cbb3 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -475,6 +475,7 @@ properties: - description: Qualcomm Technologies, Inc. sc7280 CRD platform (newest rev) items: + - const: google,zoglin - const: google,hoglin - const: qcom,sc7280