| Message ID | 20220728111740.30595-1-peremen@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 28/07/2022 13:17, Shinjo Park wrote: > Document the changes introduced by MSM8960 inclusion. > 1. Thread your submissions. 2. Use subject prefix matching the file. > Signed-off-by: Shinjo Park <peremen@gmail.com> > Reviewed-by: David Heidelberg <david@ixit.cz> It is a v1. How the review tag got here? Best regards, Krzysztof
On 28/07/2022 13:47, Krzysztof Kozlowski wrote: > On 28/07/2022 13:17, Shinjo Park wrote: >> Document the changes introduced by MSM8960 inclusion. >> > 1. Thread your submissions. > 2. Use subject prefix matching the file. > >> Signed-off-by: Shinjo Park <peremen@gmail.com> >> Reviewed-by: David Heidelberg <david@ixit.cz> > It is a v1. How the review tag got here? We have a Matrix channel ( #linux-apq8064:matrix.org and downstream fork for apq8064/msm8960 [1]), so I saw the patch before it was send to ML. David [1] https://github.com/apq8064-mainline/linux > > Best regards, > Krzysztof
On 28/07/2022 13:54, David Heidelberg wrote: > On 28/07/2022 13:47, Krzysztof Kozlowski wrote: >> On 28/07/2022 13:17, Shinjo Park wrote: >>> Document the changes introduced by MSM8960 inclusion. >>> >> 1. Thread your submissions. >> 2. Use subject prefix matching the file. >> >>> Signed-off-by: Shinjo Park <peremen@gmail.com> >>> Reviewed-by: David Heidelberg <david@ixit.cz> >> It is a v1. How the review tag got here? > > We have a Matrix channel ( #linux-apq8064:matrix.org and downstream fork > for apq8064/msm8960 [1]), so I saw the patch before it was send to ML. > > David New submitters and beginners should rather use full-mailing list process. Since there is quite a chance of beginner mistakes (which was seen here), they might misunderstand something and add Reviewed-by tag even if not received it with respective "Reviewer's statement of oversight". Best regards, Krzysztof
On 28/07/2022 15:54, Shinjo Park wrote: > Hello Krzysztof, > > Sorry for any confusion during my first patch submission. > > PATCH 1: >>> Change the reference of sleep_clk to the same as qcom-apq8064.dtsi. >> >> You add label, not change something. > >>> - sleep_clk { > >>> + sleep_clk: sleep_clk { > >> > >> Since you touch the line, make the device node sleep-clk (device node > >> names should not have underscores) and mention this in commit msg. > > > I can change the line into "sleep_clk: sleep-clk". And the commit message > would be "Change the device node of sleep_clk to sleep-clk and add a > label"? Another problem is that in the same .dtsi file there are other > device nodes containing underscores (cxo_board, pxo_board). Should I also > change these in the patch? > > PATCH 2: >>> + phy-names = "usb-phy"; >>> + status = "disabled"; >> >> status is the last property. >> >>> + #reset-cells = <1>; > > I can move #reset-cells one line up and make the status last line. On the > other hand, the same definition is also used in > arch/arm/boot/dts/qcom-apq8064.dtsi (also the clock definition mentioned in > PATCH 1). Shall I include another patch for that file in the next revision > of this patch series? Yes, you can rename them in other patch as well. > > PATH 3: >> 1. Thread your submissions. > > Shall I use this thread for all follow-ups for my first and second patch? No. One patchset, one thread. https://elixir.bootlin.com/linux/v5.19-rc5/source/Documentation/process/5.Posting.rst > >> 2. Use subject prefix matching the file. > > If I understood correctly, then this should be "dt-bindings: phy: > qcom,usb-hs-phy:"? Yes. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml index 0655e485b..b3075c5ab 100644 --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml @@ -40,6 +40,7 @@ properties: - qcom,usb-hs-phy-apq8064 - qcom,usb-hs-phy-msm8226 - qcom,usb-hs-phy-msm8916 + - qcom,usb-hs-phy-msm8960 - qcom,usb-hs-phy-msm8974 - const: qcom,usb-hs-phy