| Message ID | 20220726180623.1668-2-prabhakar.mahadev-lad.rj@bp.renesas.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add support for Renesas RZ/Five SoC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 26/07/2022 20:06, Lad Prabhakar wrote: > Ignore the ARM renesas.yaml schema if the board is RZ/Five SMARC EVK > (RISC-V arch). Your commit msg says one, but patch ignores r9a07g043f01 which sounds entirely different for non-Renesas people. Be a bit more clear. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > Documentation/devicetree/bindings/arm/renesas.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml > index ff80152f092f..f646df1a23af 100644 > --- a/Documentation/devicetree/bindings/arm/renesas.yaml > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml > @@ -9,6 +9,15 @@ title: Renesas SH-Mobile, R-Mobile, and R-Car Platform Device Tree Bindings > maintainers: > - Geert Uytterhoeven <geert+renesas@glider.be> > > +# We want to ignore this schema if the board is of RISC-V arch > +select: > + not: > + properties: > + compatible: > + contains: > + items: It is only one item, so I guess you wanted here enum. Just like syscon is doing... > + - const: renesas,r9a07g043f01 > + > properties: > $nodename: > const: '/' Best regards, Krzysztof
On 26/07/2022 20:06, Lad Prabhakar wrote: > Ignore the ARM renesas.yaml schema if the board is RZ/Five SMARC EVK > (RISC-V arch). > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > Documentation/devicetree/bindings/arm/renesas.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml > index ff80152f092f..f646df1a23af 100644 > --- a/Documentation/devicetree/bindings/arm/renesas.yaml > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml > @@ -9,6 +9,15 @@ title: Renesas SH-Mobile, R-Mobile, and R-Car Platform Device Tree Bindings > maintainers: > - Geert Uytterhoeven <geert+renesas@glider.be> > > +# We want to ignore this schema if the board is of RISC-V arch > +select: > + not: > + properties: > + compatible: > + contains: > + items: > + - const: renesas,r9a07g043f01 Second issue - why not renesas,r9a07g043? Best regards, Krzysztof
Hi Krzysztof, Thank you for the review. On Wed, Jul 27, 2022 at 9:51 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 26/07/2022 20:06, Lad Prabhakar wrote: > > Ignore the ARM renesas.yaml schema if the board is RZ/Five SMARC EVK > > (RISC-V arch). > > Your commit msg says one, but patch ignores r9a07g043f01 which sounds > entirely different for non-Renesas people. Be a bit more clear. > Sure will update the commit message. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > --- > > Documentation/devicetree/bindings/arm/renesas.yaml | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml > > index ff80152f092f..f646df1a23af 100644 > > --- a/Documentation/devicetree/bindings/arm/renesas.yaml > > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml > > @@ -9,6 +9,15 @@ title: Renesas SH-Mobile, R-Mobile, and R-Car Platform Device Tree Bindings > > maintainers: > > - Geert Uytterhoeven <geert+renesas@glider.be> > > > > +# We want to ignore this schema if the board is of RISC-V arch > > +select: > > + not: > > + properties: > > + compatible: > > + contains: > > + items: > > It is only one item, so I guess you wanted here enum. > > Just like syscon is doing... > Ok I will switch to enum. Cheers, Prabhakar
Hi Krzysztof, On Wed, Jul 27, 2022 at 9:53 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 26/07/2022 20:06, Lad Prabhakar wrote: > > Ignore the ARM renesas.yaml schema if the board is RZ/Five SMARC EVK > > (RISC-V arch). > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > --- > > Documentation/devicetree/bindings/arm/renesas.yaml | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml > > index ff80152f092f..f646df1a23af 100644 > > --- a/Documentation/devicetree/bindings/arm/renesas.yaml > > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml > > @@ -9,6 +9,15 @@ title: Renesas SH-Mobile, R-Mobile, and R-Car Platform Device Tree Bindings > > maintainers: > > - Geert Uytterhoeven <geert+renesas@glider.be> > > > > +# We want to ignore this schema if the board is of RISC-V arch > > +select: > > + not: > > + properties: > > + compatible: > > + contains: > > + items: > > + - const: renesas,r9a07g043f01 > > Second issue - why not renesas,r9a07g043? > We have two R9A07G043 SOC'S one is based on ARM64 and other on RISC-V. RZ/G2UL ARM64: Type-1 Part Number: R9A07G043U11GBG#BC0 Type-2 Part Number: R9A07G043U12GBG#BC0 RZ/Five RISCV: 13 x 13 mm Package Part Number: R9A07G043F01GBG#BC0 So to differentiate in ARM schema I am using renesas,r9a07g043f01. Cheers, Prabhakar
On 27/07/2022 11:00, Lad, Prabhakar wrote: > Hi Krzysztof, > > On Wed, Jul 27, 2022 at 9:53 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 26/07/2022 20:06, Lad Prabhakar wrote: >>> Ignore the ARM renesas.yaml schema if the board is RZ/Five SMARC EVK >>> (RISC-V arch). >>> >>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> >>> --- >>> Documentation/devicetree/bindings/arm/renesas.yaml | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml >>> index ff80152f092f..f646df1a23af 100644 >>> --- a/Documentation/devicetree/bindings/arm/renesas.yaml >>> +++ b/Documentation/devicetree/bindings/arm/renesas.yaml >>> @@ -9,6 +9,15 @@ title: Renesas SH-Mobile, R-Mobile, and R-Car Platform Device Tree Bindings >>> maintainers: >>> - Geert Uytterhoeven <geert+renesas@glider.be> >>> >>> +# We want to ignore this schema if the board is of RISC-V arch >>> +select: >>> + not: >>> + properties: >>> + compatible: >>> + contains: >>> + items: >>> + - const: renesas,r9a07g043f01 >> >> Second issue - why not renesas,r9a07g043? >> > We have two R9A07G043 SOC'S one is based on ARM64 and other on RISC-V. > > RZ/G2UL ARM64: > Type-1 Part Number: R9A07G043U11GBG#BC0 > Type-2 Part Number: R9A07G043U12GBG#BC0 > > RZ/Five RISCV: > 13 x 13 mm Package Part Number: R9A07G043F01GBG#BC0 > > So to differentiate in ARM schema I am using renesas,r9a07g043f01. What is the point to keep then r9a07g043 fallback? The two SoCs are not compatible at all, so they must not use the same fallback. Best regards, Krzysztof
Hi Krzysztof, On Wed, Jul 27, 2022 at 10:31 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 27/07/2022 11:00, Lad, Prabhakar wrote: > > Hi Krzysztof, > > > > On Wed, Jul 27, 2022 at 9:53 AM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> On 26/07/2022 20:06, Lad Prabhakar wrote: > >>> Ignore the ARM renesas.yaml schema if the board is RZ/Five SMARC EVK > >>> (RISC-V arch). > >>> > >>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > >>> --- > >>> Documentation/devicetree/bindings/arm/renesas.yaml | 9 +++++++++ > >>> 1 file changed, 9 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml > >>> index ff80152f092f..f646df1a23af 100644 > >>> --- a/Documentation/devicetree/bindings/arm/renesas.yaml > >>> +++ b/Documentation/devicetree/bindings/arm/renesas.yaml > >>> @@ -9,6 +9,15 @@ title: Renesas SH-Mobile, R-Mobile, and R-Car Platform Device Tree Bindings > >>> maintainers: > >>> - Geert Uytterhoeven <geert+renesas@glider.be> > >>> > >>> +# We want to ignore this schema if the board is of RISC-V arch > >>> +select: > >>> + not: > >>> + properties: > >>> + compatible: > >>> + contains: > >>> + items: > >>> + - const: renesas,r9a07g043f01 > >> > >> Second issue - why not renesas,r9a07g043? > >> > > We have two R9A07G043 SOC'S one is based on ARM64 and other on RISC-V. > > > > RZ/G2UL ARM64: > > Type-1 Part Number: R9A07G043U11GBG#BC0 > > Type-2 Part Number: R9A07G043U12GBG#BC0 > > > > RZ/Five RISCV: > > 13 x 13 mm Package Part Number: R9A07G043F01GBG#BC0 > > > > So to differentiate in ARM schema I am using renesas,r9a07g043f01. > > What is the point to keep then r9a07g043 fallback? The two SoCs are not > compatible at all, so they must not use the same fallback. > Agreed, I wanted to keep it consistent with what was done with ARM64 (since both the SoCs shared R9A07G043 part number). Geert - What are your thoughts on the above? Cheers, Prabhakar
On Tue, Jul 26, 2022 at 07:06:18PM +0100, Lad Prabhakar wrote: > Ignore the ARM renesas.yaml schema if the board is RZ/Five SMARC EVK > (RISC-V arch). > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > Documentation/devicetree/bindings/arm/renesas.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml > index ff80152f092f..f646df1a23af 100644 > --- a/Documentation/devicetree/bindings/arm/renesas.yaml > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml > @@ -9,6 +9,15 @@ title: Renesas SH-Mobile, R-Mobile, and R-Car Platform Device Tree Bindings > maintainers: > - Geert Uytterhoeven <geert+renesas@glider.be> > > +# We want to ignore this schema if the board is of RISC-V arch > +select: > + not: > + properties: > + compatible: > + contains: > + items: > + - const: renesas,r9a07g043f01 As I've said, this doesn't work without tool changes I proposed. Rob
Hi Prabhakar, On Wed, Jul 27, 2022 at 11:48 AM Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote: > On Wed, Jul 27, 2022 at 10:31 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: > > On 27/07/2022 11:00, Lad, Prabhakar wrote: > > > On Wed, Jul 27, 2022 at 9:53 AM Krzysztof Kozlowski > > > <krzysztof.kozlowski@linaro.org> wrote: > > >> On 26/07/2022 20:06, Lad Prabhakar wrote: > > >>> Ignore the ARM renesas.yaml schema if the board is RZ/Five SMARC EVK > > >>> (RISC-V arch). > > >>> > > >>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > >>> --- > > >>> Documentation/devicetree/bindings/arm/renesas.yaml | 9 +++++++++ > > >>> 1 file changed, 9 insertions(+) > > >>> > > >>> diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml > > >>> index ff80152f092f..f646df1a23af 100644 > > >>> --- a/Documentation/devicetree/bindings/arm/renesas.yaml > > >>> +++ b/Documentation/devicetree/bindings/arm/renesas.yaml > > >>> @@ -9,6 +9,15 @@ title: Renesas SH-Mobile, R-Mobile, and R-Car Platform Device Tree Bindings > > >>> maintainers: > > >>> - Geert Uytterhoeven <geert+renesas@glider.be> > > >>> > > >>> +# We want to ignore this schema if the board is of RISC-V arch > > >>> +select: > > >>> + not: > > >>> + properties: > > >>> + compatible: > > >>> + contains: > > >>> + items: > > >>> + - const: renesas,r9a07g043f01 > > >> > > >> Second issue - why not renesas,r9a07g043? > > >> > > > We have two R9A07G043 SOC'S one is based on ARM64 and other on RISC-V. > > > > > > RZ/G2UL ARM64: > > > Type-1 Part Number: R9A07G043U11GBG#BC0 > > > Type-2 Part Number: R9A07G043U12GBG#BC0 > > > > > > RZ/Five RISCV: > > > 13 x 13 mm Package Part Number: R9A07G043F01GBG#BC0 > > > > > > So to differentiate in ARM schema I am using renesas,r9a07g043f01. > > > > What is the point to keep then r9a07g043 fallback? The two SoCs are not > > compatible at all, so they must not use the same fallback. > > > Agreed, I wanted to keep it consistent with what was done with ARM64 > (since both the SoCs shared R9A07G043 part number). > > Geert - What are your thoughts on the above? "renesas,r9a07g043" is the CPU-less SoC base containing I/O devices. "renesas,r9a07g043f01", "renesas,r9a07g043u11", and "renesas,r9a07g043u12" are SoCs built by integrating one or more RV64 or ARM64 CPU cores and the related interrupt controllers with the CPU-less SoC base. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, On Thu, Aug 11, 2022 at 4:26 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Wed, Jul 27, 2022 at 11:48 AM Lad, Prabhakar > <prabhakar.csengg@gmail.com> wrote: > > On Wed, Jul 27, 2022 at 10:31 AM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > > > On 27/07/2022 11:00, Lad, Prabhakar wrote: > > > > On Wed, Jul 27, 2022 at 9:53 AM Krzysztof Kozlowski > > > > <krzysztof.kozlowski@linaro.org> wrote: > > > >> On 26/07/2022 20:06, Lad Prabhakar wrote: > > > >>> Ignore the ARM renesas.yaml schema if the board is RZ/Five SMARC EVK > > > >>> (RISC-V arch). > > > >>> > > > >>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > >>> --- > > > >>> Documentation/devicetree/bindings/arm/renesas.yaml | 9 +++++++++ > > > >>> 1 file changed, 9 insertions(+) > > > >>> > > > >>> diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml > > > >>> index ff80152f092f..f646df1a23af 100644 > > > >>> --- a/Documentation/devicetree/bindings/arm/renesas.yaml > > > >>> +++ b/Documentation/devicetree/bindings/arm/renesas.yaml > > > >>> @@ -9,6 +9,15 @@ title: Renesas SH-Mobile, R-Mobile, and R-Car Platform Device Tree Bindings > > > >>> maintainers: > > > >>> - Geert Uytterhoeven <geert+renesas@glider.be> > > > >>> > > > >>> +# We want to ignore this schema if the board is of RISC-V arch > > > >>> +select: > > > >>> + not: > > > >>> + properties: > > > >>> + compatible: > > > >>> + contains: > > > >>> + items: > > > >>> + - const: renesas,r9a07g043f01 > > > >> > > > >> Second issue - why not renesas,r9a07g043? > > > >> > > > > We have two R9A07G043 SOC'S one is based on ARM64 and other on RISC-V. > > > > > > > > RZ/G2UL ARM64: > > > > Type-1 Part Number: R9A07G043U11GBG#BC0 > > > > Type-2 Part Number: R9A07G043U12GBG#BC0 > > > > > > > > RZ/Five RISCV: > > > > 13 x 13 mm Package Part Number: R9A07G043F01GBG#BC0 > > > > > > > > So to differentiate in ARM schema I am using renesas,r9a07g043f01. > > > > > > What is the point to keep then r9a07g043 fallback? The two SoCs are not > > > compatible at all, so they must not use the same fallback. > > > > > Agreed, I wanted to keep it consistent with what was done with ARM64 > > (since both the SoCs shared R9A07G043 part number). > > > > Geert - What are your thoughts on the above? > > "renesas,r9a07g043" is the CPU-less SoC base containing I/O devices. > "renesas,r9a07g043f01", "renesas,r9a07g043u11", and > "renesas,r9a07g043u12" are SoCs built by integrating one or more > RV64 or ARM64 CPU cores and the related interrupt controllers with > the CPU-less SoC base. > That's bang on! which I missed to convenience the DT maintainers. Cheers, Prabhakar
diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml index ff80152f092f..f646df1a23af 100644 --- a/Documentation/devicetree/bindings/arm/renesas.yaml +++ b/Documentation/devicetree/bindings/arm/renesas.yaml @@ -9,6 +9,15 @@ title: Renesas SH-Mobile, R-Mobile, and R-Car Platform Device Tree Bindings maintainers: - Geert Uytterhoeven <geert+renesas@glider.be> +# We want to ignore this schema if the board is of RISC-V arch +select: + not: + properties: + compatible: + contains: + items: + - const: renesas,r9a07g043f01 + properties: $nodename: const: '/'
Ignore the ARM renesas.yaml schema if the board is RZ/Five SMARC EVK (RISC-V arch). Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- Documentation/devicetree/bindings/arm/renesas.yaml | 9 +++++++++ 1 file changed, 9 insertions(+)