| Message ID | 20220722184138.2666241-2-f.fainelli@gmail.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Add Broadcom STB memory controller driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 22/07/2022 20:41, Florian Fainelli wrote: > Document the Broadcom STB memory controller which is a trivial binding > for now with a set of compatible strings and single register. > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > .../memory-controllers/brcm,memc.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/memory-controllers/brcm,memc.yaml > > diff --git a/Documentation/devicetree/bindings/memory-controllers/brcm,memc.yaml b/Documentation/devicetree/bindings/memory-controllers/brcm,memc.yaml > new file mode 100644 > index 000000000000..a629734f0cd0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/memory-controllers/brcm,memc.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/memory-controllers/brcm,memc.yaml# Filename like first compatible, so: brcm,brcmstb-memc-ddr.yaml > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Memory controller (MEMC) for Broadcom STB > + > +maintainers: > + - Florian Fainelli <f.fainelli@gmail.com> > + > +properties: > + compatible: > + items: > + - enum: > + - brcm,brcmstb-memc-ddr-rev-b.1.x > + - brcm,brcmstb-memc-ddr-rev-b.2.0 > + - brcm,brcmstb-memc-ddr-rev-b.2.1 > + - brcm,brcmstb-memc-ddr-rev-b.2.2 > + - brcm,brcmstb-memc-ddr-rev-b.2.3 > + - brcm,brcmstb-memc-ddr-rev-b.2.5 > + - brcm,brcmstb-memc-ddr-rev-b.2.6 > + - brcm,brcmstb-memc-ddr-rev-b.2.7 > + - brcm,brcmstb-memc-ddr-rev-b.2.8 > + - brcm,brcmstb-memc-ddr-rev-b.3.0 > + - brcm,brcmstb-memc-ddr-rev-b.3.1 > + - brcm,brcmstb-memc-ddr-rev-c.1.0 > + - brcm,brcmstb-memc-ddr-rev-c.1.1 > + - brcm,brcmstb-memc-ddr-rev-c.1.2 > + - brcm,brcmstb-memc-ddr-rev-c.1.3 > + - brcm,brcmstb-memc-ddr-rev-c.1.4 > + - const: brcm,brcmstb-memc-ddr > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + memory-controller@9902000 { > + compatible = "brcm,brcmstb-memc-ddr-rev-c.1.1", > + "brcm,brcmstb-memc-ddr"; Could you align it with previous quote "? Other than that, looks ok, but anyway this will have to wait for merge window to finish. > + reg = <0x9902000 0x600>; > + }; Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/memory-controllers/brcm,memc.yaml b/Documentation/devicetree/bindings/memory-controllers/brcm,memc.yaml new file mode 100644 index 000000000000..a629734f0cd0 --- /dev/null +++ b/Documentation/devicetree/bindings/memory-controllers/brcm,memc.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/memory-controllers/brcm,memc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Memory controller (MEMC) for Broadcom STB + +maintainers: + - Florian Fainelli <f.fainelli@gmail.com> + +properties: + compatible: + items: + - enum: + - brcm,brcmstb-memc-ddr-rev-b.1.x + - brcm,brcmstb-memc-ddr-rev-b.2.0 + - brcm,brcmstb-memc-ddr-rev-b.2.1 + - brcm,brcmstb-memc-ddr-rev-b.2.2 + - brcm,brcmstb-memc-ddr-rev-b.2.3 + - brcm,brcmstb-memc-ddr-rev-b.2.5 + - brcm,brcmstb-memc-ddr-rev-b.2.6 + - brcm,brcmstb-memc-ddr-rev-b.2.7 + - brcm,brcmstb-memc-ddr-rev-b.2.8 + - brcm,brcmstb-memc-ddr-rev-b.3.0 + - brcm,brcmstb-memc-ddr-rev-b.3.1 + - brcm,brcmstb-memc-ddr-rev-c.1.0 + - brcm,brcmstb-memc-ddr-rev-c.1.1 + - brcm,brcmstb-memc-ddr-rev-c.1.2 + - brcm,brcmstb-memc-ddr-rev-c.1.3 + - brcm,brcmstb-memc-ddr-rev-c.1.4 + - const: brcm,brcmstb-memc-ddr + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + memory-controller@9902000 { + compatible = "brcm,brcmstb-memc-ddr-rev-c.1.1", + "brcm,brcmstb-memc-ddr"; + reg = <0x9902000 0x600>; + };
Document the Broadcom STB memory controller which is a trivial binding for now with a set of compatible strings and single register. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- .../memory-controllers/brcm,memc.yaml | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/memory-controllers/brcm,memc.yaml