| Message ID | 20220720112924.1096-2-harini.katakam@xilinx.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add Versal compatible string to Macb driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 20/07/2022 13:29, Harini Katakam wrote: > From: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> > > Add versal compatible string. > > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> > Signed-off-by: Harini Katakam <harini.katakam@xilinx.com> > --- > Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml > index 9c92156869b2..1e9f49bb8249 100644 > --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml > +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml > @@ -22,6 +22,7 @@ properties: > - enum: > - cdns,zynq-gem # Xilinx Zynq-7xxx SoC > - cdns,zynqmp-gem # Xilinx Zynq Ultrascale+ MPSoC > + - cdns,versal-gem # Xilinx Versal Not really ordered by name. Why adding to the end? Best regards, Krzysztof
Hi Krzysztof, <snip> > > diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml > b/Documentation/devicetree/bindings/net/cdns,macb.yaml > > index 9c92156869b2..1e9f49bb8249 100644 > > --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml > > +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml > > @@ -22,6 +22,7 @@ properties: > > - enum: > > - cdns,zynq-gem # Xilinx Zynq-7xxx SoC > > - cdns,zynqmp-gem # Xilinx Zynq Ultrascale+ MPSoC > > + - cdns,versal-gem # Xilinx Versal > > Not really ordered by name. Why adding to the end? Thanks for the review. It is just based on the order in which device families from Xilinx were released. I can alphabetize if that's preferred. Regards, Harini
On 20/07/2022 13:36, Katakam, Harini wrote: >>> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml >> b/Documentation/devicetree/bindings/net/cdns,macb.yaml >>> index 9c92156869b2..1e9f49bb8249 100644 >>> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml >>> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml >>> @@ -22,6 +22,7 @@ properties: >>> - enum: >>> - cdns,zynq-gem # Xilinx Zynq-7xxx SoC >>> - cdns,zynqmp-gem # Xilinx Zynq Ultrascale+ MPSoC >>> + - cdns,versal-gem # Xilinx Versal >> >> Not really ordered by name. Why adding to the end? > > Thanks for the review. It is just based on the order in which device > families from Xilinx were released. I can alphabetize if that's preferred. Yes, it's the easiest way to avoid conflicts. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml index 9c92156869b2..1e9f49bb8249 100644 --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml @@ -22,6 +22,7 @@ properties: - enum: - cdns,zynq-gem # Xilinx Zynq-7xxx SoC - cdns,zynqmp-gem # Xilinx Zynq Ultrascale+ MPSoC + - cdns,versal-gem # Xilinx Versal - const: cdns,gem # Generic - items: