| Message ID | 20220711160519.741990-2-sean.anderson@seco.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | net: pcs: Add support for devices probed in the "usual" manner | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 11/07/2022 18:05, Sean Anderson wrote: > This adds bindings for the PCS half of the Lynx 10g/28g SerDes drivers. > > Signed-off-by: Sean Anderson <sean.anderson@seco.com> > --- > > .../devicetree/bindings/net/fsl,lynx-pcs.yaml | 47 +++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml > > diff --git a/Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml b/Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml > new file mode 100644 > index 000000000000..49dee66ab679 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml Shouldn't this be under net/pcs? Rest looks good to me: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Krzysztof, On 7/12/22 4:47 AM, Krzysztof Kozlowski wrote: > On 11/07/2022 18:05, Sean Anderson wrote: >> This adds bindings for the PCS half of the Lynx 10g/28g SerDes drivers. >> >> Signed-off-by: Sean Anderson <sean.anderson@seco.com> >> --- >> >> .../devicetree/bindings/net/fsl,lynx-pcs.yaml | 47 +++++++++++++++++++ >> 1 file changed, 47 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml b/Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml >> new file mode 100644 >> index 000000000000..49dee66ab679 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml > > Shouldn't this be under net/pcs? There's no net/pcs, since this is the first of its kind. There's no net/phy either, so I didn't bother creating one. --Sean
On 12/07/2022 16:57, Sean Anderson wrote: > Hi Krzysztof, > > On 7/12/22 4:47 AM, Krzysztof Kozlowski wrote: >> On 11/07/2022 18:05, Sean Anderson wrote: >>> This adds bindings for the PCS half of the Lynx 10g/28g SerDes drivers. >>> >>> Signed-off-by: Sean Anderson <sean.anderson@seco.com> >>> --- >>> >>> .../devicetree/bindings/net/fsl,lynx-pcs.yaml | 47 +++++++++++++++++++ >>> 1 file changed, 47 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml b/Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml >>> new file mode 100644 >>> index 000000000000..49dee66ab679 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml >> >> Shouldn't this be under net/pcs? > > There's no net/pcs, since this is the first of its kind. There is, coming via Renesas tree. > There's no net/phy > either, so I didn't bother creating one. Best regards, Krzysztof
On 7/12/22 11:00 AM, Krzysztof Kozlowski wrote: > On 12/07/2022 16:57, Sean Anderson wrote: >> Hi Krzysztof, >> >> On 7/12/22 4:47 AM, Krzysztof Kozlowski wrote: >>> On 11/07/2022 18:05, Sean Anderson wrote: >>>> This adds bindings for the PCS half of the Lynx 10g/28g SerDes drivers. >>>> >>>> Signed-off-by: Sean Anderson <sean.anderson@seco.com> >>>> --- >>>> >>>> .../devicetree/bindings/net/fsl,lynx-pcs.yaml | 47 +++++++++++++++++++ >>>> 1 file changed, 47 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml b/Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml >>>> new file mode 100644 >>>> index 000000000000..49dee66ab679 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml >>> >>> Shouldn't this be under net/pcs? >> >> There's no net/pcs, since this is the first of its kind. > > There is, coming via Renesas tree. Ah, I will move this then. --Sean
diff --git a/Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml b/Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml new file mode 100644 index 000000000000..49dee66ab679 --- /dev/null +++ b/Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/fsl,lynx-pcs.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP Lynx 10g/28g PCS + +maintainers: + - Ioana Ciornei <ioana.ciornei@nxp.com> + +description: | + Lynx SerDes devices may contain several Ethernet protocol controllers. These + controllers convert between (X)GMII and a variety of high-speed interfaces + (SGMII, 10GBase-R, QSGMII, etc). Unlike the SerDes itself, the PCSs are + accessed over an internal MDIO bus. + +properties: + compatible: + const: fsl,lynx-pcs + + reg: + maxItems: 1 + + phys: + description: A reference to the SerDes lane(s) + maxItems: 1 + + phy-names: + const: serdes + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + mdio-bus { + #address-cells = <1>; + #size-cells = <0>; + ethernet-pcs@1 { + compatible = "fsl,lynx-pcs"; + reg = <0x1>; + }; + };
This adds bindings for the PCS half of the Lynx 10g/28g SerDes drivers. Signed-off-by: Sean Anderson <sean.anderson@seco.com> --- .../devicetree/bindings/net/fsl,lynx-pcs.yaml | 47 +++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/fsl,lynx-pcs.yaml