diff mbox series

[4/6] media: dt-bindings: media: ov9282: Add power supply properties

Message ID 20220711081639.150153-5-alexander.stein@ew.tq-group.com
State Not Applicable, archived
Headers show
Series OV9281 support | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Alexander Stein July 11, 2022, 8:16 a.m. UTC
Add regulators for each power domain.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 .../devicetree/bindings/media/i2c/ovti,ov9282.yaml       | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Krzysztof Kozlowski July 11, 2022, 9:17 a.m. UTC | #1
On 11/07/2022 10:16, Alexander Stein wrote:
> Add regulators for each power domain.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  .../devicetree/bindings/media/i2c/ovti,ov9282.yaml       | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
> index 285f8c85f253..9abfaabd373a 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
> @@ -39,6 +39,15 @@ properties:
>      description: Reference to the GPIO connected to the XCLR pin, if any.
>      maxItems: 1
>  
> +  avdd-supply:
> +    description: Analog power supply
> +
> +  dovdd-supply:
> +    description: Digital I/O power supply
> +
> +  dvdd-supply:
> +    description: Digital core supply
> +

Are all these valid for both variants/devices?


Best regards,
Krzysztof
Alexander Stein July 11, 2022, 11:45 a.m. UTC | #2
Hello Krzysztof,

Am Montag, 11. Juli 2022, 11:17:41 CEST schrieb Krzysztof Kozlowski:
> On 11/07/2022 10:16, Alexander Stein wrote:
> > Add regulators for each power domain.
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > 
> >  .../devicetree/bindings/media/i2c/ovti,ov9282.yaml       | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
> > b/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml index
> > 285f8c85f253..9abfaabd373a 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
> > 
> > @@ -39,6 +39,15 @@ properties:
> >      description: Reference to the GPIO connected to the XCLR pin, if any.
> >      maxItems: 1
> > 
> > +  avdd-supply:
> > +    description: Analog power supply
> > +
> > +  dovdd-supply:
> > +    description: Digital I/O power supply
> > +
> > +  dvdd-supply:
> > +    description: Digital core supply
> > +
> 
> Are all these valid for both variants/devices?

I cannot say for sure due to lack of datasheet, but given that other model 
bindings like ov8865 [1] or ov5640 [2] have the same regulators, I think it is 
safe to assume these are valid for ov9281 and ov9282 as well.

Best regards,
Alexander

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/
Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml#n29
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/
Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml
Krzysztof Kozlowski July 11, 2022, 12:02 p.m. UTC | #3
On 11/07/2022 10:16, Alexander Stein wrote:
> Add regulators for each power domain.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
index 285f8c85f253..9abfaabd373a 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
@@ -39,6 +39,15 @@  properties:
     description: Reference to the GPIO connected to the XCLR pin, if any.
     maxItems: 1
 
+  avdd-supply:
+    description: Analog power supply
+
+  dovdd-supply:
+    description: Digital I/O power supply
+
+  dvdd-supply:
+    description: Digital core supply
+
   port:
     additionalProperties: false
     $ref: /schemas/graph.yaml#/$defs/port-base