| Message ID | 20220630123445.v24.2.Ie2bbbd3f690826404b8f1059d24edcab33ed898f@changeid |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | usb: misc: Add onboard_usb_hub driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Hi, On Thu, Jun 30, 2022 at 12:35 PM Matthias Kaehlcke <mka@chromium.org> wrote: > > In the context of USB the term 'companion-hub' is misleading, change the > name of the property to 'peer-hub'. > > There are no upstream users of the 'companion-hub' property, neither in > the device tree, nor on the driver side, so renaming it shouldn't cause > any compatibility issues with existing device trees. > > Changes in v24: > - patch added to the series > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- > > (no changes since v1) > > .../devicetree/bindings/usb/realtek,rts5411.yaml | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Matches what Alan said... Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Thu, 30 Jun 2022 12:35:28 -0700, Matthias Kaehlcke wrote: > In the context of USB the term 'companion-hub' is misleading, change the > name of the property to 'peer-hub'. > > There are no upstream users of the 'companion-hub' property, neither in > the device tree, nor on the driver side, so renaming it shouldn't cause > any compatibility issues with existing device trees. > > Changes in v24: > - patch added to the series > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- > > (no changes since v1) > > .../devicetree/bindings/usb/realtek,rts5411.yaml | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml b/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml index 04ee255eb4f0..50f2b505bdeb 100644 --- a/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml +++ b/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml @@ -25,13 +25,13 @@ properties: description: phandle to the regulator that provides power to the hub. - companion-hub: + peer-hub: $ref: '/schemas/types.yaml#/definitions/phandle' description: - phandle to the companion hub on the controller. + phandle to the peer hub on the controller. required: - - companion-hub + - peer-hub - compatible - reg @@ -49,7 +49,7 @@ examples: compatible = "usbbda,5411"; reg = <1>; vdd-supply = <&pp3300_hub>; - companion-hub = <&hub_3_0>; + peer-hub = <&hub_3_0>; }; /* 3.0 hub on port 2 */ @@ -57,6 +57,6 @@ examples: compatible = "usbbda,411"; reg = <2>; vdd-supply = <&pp3300_hub>; - companion-hub = <&hub_2_0>; + peer-hub = <&hub_2_0>; }; };
In the context of USB the term 'companion-hub' is misleading, change the name of the property to 'peer-hub'. There are no upstream users of the 'companion-hub' property, neither in the device tree, nor on the driver side, so renaming it shouldn't cause any compatibility issues with existing device trees. Changes in v24: - patch added to the series Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- (no changes since v1) .../devicetree/bindings/usb/realtek,rts5411.yaml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)