diff mbox series

[1/7] dt-bindings: vendor-prefixes: document several vendors for Aspeed BMC boards

Message ID 20220529104928.79636-1-krzysztof.kozlowski@linaro.org
State Accepted, archived
Headers show
Series [1/7] dt-bindings: vendor-prefixes: document several vendors for Aspeed BMC boards | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Krzysztof Kozlowski May 29, 2022, 10:49 a.m. UTC
Add vendor prefixes for manufacturers of Aspeed SoC based BMC boards:
ASrock, ByteDance, Ingrasys, Inventec and Quanta.  Move also bticino to
proper alphabetical place.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/vendor-prefixes.yaml     | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski June 9, 2022, 8:50 a.m. UTC | #1
On 29/05/2022 12:49, Krzysztof Kozlowski wrote:
> Add vendor prefixes for manufacturers of Aspeed SoC based BMC boards:
> ASrock, ByteDance, Ingrasys, Inventec and Quanta.  Move also bticino to
> proper alphabetical place.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Joel, Andrew,

Any comments on this patchset? Are you going to pick it up? If you
prefer me taking it, I can, but new boards depend on the bindings, so
this should rather go via your tree.

Best regards,
Krzysztof
Rob Herring June 9, 2022, 8:43 p.m. UTC | #2
On Sun, 29 May 2022 12:49:22 +0200, Krzysztof Kozlowski wrote:
> Add vendor prefixes for manufacturers of Aspeed SoC based BMC boards:
> ASrock, ByteDance, Ingrasys, Inventec and Quanta.  Move also bticino to
> proper alphabetical place.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/vendor-prefixes.yaml     | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)
> 

Applying this one to avoid any conflicts.

Rob
Krzysztof Kozlowski June 22, 2022, 10:17 a.m. UTC | #3
On Sun, 29 May 2022 12:49:25 +0200, Krzysztof Kozlowski wrote:
> The AST2500 EVB board should have dedicated compatible.
> 
> 

Applied, thanks!

[4/7] ARM: dts: ast2500-evb: fix board compatible
      https://git.kernel.org/krzk/linux/c/30b276fca5c0644f3cb17bceb1bd6a626c670184

Best regards,
Krzysztof Kozlowski June 22, 2022, 10:17 a.m. UTC | #4
On Sun, 29 May 2022 12:49:26 +0200, Krzysztof Kozlowski wrote:
> The AST2600 EVB board should have dedicated compatible.
> 
> 

Applied, thanks!

[5/7] ARM: dts: ast2600-evb: fix board compatible
      https://git.kernel.org/krzk/linux/c/aa5e06208500a0db41473caebdee5a2e81d5a277

Best regards,
Krzysztof Kozlowski June 22, 2022, 10:17 a.m. UTC | #5
On Sun, 29 May 2022 12:49:27 +0200, Krzysztof Kozlowski wrote:
> The AST2600 EVB A1 board should have dedicated compatible.
> 
> 

Applied, thanks!

[6/7] ARM: dts: ast2600-evb-a1: fix board compatible
      https://git.kernel.org/krzk/linux/c/33c39140cc298e0d4e36083cb9a665a837773a60

Best regards,
Krzysztof Kozlowski June 22, 2022, 10:17 a.m. UTC | #6
On Sun, 29 May 2022 12:49:28 +0200, Krzysztof Kozlowski wrote:
> "qualcomm" is not a documented compatible and instead "qcom" should be
> used.
> 
> 

Applied, thanks!

[7/7] ARM: dts: aspeed: centriq2400: use qcom compatible
      https://git.kernel.org/krzk/linux/c/6202c6063145cf9ec22b40aac219122dd702a10f

Best regards,
Joel Stanley June 23, 2022, 5:34 a.m. UTC | #7
On Wed, 22 Jun 2022 at 10:17, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On Sun, 29 May 2022 12:49:28 +0200, Krzysztof Kozlowski wrote:
> > "qualcomm" is not a documented compatible and instead "qcom" should be
> > used.
> >
> >
>
> Applied, thanks!

What tree did you apply this to? Did you get review from the maintainer?

This board is unmaintained and unused. I would prefer it removed
rather than meaningless fixes be applied.

>
> [7/7] ARM: dts: aspeed: centriq2400: use qcom compatible
>       https://git.kernel.org/krzk/linux/c/6202c6063145cf9ec22b40aac219122dd702a10f
>
> Best regards,
> --
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Krzysztof Kozlowski June 23, 2022, 7:05 a.m. UTC | #8
On 23/06/2022 07:34, Joel Stanley wrote:
> On Wed, 22 Jun 2022 at 10:17, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On Sun, 29 May 2022 12:49:28 +0200, Krzysztof Kozlowski wrote:
>>> "qualcomm" is not a documented compatible and instead "qcom" should be
>>> used.
>>>
>>>
>>
>> Applied, thanks!
> 
> What tree did you apply this to? Did you get review from the maintainer?

Tree was mentioned below.

> 
> This board is unmaintained and unused. I would prefer it removed
> rather than meaningless fixes be applied.

I can drop the patch. I'll send the patch to remove the board.

> 
>>
>> [7/7] ARM: dts: aspeed: centriq2400: use qcom compatible
>>       https://git.kernel.org/krzk/linux/c/6202c6063145cf9ec22b40aac219122dd702a10f
>>
>> Best regards,
>> --
>> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
Krzysztof Kozlowski June 24, 2022, 7:12 a.m. UTC | #9
On 23/06/2022 09:05, Krzysztof Kozlowski wrote:
> On 23/06/2022 07:34, Joel Stanley wrote:
>> On Wed, 22 Jun 2022 at 10:17, Krzysztof Kozlowski
>> <krzysztof.kozlowski@linaro.org> wrote:
>>>
>>> On Sun, 29 May 2022 12:49:28 +0200, Krzysztof Kozlowski wrote:
>>>> "qualcomm" is not a documented compatible and instead "qcom" should be
>>>> used.
>>>>
>>>>
>>>
>>> Applied, thanks!
>>
>> What tree did you apply this to? Did you get review from the maintainer?
> 
> Tree was mentioned below.
> 
>>
>> This board is unmaintained and unused. I would prefer it removed
>> rather than meaningless fixes be applied.
> 
> I can drop the patch. I'll send the patch to remove the board.

Does your answer also means that you are planning to take these? I am
going to prepare a pull request to arm-soc so need to know whether to
keep these or not. I don't have any particular need of handling these
patches by myself, but I want the issues to get fixed.

Best regards,
Krzysztof
Andrew Jeffery July 21, 2022, 2:34 a.m. UTC | #10
On Thu, 9 Jun 2022, at 18:20, Krzysztof Kozlowski wrote:
> On 29/05/2022 12:49, Krzysztof Kozlowski wrote:
>> Add vendor prefixes for manufacturers of Aspeed SoC based BMC boards:
>> ASrock, ByteDance, Ingrasys, Inventec and Quanta.  Move also bticino to
>> proper alphabetical place.
>> 
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>
> Joel, Andrew,
>
> Any comments on this patchset? Are you going to pick it up? If you
> prefer me taking it, I can, but new boards depend on the bindings, so
> this should rather go via your tree.

Apologies for not getting to this earlier, but I see Rob's applied it.

Andrew
Krzysztof Kozlowski July 21, 2022, 6:30 a.m. UTC | #11
On 21/07/2022 04:34, Andrew Jeffery wrote:
>> Any comments on this patchset? Are you going to pick it up? If you
>> prefer me taking it, I can, but new boards depend on the bindings, so
>> this should rather go via your tree.
> 
> Apologies for not getting to this earlier, but I see Rob's applied it.

Rob took only the first patch - vendor-prefix. The DTS patches I sent to
arm-soc.

However the second bindings patch [1] will miss merge window as I did
not send it to arm-soc. I have it in my tree but I am not planning to
push it out before merge window.

[1]
https://lore.kernel.org/all/165589284658.28441.1588047978357747292.b4-ty@linaro.org/


Best regards,
Krzysztof
Krzysztof Kozlowski July 21, 2022, 7:25 a.m. UTC | #12
On 21/07/2022 08:30, Krzysztof Kozlowski wrote:
> On 21/07/2022 04:34, Andrew Jeffery wrote:
>>> Any comments on this patchset? Are you going to pick it up? If you
>>> prefer me taking it, I can, but new boards depend on the bindings, so
>>> this should rather go via your tree.
>>
>> Apologies for not getting to this earlier, but I see Rob's applied it.
> 
> Rob took only the first patch - vendor-prefix. The DTS patches I sent to
> arm-soc.
> 
> However the second bindings patch [1] will miss merge window as I did
> not send it to arm-soc. I have it in my tree but I am not planning to
> push it out before merge window.
> 

I sent pull with the bindings now.

Best regards,
Krzysztof
Andrew Jeffery July 22, 2022, 2:43 a.m. UTC | #13
On Sun, 29 May 2022, at 20:19, Krzysztof Kozlowski wrote:
> The AST2500 EVB board should have dedicated compatible.
>
> Fixes: 02440622656d ("arm/dst: Add Aspeed ast2500 device tree")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Andrew Jeffery July 22, 2022, 2:44 a.m. UTC | #14
On Sun, 29 May 2022, at 20:19, Krzysztof Kozlowski wrote:
> "qualcomm" is not a documented compatible and instead "qcom" should be
> used.
>
> Fixes: 3719a1b13056 ("ARM: dts: aspeed: Add Qualcomm Centriq 2400 REP BMC")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Andrew Jeffery <andrew@aj.id.au>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 495a01ced97e..169f11ce4cc5 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -141,6 +141,8 @@  patternProperties:
     description: ASIX Electronics Corporation
   "^aspeed,.*":
     description: ASPEED Technology Inc.
+  "^asrock,.*":
+    description: ASRock Inc.
   "^asus,.*":
     description: AsusTek Computer Inc.
   "^atlas,.*":
@@ -195,12 +197,14 @@  patternProperties:
     description: Broadcom Corporation
   "^bsh,.*":
     description: BSH Hausgeraete GmbH
+  "^bticino,.*":
+    description: Bticino International
   "^buffalo,.*":
     description: Buffalo, Inc.
   "^bur,.*":
     description: B&R Industrial Automation GmbH
-  "^bticino,.*":
-    description: Bticino International
+  "^bytedance,.*":
+    description: ByteDance Ltd.
   "^calamp,.*":
     description: CalAmp Corp.
   "^calaosystems,.*":
@@ -544,6 +548,8 @@  patternProperties:
     description: Shenzhen Hugsun Technology Co. Ltd.
   "^hwacom,.*":
     description: HwaCom Systems Inc.
+  "^hxt,.*":
+    description: HXT Semiconductor
   "^hycon,.*":
     description: Hycon Technology Corp.
   "^hydis,.*":
@@ -578,6 +584,8 @@  patternProperties:
     description: Infineon Technologies
   "^inforce,.*":
     description: Inforce Computing
+  "^ingrasys,.*":
+    description: Ingrasys Technology Inc.
   "^ivo,.*":
     description: InfoVision Optoelectronics Kunshan Co. Ltd.
   "^ingenic,.*":
@@ -598,6 +606,8 @@  patternProperties:
     description: Inter Control Group
   "^invensense,.*":
     description: InvenSense Inc.
+  "^inventec,.*":
+    description: Inventec
   "^inversepath,.*":
     description: Inverse Path
   "^iom,.*":
@@ -1010,6 +1020,8 @@  patternProperties:
     description: Shenzhen QiShenglong Industrialist Co., Ltd.
   "^qnap,.*":
     description: QNAP Systems, Inc.
+  "^quanta,.*":
+    description: Quanta Computer Inc.
   "^radxa,.*":
     description: Radxa
   "^raidsonic,.*":