| Message ID | 20220521200734.421223-1-a.fatoum@pengutronix.de |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 7 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 21/05/2022 22:07, Ahmad Fatoum wrote: > The BCM4349B1 chip is a single-chip Bluetooth 5.0 controller and > Transceiver. It is contained in the CYW/BCM89359 WiFi+BT package. > Extend the binding with its DT compatible. > > Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Sat, May 21, 2022 at 10:07 PM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote: > The BCM4349B1 chip is a single-chip Bluetooth 5.0 controller and > Transceiver. It is contained in the CYW/BCM89359 WiFi+BT package. So the BT and the package have two different names. > + - brcm,bcm4349-bt Then why do you have to tag on "-bt" on this compatible? That is typically used when the wifi and bt has the *same* name, so the only way to distinguish between them is a suffix. Yours, Linus Walleij
On 22.05.22 23:03, Linus Walleij wrote: > On Sat, May 21, 2022 at 10:07 PM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote: > >> The BCM4349B1 chip is a single-chip Bluetooth 5.0 controller and >> Transceiver. It is contained in the CYW/BCM89359 WiFi+BT package. > > So the BT and the package have two different names. The package also goes by the name BCM4349B1 apparently. Cypress support had later confirmed BCM4349B1 and BCM89359 to be the same chipset. I should probably rephrase the commit message. >> + - brcm,bcm4349-bt > > Then why do you have to tag on "-bt" on this compatible? > > That is typically used when the wifi and bt has the *same* name, so > the only way to distinguish between them is a suffix. I think that's the case here too. Cheers, Ahmad > > Yours, > Linus Walleij >
On Mon, May 23, 2022 at 12:16 AM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote: > On 22.05.22 23:03, Linus Walleij wrote: > > On Sat, May 21, 2022 at 10:07 PM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote: > > > >> The BCM4349B1 chip is a single-chip Bluetooth 5.0 controller and > >> Transceiver. It is contained in the CYW/BCM89359 WiFi+BT package. > > > > So the BT and the package have two different names. > > The package also goes by the name BCM4349B1 apparently. > Cypress support had later confirmed BCM4349B1 and BCM89359 to > be the same chipset. I should probably rephrase the commit message. > > > >> + - brcm,bcm4349-bt > > > > Then why do you have to tag on "-bt" on this compatible? > > > > That is typically used when the wifi and bt has the *same* name, so > > the only way to distinguish between them is a suffix. > I think that's the case here too. OK then! Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml index 5aac094fd217..58ecafc1b7f9 100644 --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml @@ -23,6 +23,7 @@ properties: - brcm,bcm4345c5 - brcm,bcm43540-bt - brcm,bcm4335a0 + - brcm,bcm4349-bt shutdown-gpios: maxItems: 1
The BCM4349B1 chip is a single-chip Bluetooth 5.0 controller and Transceiver. It is contained in the CYW/BCM89359 WiFi+BT package. Extend the binding with its DT compatible. Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> --- To: Marcel Holtmann <marcel@holtmann.org> To: Johan Hedberg <johan.hedberg@gmail.com> To: Luiz Augusto von Dentz <luiz.dentz@gmail.com> To: Rob Herring <robh+dt@kernel.org> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: linux-kernel@vger.kernel.org Cc: linux-bluetooth@vger.kernel.org Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: linux-kernel@vger.kernel.org To: devicetree@vger.kernel.org Cc: netdev@vger.kernel.org --- Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml | 1 + 1 file changed, 1 insertion(+)