| Message ID | 20220521152049.1490220-12-dmitry.baryshkov@linaro.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | arm64: dts: qcom: initial Inforce IFC6560 board support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 2022-05-21 18:20:49, Dmitry Baryshkov wrote: > Add binding documentation for the Inforce IFC6560 board which uses > Snapdragon SDA660. > > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Nit: don't dt-bindings patches go _before_ using these in dts? In ohter words, should patch 10 and 11 be swapped? > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 129cdd246223..ac4ee0f874ea 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -41,6 +41,7 @@ description: | > sa8155p > sc7180 > sc7280 > + sda660 > sdm630 > sdm632 > sdm660 > @@ -225,6 +226,11 @@ properties: > - google,senor > - const: qcom,sc7280 > > + - items: > + - enum: > + - inforce,ifc6560 > + - const: qcom,sda660 > + > - items: > - enum: > - fairphone,fp3 > -- > 2.35.1 >
On 21/05/2022 18:20, Marijn Suijten wrote: > On 2022-05-21 18:20:49, Dmitry Baryshkov wrote: >> Add binding documentation for the Inforce IFC6560 board which uses >> Snapdragon SDA660. >> >> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Nit: don't dt-bindings patches go _before_ using these in dts? In ohter > words, should patch 10 and 11 be swapped? Yes, they should. Best regards, Krzysztof
On 21/05/2022 17:20, Dmitry Baryshkov wrote: > Add binding documentation for the Inforce IFC6560 board which uses > Snapdragon SDA660. > > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 129cdd246223..ac4ee0f874ea 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -41,6 +41,7 @@ description: | > sa8155p > sc7180 > sc7280 > + sda660 I wanted to base my work on top of it, but this patch does not apply. I think you based it on something out of date, also judging by my old email address you are using (in each patchset). The patches should be based on current development tree. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 129cdd246223..ac4ee0f874ea 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -41,6 +41,7 @@ description: | sa8155p sc7180 sc7280 + sda660 sdm630 sdm632 sdm660 @@ -225,6 +226,11 @@ properties: - google,senor - const: qcom,sc7280 + - items: + - enum: + - inforce,ifc6560 + - const: qcom,sda660 + - items: - enum: - fairphone,fp3