| Message ID | 20220510141753.3878390-7-Qing-wu.Li@leica-geosystems.com.cn |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | iio: accel: bmi088: support BMI085 BMI090L | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Tue, May 10, 2022 at 5:18 PM LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn> wrote: > > Adds the device-tree bindings for the Bosch > BMI085 and BMI090L IMU, the accelerometer part. > I think some datasheet links could be added to this file for the new devices. The BMI088 has a link to its datasheet. > Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn> > --- > Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml > index 911a1ae9c83f..4290f5f88a8f 100644 > --- a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml > +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml > @@ -18,6 +18,8 @@ properties: > compatible: > enum: > - bosch,bmi088-accel > + - bosch,bmi085-accel > + - bosch,bmi090l-accel > > reg: > maxItems: 1 > -- > 2.25.1 >
On Thu, 12 May 2022 10:32:55 +0300 Alexandru Ardelean <ardeleanalex@gmail.com> wrote: > On Tue, May 10, 2022 at 5:18 PM LI Qingwu > <Qing-wu.Li@leica-geosystems.com.cn> wrote: > > > > Adds the device-tree bindings for the Bosch > > BMI085 and BMI090L IMU, the accelerometer part. > > > > I think some datasheet links could be added to this file for the new devices. > > The BMI088 has a link to its datasheet. > > > Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn> > > --- > > Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml > > index 911a1ae9c83f..4290f5f88a8f 100644 > > --- a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml > > +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml > > @@ -18,6 +18,8 @@ properties: > > compatible: > > enum: > > - bosch,bmi088-accel > > + - bosch,bmi085-accel > > + - bosch,bmi090l-accel Alphabetical /numeric order preferred. Also, fun question of compatible fallbacks as per the previous email. Other than ID you state the bmi080l has same scales etc as the bmi088 so that one should definitely have a fallback to bmi088. The bmi085 is a little less obvious. We can detect the difference by the chip id though so a fallback compatible probably makes sense for that one as well. DT maintainers - I'll go with whatever you recommend on that front. Also, driver doesn't currently have an of_id_table so relies on the fallback handling of the spi core. Please add an explicit table to the driver. Thanks, Jonathan > > > > reg: > > maxItems: 1 > > -- > > 2.25.1 > >
diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml index 911a1ae9c83f..4290f5f88a8f 100644 --- a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml @@ -18,6 +18,8 @@ properties: compatible: enum: - bosch,bmi088-accel + - bosch,bmi085-accel + - bosch,bmi090l-accel reg: maxItems: 1
Adds the device-tree bindings for the Bosch BMI085 and BMI090L IMU, the accelerometer part. Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn> --- Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml | 2 ++ 1 file changed, 2 insertions(+)