| Message ID | 20220402143636.15222-16-jbx6244@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Convert Rockchip clk | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | success | |
| robh/dt-meta-schema | success |
On 02/04/2022 16:36, Johan Jonker wrote: > The node names should be generic, so fix this for the pmucru node example > in the rockchip,rk3399-cru.yaml file and rename it to "clock-controller". > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > .../devicetree/bindings/clock/rockchip,rk3399-cru.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > You received here the tag, there were no changes in the patch, yet you ignored it. This raises my concern that for all other patches you also ignored my tags. Please resend with collecting appropriate tags from all reviewers. For places you discard the tag, please mention it in each patch changelog (under ---). Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml b/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml index 5ee686938..e91147c84 100644 --- a/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml +++ b/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml @@ -77,7 +77,7 @@ additionalProperties: false examples: - | - pmucru: pmu-clock-controller@ff750000 { + pmucru: clock-controller@ff750000 { compatible = "rockchip,rk3399-pmucru"; reg = <0xff750000 0x1000>; #clock-cells = <1>;
The node names should be generic, so fix this for the pmucru node example in the rockchip,rk3399-cru.yaml file and rename it to "clock-controller". Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- .../devicetree/bindings/clock/rockchip,rk3399-cru.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)