| Message ID | 20220318162044.169350-1-krzysztof.kozlowski@canonical.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [1/2] dt-bindings: dmaengine: sifive,fu540-c000: include generic schema | expand |
| Context | Check | Description |
|---|---|---|
| robh/patch-applied | success | |
| robh/checkpatch | success | |
| robh/dtbs-check | success | |
| robh/dt-meta-schema | success |
On Fri, 18 Mar 2022 17:20:43 +0100, Krzysztof Kozlowski wrote: > Include generic dma-controller.yaml schema, which enforces node naming > and other generic properties. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > .../devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > Applied, thanks!
On 18/03/2022 17:20, Krzysztof Kozlowski wrote: > Fixes dtbs_check warnings like: > > dma@3000000: $nodename:0: 'dma@3000000' does not match '^dma-controller(@.*)?$' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Any comments here? Best regards, Krzysztof
On 19/04/2022 10:09, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 18/03/2022 17:20, Krzysztof Kozlowski wrote: >> Fixes dtbs_check warnings like: >> >> dma@3000000: $nodename:0: 'dma@3000000' does not match '^dma-controller(@.*)?$' >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >> --- >> arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Any comments here? Not sure that this one is actually needed Krzysztof, Zong Li has a fix for this in his series of fixes for the sifive pdma: https://lore.kernel.org/linux-riscv/edd72c0cca1ebceddc032ff6ec2284e3f48c5ad3.1648461096.git.zong.li@sifive.com/ Maybe you could add your review to his version?
On 19/04/2022 12:45, Conor.Dooley@microchip.com wrote: > On 19/04/2022 10:09, Krzysztof Kozlowski wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 18/03/2022 17:20, Krzysztof Kozlowski wrote: >>> Fixes dtbs_check warnings like: >>> >>> dma@3000000: $nodename:0: 'dma@3000000' does not match '^dma-controller(@.*)?$' >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >>> --- >>> arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Any comments here? > > Not sure that this one is actually needed Krzysztof, Zong Li has a fix > for this in his series of fixes for the sifive pdma: > https://lore.kernel.org/linux-riscv/edd72c0cca1ebceddc032ff6ec2284e3f48c5ad3.1648461096.git.zong.li@sifive.com/ > > Maybe you could add your review to his version? Zong's Li patch was sent 10 days after my patch... [1] Why riscv DTS patches take so much time to pick up? [1] https://lore.kernel.org/linux-devicetree/20220318162044.169350-2-krzysztof.kozlowski@canonical.com/ Best regards, Krzysztof
On 19/04/2022 10:50, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 19/04/2022 12:45, Conor.Dooley@microchip.com wrote: >> On 19/04/2022 10:09, Krzysztof Kozlowski wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>> >>> On 18/03/2022 17:20, Krzysztof Kozlowski wrote: >>>> Fixes dtbs_check warnings like: >>>> >>>> dma@3000000: $nodename:0: 'dma@3000000' does not match '^dma-controller(@.*)?$' >>>> >>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >>>> --- >>>> arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> Any comments here? >> >> Not sure that this one is actually needed Krzysztof, Zong Li has a fix >> for this in his series of fixes for the sifive pdma: >> https://lore.kernel.org/linux-riscv/edd72c0cca1ebceddc032ff6ec2284e3f48c5ad3.1648461096.git.zong.li@sifive.com/ >> >> Maybe you could add your review to his version? > > Zong's Li patch was sent 10 days after my patch... [1] Why riscv DTS > patches take so much time to pick up? > Oh, my bad. I incorrectly assumed that that patch was present before v8, I should've checked further back - sorry!
On 19/04/2022 12:57, Conor.Dooley@microchip.com wrote: >>> Not sure that this one is actually needed Krzysztof, Zong Li has a fix >>> for this in his series of fixes for the sifive pdma: >>> https://lore.kernel.org/linux-riscv/edd72c0cca1ebceddc032ff6ec2284e3f48c5ad3.1648461096.git.zong.li@sifive.com/ >>> >>> Maybe you could add your review to his version? >> >> Zong's Li patch was sent 10 days after my patch... [1] Why riscv DTS >> patches take so much time to pick up? >> > > Oh, my bad. I incorrectly assumed that that patch was present before v8, > I should've checked further back - sorry! No problem :) I don't mind Zong's patch to be taken although in general I believe more in FIFO (or FIF Served) style. Best regards, Krzysztof
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2022年4月19日 週二 下午6:59寫道： > > On 19/04/2022 12:57, Conor.Dooley@microchip.com wrote: > >>> Not sure that this one is actually needed Krzysztof, Zong Li has a fix > >>> for this in his series of fixes for the sifive pdma: > >>> https://lore.kernel.org/linux-riscv/edd72c0cca1ebceddc032ff6ec2284e3f48c5ad3.1648461096.git.zong.li@sifive.com/ > >>> > >>> Maybe you could add your review to his version? > >> > >> Zong's Li patch was sent 10 days after my patch... [1] Why riscv DTS > >> patches take so much time to pick up? > >> > > > > Oh, my bad. I incorrectly assumed that that patch was present before v8, > > I should've checked further back - sorry! > > No problem :) > > I don't mind Zong's patch to be taken although in general I believe more > in FIFO (or FIF Served) style. > Hi all, Thanks Conor brings me here. The patch 1 and 4 in my series has been applied into dmaengine/next, but patch 2 and 3 should go by riscv tree, so I guess that I could re-send the patch 2 based on top of Krzysztof's patch, then let's drop the patch 2 & 3 of another patchset. I will keep follow up here. Thanks all. > Best regards, > Krzysztof > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
diff --git a/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml b/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml index 75ad898c59bc..47c46af25536 100644 --- a/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml +++ b/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml @@ -22,6 +22,9 @@ description: | https://static.dev.sifive.com/FU540-C000-v1.0.pdf +allOf: + - $ref: "dma-controller.yaml#" + properties: compatible: items: @@ -41,13 +44,12 @@ required: - compatible - reg - interrupts - - '#dma-cells' -additionalProperties: false +unevaluatedProperties: false examples: - | - dma@3000000 { + dma-controller@3000000 { compatible = "sifive,fu540-c000-pdma"; reg = <0x3000000 0x8000>; interrupts = <23>, <24>, <25>, <26>, <27>, <28>, <29>, <30>;
Include generic dma-controller.yaml schema, which enforces node naming and other generic properties. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- .../devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)