| Message ID | 20220223023157.3478540-3-peng.fan@oss.nxp.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | mailbox: imx: support i.MX93 | expand |
On Wed, Feb 23, 2022 at 10:31:54AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > Similar to i.MX8ULP S4 MU, i.MX93 MU is dedicated for communication > between Sentinel and Cortex-A cores from hardware design, it could not be > reused for other purpose. > > However i.MX93 S4 MU use separate tx/rx interrupt, so update > interrupts and add interrupt-names property. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > .../devicetree/bindings/mailbox/fsl,mu.yaml | 27 ++++++++++++++++++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml > index 6d056d5e16bf..f5f9d501845d 100644 > --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml > +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml > @@ -29,6 +29,7 @@ properties: > - const: fsl,imx8ulp-mu > - const: fsl,imx8-mu-scu > - const: fsl,imx8-mu-seco > + - const: fsl,imx93-mu-s4 > - const: fsl,imx8ulp-mu-s4 > - items: > - const: fsl,imx93-mu > @@ -55,7 +56,13 @@ properties: > maxItems: 1 > > interrupts: > - maxItems: 1 > + minItems: 1 I still don't think you tested this with 2 items. You need minItems and maxItems. > + > + interrupt-names: > + minItems: 1 > + items: > + - const: tx > + - const: rx > > "#mbox-cells": > description: | > @@ -90,6 +97,24 @@ required: > - interrupts > - "#mbox-cells" > > +allOf: > + - if: > + properties: > + compatible: > + enum: > + - fsl,imx93-mu-s4 > + then: > + properties: > + interrupt-names: > + minItems: 2 > + interrupts: > + maxItems: 2 s/maxItems/minItems/ > + > + else: > + properties: > + interrupts: > + maxItems: 1 > + > additionalProperties: false > > examples: > -- > 2.25.1 > >
> Subject: Re: [PATCH V4 2/5] dt-bindings: mailbox: imx-mu: add i.MX93 S4 MU > support > > On Wed, Feb 23, 2022 at 10:31:54AM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan <peng.fan@nxp.com> > > > > Similar to i.MX8ULP S4 MU, i.MX93 MU is dedicated for communication > > between Sentinel and Cortex-A cores from hardware design, it could not > > be reused for other purpose. > > > > However i.MX93 S4 MU use separate tx/rx interrupt, so update > > interrupts and add interrupt-names property. > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > .../devicetree/bindings/mailbox/fsl,mu.yaml | 27 > ++++++++++++++++++- > > 1 file changed, 26 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml > > b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml > > index 6d056d5e16bf..f5f9d501845d 100644 > > --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml > > +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml > > @@ -29,6 +29,7 @@ properties: > > - const: fsl,imx8ulp-mu > > - const: fsl,imx8-mu-scu > > - const: fsl,imx8-mu-seco > > + - const: fsl,imx93-mu-s4 > > - const: fsl,imx8ulp-mu-s4 > > - items: > > - const: fsl,imx93-mu > > @@ -55,7 +56,13 @@ properties: > > maxItems: 1 > > > > interrupts: > > - maxItems: 1 > > + minItems: 1 > > I still don't think you tested this with 2 items. You need minItems and > maxItems. dt_binding check and dtbs_check both pass two interrupts entry. So here it should be? interrupts: minItems: 1 maxItems: 2 > > > + > > + interrupt-names: > > + minItems: 1 > > + items: > > + - const: tx > > + - const: rx > > > > "#mbox-cells": > > description: | > > @@ -90,6 +97,24 @@ required: > > - interrupts > > - "#mbox-cells" > > > > +allOf: > > + - if: > > + properties: > > + compatible: > > + enum: > > + - fsl,imx93-mu-s4 > > + then: > > + properties: > > + interrupt-names: > > + minItems: 2 > > + interrupts: > > + maxItems: 2 > > s/maxItems/minItems/ Fix in V5. Thanks, Peng. > > > + > > + else: > > + properties: > > + interrupts: > > + maxItems: 1 > > + > > additionalProperties: false > > > > examples: > > -- > > 2.25.1 > > > >
diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml index 6d056d5e16bf..f5f9d501845d 100644 --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml @@ -29,6 +29,7 @@ properties: - const: fsl,imx8ulp-mu - const: fsl,imx8-mu-scu - const: fsl,imx8-mu-seco + - const: fsl,imx93-mu-s4 - const: fsl,imx8ulp-mu-s4 - items: - const: fsl,imx93-mu @@ -55,7 +56,13 @@ properties: maxItems: 1 interrupts: - maxItems: 1 + minItems: 1 + + interrupt-names: + minItems: 1 + items: + - const: tx + - const: rx "#mbox-cells": description: | @@ -90,6 +97,24 @@ required: - interrupts - "#mbox-cells" +allOf: + - if: + properties: + compatible: + enum: + - fsl,imx93-mu-s4 + then: + properties: + interrupt-names: + minItems: 2 + interrupts: + maxItems: 2 + + else: + properties: + interrupts: + maxItems: 1 + additionalProperties: false examples: