| Message ID | 20220206184749.11532-2-biju.das.jz@bp.renesas.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [1/3] dt-bindings: serial: renesas,scif: Remove redundant renesas,scif-r9a07g054 | expand |
| Context | Check | Description |
|---|---|---|
| robh/patch-applied | success | |
| robh/checkpatch | success | |
| robh/dtbs-check | success | |
| robh/dt-meta-schema | success |
Hi Biju, On Sun, Feb 6, 2022 at 7:48 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > Add SCIF binding documentation for Renesas RZ/G2UL SoC. SCIF block on > RZ/G2UL is identical to one found on the RZ/G2L SoC. No driver changes > are required as RZ/G2L compatible string "renesas,scif-r9a07g044" will > be used as a fallback. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Thanks for your patch! > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > @@ -76,8 +76,9 @@ properties: > > - items: > - enum: > + - renesas,scif-r9a07g043 # RZ/G2UL > - renesas,scif-r9a07g054 # RZ/V2L > - - const: renesas,scif-r9a07g044 # RZ/G2{L,LC} fallback for RZ/V2L > + - const: renesas,scif-r9a07g044 # RZ/G2{L,LC} fallback for RZ/{G2UL,V2L} To avoid having to update this comment over and over again, perhaps the "for ..." should be dropped? The rest looks good to me. Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH 2/3] dt-bindings: serial: renesas,scif: Document > RZ/G2UL SoC > > Hi Biju, > > On Sun, Feb 6, 2022 at 7:48 PM Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > Add SCIF binding documentation for Renesas RZ/G2UL SoC. SCIF block on > > RZ/G2UL is identical to one found on the RZ/G2L SoC. No driver changes > > are required as RZ/G2L compatible string "renesas,scif-r9a07g044" will > > be used as a fallback. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > @@ -76,8 +76,9 @@ properties: > > > > - items: > > - enum: > > + - renesas,scif-r9a07g043 # RZ/G2UL > > - renesas,scif-r9a07g054 # RZ/V2L > > - - const: renesas,scif-r9a07g044 # RZ/G2{L,LC} fallback for > RZ/V2L > > + - const: renesas,scif-r9a07g044 # RZ/G2{L,LC} fallback for > RZ/{G2UL,V2L} > > To avoid having to update this comment over and over again, perhaps the > "for ..." should be dropped? Agreed, Will drop "for ..." in next version. Regards, Biju > > The rest looks good to me. > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. > But when I'm talking to journalists I just say "programmer" or something > like that. > -- Linus Torvalds
diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml b/Documentation/devicetree/bindings/serial/renesas,scif.yaml index 461392091579..06e857bfd2ff 100644 --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml @@ -76,8 +76,9 @@ properties: - items: - enum: + - renesas,scif-r9a07g043 # RZ/G2UL - renesas,scif-r9a07g054 # RZ/V2L - - const: renesas,scif-r9a07g044 # RZ/G2{L,LC} fallback for RZ/V2L + - const: renesas,scif-r9a07g044 # RZ/G2{L,LC} fallback for RZ/{G2UL,V2L} reg: maxItems: 1
Add SCIF binding documentation for Renesas RZ/G2UL SoC. SCIF block on RZ/G2UL is identical to one found on the RZ/G2L SoC. No driver changes are required as RZ/G2L compatible string "renesas,scif-r9a07g044" will be used as a fallback. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- Documentation/devicetree/bindings/serial/renesas,scif.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)