| Message ID | 20220113111057.29918-3-yong.wu@mediatek.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | MT8186 SMI SUPPORT | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 7 lines checked |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Il 13/01/22 12:10, Yong Wu ha scritto: > Mute the warning from "make dtbs_check": > > larb@14016000: 'mediatek,larb-id' is a required property > arch/arm64/boot/dts/mediatek/mt8167-pumpkin.dt.yaml > larb@15001000: 'mediatek,larb-id' is a required property > arch/arm64/boot/dts/mediatek/mt8167-pumpkin.dt.yaml > larb@16010000: 'mediatek,larb-id' is a required property > arch/arm64/boot/dts/mediatek/mt8167-pumpkin.dt.yaml > > As the description of mediatek,larb-id, the property is only > required when the larbid is not consecutive from its IOMMU point of view. > > Also, from the description of mediatek,larbs in > Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml, all the larbs > must sort by the larb index. > > In mt8167, there is only one IOMMU HW and three larbs. The drivers already > know its larb index from the mediatek,larbs property of IOMMU, thus no > need this property. > > Fixes: 27bb0e42855a ("dt-bindings: memory: mediatek: Convert SMI to DT schema") > Signed-off-by: Yong Wu <yong.wu@mediatek.com> Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml index bd7aa8257949..6d61c51893d2 100644 --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml @@ -106,7 +106,6 @@ allOf: - mediatek,mt2701-smi-larb - mediatek,mt2712-smi-larb - mediatek,mt6779-smi-larb - - mediatek,mt8167-smi-larb - mediatek,mt8192-smi-larb - mediatek,mt8195-smi-larb
Mute the warning from "make dtbs_check": larb@14016000: 'mediatek,larb-id' is a required property arch/arm64/boot/dts/mediatek/mt8167-pumpkin.dt.yaml larb@15001000: 'mediatek,larb-id' is a required property arch/arm64/boot/dts/mediatek/mt8167-pumpkin.dt.yaml larb@16010000: 'mediatek,larb-id' is a required property arch/arm64/boot/dts/mediatek/mt8167-pumpkin.dt.yaml As the description of mediatek,larb-id, the property is only required when the larbid is not consecutive from its IOMMU point of view. Also, from the description of mediatek,larbs in Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml, all the larbs must sort by the larb index. In mt8167, there is only one IOMMU HW and three larbs. The drivers already know its larb index from the mediatek,larbs property of IOMMU, thus no need this property. Fixes: 27bb0e42855a ("dt-bindings: memory: mediatek: Convert SMI to DT schema") Signed-off-by: Yong Wu <yong.wu@mediatek.com> --- .../bindings/memory-controllers/mediatek,smi-larb.yaml | 1 - 1 file changed, 1 deletion(-)