| Message ID | 20211223181741.3999-1-f.fainelli@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: net: dsa: Fix realtek-smi example | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 15 lines checked |
| robh/dtbs-check | success | |
| robh/dt-meta-schema | success |
On Thu, Dec 23, 2021 at 10:17:41AM -0800, Florian Fainelli wrote: > The 'ports' node is not supposed to have a 'reg' property at all, in > fact, doing so will lead to dtc issuing warnings looking like these: > > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:109.4-14: Warning (reg_format): /switch/ports:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #address-cells value > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #size-cells value > > Fix the example by remove the stray 'reg' property. > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Fixes: 3b3b6b460f78 ("net: dsa: Add bindings for Realtek SMI DSAs") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Thu, Dec 23, 2021 at 7:17 PM Florian Fainelli <f.fainelli@gmail.com> wrote: > The 'ports' node is not supposed to have a 'reg' property at all, in > fact, doing so will lead to dtc issuing warnings looking like these: > > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:109.4-14: Warning (reg_format): /switch/ports:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #address-cells value > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #size-cells value > > Fix the example by remove the stray 'reg' property. > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Fixes: 3b3b6b460f78 ("net: dsa: Add bindings for Realtek SMI DSAs") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Ooops thanks for fixing this! (Wouldn't happen if we converted it to YAML...) Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
> Ooops thanks for fixing this! (Wouldn't happen if we converted > it to YAML...) I'm working on it. I might post it in a couple of days. > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Yours, > Linus Walleij
On Mon, Dec 27, 2021 at 08:24:05AM -0300, Luiz Angelo Daros de Luca wrote: > > Ooops thanks for fixing this! (Wouldn't happen if we converted > > it to YAML...) > > I'm working on it. I might post it in a couple of days. Then just fix this in the conversion. > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > > > Yours, > > Linus Walleij >
> Then just fix this in the conversion.
Hi Rob,
I'm not sure if I got your suggestion. Should I post the new patch
in-reply to this thread?
It is related but something completely different.
I sent YAML conversion v1 a little while ago.
https://lore.kernel.org/netdev/20211228072645.32341-1-luizluca@gmail.com/
I'll send v2 soon. I'll mention it in this thread when I do it.
Best,
Luiz
diff --git a/Documentation/devicetree/bindings/net/dsa/realtek-smi.txt b/Documentation/devicetree/bindings/net/dsa/realtek-smi.txt index 7959ec237983..a8d0f1febe32 100644 --- a/Documentation/devicetree/bindings/net/dsa/realtek-smi.txt +++ b/Documentation/devicetree/bindings/net/dsa/realtek-smi.txt @@ -84,7 +84,6 @@ switch { ports { #address-cells = <1>; #size-cells = <0>; - reg = <0>; port@0 { reg = <0>; label = "lan0"; @@ -174,7 +173,7 @@ switch { ports { #address-cells = <1>; #size-cells = <0>; - reg = <0>; + port@0 { reg = <0>; label = "swp0";
The 'ports' node is not supposed to have a 'reg' property at all, in fact, doing so will lead to dtc issuing warnings looking like these: arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:109.4-14: Warning (reg_format): /switch/ports:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #address-cells value arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #size-cells value Fix the example by remove the stray 'reg' property. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Fixes: 3b3b6b460f78 ("net: dsa: Add bindings for Realtek SMI DSAs") Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- Documentation/devicetree/bindings/net/dsa/realtek-smi.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)