diff mbox series

[2/3] dt-bindings: arm: mstar: Add compatible for Miyoo Mini

Message ID 20211213100112.1791192-3-daniel@0x0f.com
State Not Applicable, archived
Headers show
Series ARM: mstar: Initial Miyoo Mini support | expand

Checks

Context Check Description
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success

Commit Message

Daniel Palmer Dec. 13, 2021, 10:01 a.m. UTC
The Miyoo Mini is a SigmaStar SSD202D based retro emulation
device.

Add a compatible for it to the list of infinity2m devices.

Signed-off-by: Daniel Palmer <daniel@0x0f.com>
Link: http://linux-chenxing.org/infinity2/miyoomini/
---
 Documentation/devicetree/bindings/arm/mstar/mstar.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Daniel Palmer Dec. 14, 2021, 4:12 p.m. UTC | #1
Hi Romain,

On Wed, 15 Dec 2021 at 00:07, Romain Perier <romain.perier@gmail.com> wrote:
>> Signed-off-by: Daniel Palmer <daniel@0x0f.com>
>> Link: http://linux-chenxing.org/infinity2/miyoomini/
>
>
> 'Link:' should not be used for that purpose. Usually it is used for referencing discussions
> or patches on lore.k.o . This is typically what I used in the last pull request I sent to Arnd for 5.15.

I sort of remember having this pointed out somewhere else and then
looking at the text in submitting patches and thinking it background
info seemed to be what Link was for with the note that if it's a link
to an on list discussion to use a link to lore:

`If related discussions or any other background information behind the
change can be found on the web, add ‘Link:’ tags pointing to it.
....
When linking to mailing list archives, preferably use the
lore.kernel.org message archiver service."

mmm I need to send a v2 anyhow as I messed up the vendor prefix commit
so I'll move the links out into the message.

Cheers,

Daniel
Rob Herring Dec. 15, 2021, 8:12 p.m. UTC | #2
On Mon, 13 Dec 2021 19:01:11 +0900, Daniel Palmer wrote:
> The Miyoo Mini is a SigmaStar SSD202D based retro emulation
> device.
> 
> Add a compatible for it to the list of infinity2m devices.
> 
> Signed-off-by: Daniel Palmer <daniel@0x0f.com>
> Link: http://linux-chenxing.org/infinity2/miyoomini/
> ---
>  Documentation/devicetree/bindings/arm/mstar/mstar.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/mstar/mstar.yaml b/Documentation/devicetree/bindings/arm/mstar/mstar.yaml
index a316eef1b728..8e1a0e99a60b 100644
--- a/Documentation/devicetree/bindings/arm/mstar/mstar.yaml
+++ b/Documentation/devicetree/bindings/arm/mstar/mstar.yaml
@@ -25,6 +25,7 @@  properties:
           - enum:
               - honestar,ssd201htv2 # Honestar SSD201_HT_V2 devkit
               - m5stack,unitv2 # M5Stack UnitV2
+              - miyoo,miyoo-mini # Miyoo Mini
           - const: mstar,infinity2m
 
       - description: infinity3 boards