diff mbox series

[1/1] ASoC: dt-bindings: audio-graph-port: enable both flag/phandle for bitclock/frame-master

Message ID 20211208044103.405292-1-kuninori.morimoto.gx@renesas.com
State Superseded, archived
Headers show
Series [1/1] ASoC: dt-bindings: audio-graph-port: enable both flag/phandle for bitclock/frame-master | expand

Checks

Context Check Description
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success

Commit Message

Kuninori Morimoto Dec. 8, 2021, 4:41 a.m. UTC
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

snd_soc_daifmt_parse_clock_provider_raw() is handling both
bitclock/frame-master, and is supporting both flag/phandle.
Current DT is assuming it is flag style.
This patch allows both case.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 .../bindings/sound/audio-graph-port.yaml      | 23 +++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)

Comments

Kuninori Morimoto Dec. 8, 2021, 6:45 a.m. UTC | #1
Hi Mark, Rob

> snd_soc_daifmt_parse_clock_provider_raw() is handling both
> bitclock/frame-master, and is supporting both flag/phandle.
> Current DT is assuming it is flag style.
> This patch allows both case.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

It was not good patch.
I will re-post v2 patch. Please drop this.

Best regards
---
Kuninori Morimoto
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
index 43e7f86e3b23..6c3645a0d36b 100644
--- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
+++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
@@ -14,6 +14,24 @@  select: false
 allOf:
   - $ref: /schemas/graph.yaml#/$defs/port-base
 
+definitions:
+  flag_or_phandle:
+    oneOf:
+      - type: boolean
+        const: true
+      - type: 'null'
+      - type: array
+        minItems: 1
+        maxItems: 1
+        items:
+          type: array
+          items:
+            phandle: true
+            type: integer
+            maximum: 0xffffffff
+          minItems: 1
+          maxItems: 1
+
 properties:
   prefix:
     description: "device name prefix"
@@ -42,10 +60,11 @@  patternProperties:
         $ref: /schemas/types.yaml#/definitions/flag
       frame-master:
         description: Indicates dai-link frame master.
-        $ref: /schemas/types.yaml#/definitions/phandle
+        $ref: "#/definitions/flag_or_phandle"
       bitclock-master:
         description: Indicates dai-link bit clock master
-        $ref: /schemas/types.yaml#/definitions/phandle
+        $ref: "#/definitions/flag_or_phandle"
+
       dai-format:
         description: audio format.
         items: