diff mbox series

[1/1] dt-bindings: net: Reintroduce PHY no lane swap binding

Message ID 20211130082756.713919-1-alexander.stein@ew.tq-group.com
State Accepted, archived
Headers show
Series [1/1] dt-bindings: net: Reintroduce PHY no lane swap binding | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 3 warnings, 14 lines checked
robh/dt-meta-schema success
robh/dtbs-check fail build log

Commit Message

Alexander Stein Nov. 30, 2021, 8:27 a.m. UTC
This binding was already documented in phy.txt, commit 252ae5330daa
("Documentation: devicetree: Add PHY no lane swap binding"), but got
accidently removed during YAML conversion in commit d8704342c109
("dt-bindings: net: Add a YAML schemas for the generic PHY options").

Note: 'enet-phy-lane-no-swap' and the absence of 'enet-phy-lane-swap' are
not identical, as the former one disable this feature, while the latter
one doesn't change anything.

Fixes: d8704342c109 ("dt-bindings: net: Add a YAML schemas for the generic PHY options")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 Documentation/devicetree/bindings/net/ethernet-phy.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Andrew Lunn Nov. 30, 2021, 1:54 p.m. UTC | #1
On Tue, Nov 30, 2021 at 09:27:56AM +0100, Alexander Stein wrote:
> This binding was already documented in phy.txt, commit 252ae5330daa
> ("Documentation: devicetree: Add PHY no lane swap binding"), but got
> accidently removed during YAML conversion in commit d8704342c109
> ("dt-bindings: net: Add a YAML schemas for the generic PHY options").
> 
> Note: 'enet-phy-lane-no-swap' and the absence of 'enet-phy-lane-swap' are
> not identical, as the former one disable this feature, while the latter
> one doesn't change anything.
> 
> Fixes: d8704342c109 ("dt-bindings: net: Add a YAML schemas for the generic PHY options")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Rob Herring Dec. 6, 2021, 8:15 p.m. UTC | #2
On Tue, 30 Nov 2021 09:27:56 +0100, Alexander Stein wrote:
> This binding was already documented in phy.txt, commit 252ae5330daa
> ("Documentation: devicetree: Add PHY no lane swap binding"), but got
> accidently removed during YAML conversion in commit d8704342c109
> ("dt-bindings: net: Add a YAML schemas for the generic PHY options").
> 
> Note: 'enet-phy-lane-no-swap' and the absence of 'enet-phy-lane-swap' are
> not identical, as the former one disable this feature, while the latter
> one doesn't change anything.
> 
> Fixes: d8704342c109 ("dt-bindings: net: Add a YAML schemas for the generic PHY options")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  Documentation/devicetree/bindings/net/ethernet-phy.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

Applied, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
index 2766fe45bb98..ee42328a109d 100644
--- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
@@ -91,6 +91,14 @@  properties:
       compensate for the board being designed with the lanes
       swapped.
 
+  enet-phy-lane-no-swap:
+    $ref: /schemas/types.yaml#/definitions/flag
+    description:
+      If set, indicates that PHY will disable swap of the
+      TX/RX lanes. This property allows the PHY to work correcly after
+      e.g. wrong bootstrap configuration caused by issues in PCB
+      layout design.
+
   eee-broken-100tx:
     $ref: /schemas/types.yaml#/definitions/flag
     description: