diff mbox series

[1/2] dt-bindings: arm/stm32: Add emtrion hardware emSBC-Argon

Message ID 20211130081654.119028-2-reinhold.mueller@emtrion.com
State Changes Requested, archived
Headers show
Series new emtrion hardware emSBC-Argon | expand

Checks

Context Check Description
robh/checkpatch success
robh/dt-meta-schema success
robh/dtbs-check success

Commit Message

reinhold.mueller@emtrion.com Nov. 30, 2021, 8:16 a.m. UTC
From: Reinhold Mueller <reinhold.mueller@emtrion.com>

This patch presents the yaml patch for the emtrion GmbH
Argon board series.

Signed-off-by: Reinhold Mueller <reinhold.mueller@emtrion.com>
---
 Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Rob Herring Dec. 7, 2021, 9:25 p.m. UTC | #1
On Tue, Nov 30, 2021 at 09:16:53AM +0100, reinhold.mueller@emtrion.com wrote:
> From: Reinhold Mueller <reinhold.mueller@emtrion.com>
> 
> This patch presents the yaml patch for the emtrion GmbH
> Argon board series.
> 
> Signed-off-by: Reinhold Mueller <reinhold.mueller@emtrion.com>
> ---
>  Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> index bcaf7be3ab37..710230847dcd 100644
> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> @@ -28,6 +28,14 @@ properties:
>            - enum:
>                - st,stm32mp153
>                - st,stm32mp157
> +
> +      - description: emtrion STM32MP1 Argon based Boards
> +        items:
> +          - enum:
> +              - emtrion,stm32mp157c-emsbc-argon
> +          - enum:
> +              - emtrion,stm32mp157c-emstamp-argon

Is there going to be multiple entries here? If not, use 'const' instead 
of 'enum'.

> +          - const: st,stm32mp157
>        - items:
>            - enum:
>                - st,stm32f429i-disco
> -- 
> 2.20.1
> 
>
Mueller, Reinhold Dec. 9, 2021, 10:48 a.m. UTC | #2
Hi Rob,

please see the comments below.

Regards
Reinhold


Reinhold Mueller
Software engineer


emtrion GmbH
Am Hasenbiel 6 | 76297 Stutensee | Germany

Phone +49 7244 62694 20
Fax +49 7244 62694 19
Email Reinhold.Mueller@emtrion.de
Online www.emtrion.de




emtrion GmbH • Amtsgericht Mannheim • HRB 110 300 • Geschäftsführer: Ramona Maurer, Achmed Haddou • Umsatzsteueridentifikationsnummer:DE813694260 • Impressum: www.emtrion.de/de/impressum.html

HINWEIS: Personenbezogene Daten, die Sie per E-Mail an uns übermitteln, werden bei uns gespeichert und verarbeitet. Informationen zu unseren gesetzlichen Informationspflichten, zu uns und unseren Dienstleistungen finden Sie in unseren Datenschutzhinweisen.
Diese E-Mail kann vertrauliche und / oder rechtlich geschützte Informationen enthalten. Wenn Sie nicht der richtige Adressat sind, oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte den Absender und vernichten diese Mail. Das unerlaubte kopieren, sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet.
> -----Ursprüngliche Nachricht-----
> Von: Rob Herring <robh@kernel.org>
> Gesendet: Dienstag, 7. Dezember 2021 22:25
> An: Mueller, Reinhold <Reinhold.Mueller@emtrion.de>
> Cc: alexandre.torgue@foss.st.com; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Betreff: Re: [PATCH 1/2] dt-bindings: arm/stm32: Add emtrion hardware
> emSBC-Argon
>
> On Tue, Nov 30, 2021 at 09:16:53AM +0100, reinhold.mueller@emtrion.com
> wrote:
> > From: Reinhold Mueller <reinhold.mueller@emtrion.com>
> >
> > This patch presents the yaml patch for the emtrion GmbH
> > Argon board series.
> >
> > Signed-off-by: Reinhold Mueller <reinhold.mueller@emtrion.com>
> > ---
> >  Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 8
> ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> > index bcaf7be3ab37..710230847dcd 100644
> > --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> > +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> > @@ -28,6 +28,14 @@ properties:
> >            - enum:
> >                - st,stm32mp153
> >                - st,stm32mp157
> > +
> > +      - description: emtrion STM32MP1 Argon based Boards
> > +        items:
> > +          - enum:
> > +              - emtrion,stm32mp157c-emsbc-argon
> > +          - enum:
> > +              - emtrion,stm32mp157c-emstamp-argon
>
> Is there going to be multiple entries here? If not, use 'const' instead
> of 'enum'.
>
currently no more entries, i will resent a modified patchset
> > +          - const: st,stm32mp157
> >        - items:
> >            - enum:
> >                - st,stm32f429i-disco
> > --
> > 2.20.1
> >
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
index bcaf7be3ab37..710230847dcd 100644
--- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
+++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
@@ -28,6 +28,14 @@  properties:
           - enum:
               - st,stm32mp153
               - st,stm32mp157
+
+      - description: emtrion STM32MP1 Argon based Boards
+        items:
+          - enum:
+              - emtrion,stm32mp157c-emsbc-argon
+          - enum:
+              - emtrion,stm32mp157c-emstamp-argon
+          - const: st,stm32mp157
       - items:
           - enum:
               - st,stm32f429i-disco