| Message ID | 20211116074130.107554-6-yoshihiro.shimoda.uh@renesas.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | treewide: Initial support for R-Car S4-8 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/checkpatch | success |
Hi Shimoda-san, On Tue, Nov 16, 2021 at 8:42 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > Add power domain indices for R-Car S4-8 (r8a779f0). > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Thanks for your patch! > --- /dev/null > +++ b/include/dt-bindings/power/r8a779f0-sysc.h > @@ -0,0 +1,30 @@ > +/* SPDX-License-Identifier: (GPL-2.0 or MIT) */ > +/* > + * Copyright (C) 2021 Renesas Electronics Corp. > + */ > +#ifndef __DT_BINDINGS_POWER_R8A779F0_SYSC_H__ > +#define __DT_BINDINGS_POWER_R8A779F0_SYSC_H__ > + > +/* > + * These power domain indices match the Power Domain Register Numbers (PDR) > + */ > + > +#define R8A779F0_PD_A1E0D0C0 0 > +#define R8A779F0_PD_A1E0D0C1 1 > +#define R8A779F0_PD_A1E0D1C0 2 > +#define R8A779F0_PD_A1E0D1C1 3 > +#define R8A779F0_PD_A1E1D0C0 4 > +#define R8A779F0_PD_A1E1D0C1 5 > +#define R8A779F0_PD_A1E1D1C0 6 > +#define R8A779F0_PD_A1E1D1C1 7 > +#define R8A779F0_PD_A2E0D0 16 > +#define R8A779F0_PD_A2E0D1 17 > +#define R8A779F0_PD_A2E1D0 18 > +#define R8A779F0_PD_A2E1D1 19 > +#define R8A779F0_PD_A3E0 20 > +#define R8A779F0_PD_A3E1 21 The above are fine. > + > +/* Always-on power area */ > +#define R8A779F0_PD_ALWAYS_ON 22 This should be 64 (i.e. beyond the range supported by the hardware block). > + > +#endif /* __DT_BINDINGS_POWER_R8A779A0_SYSC_H__*/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert-san, Thank you for your review! > From: Geert Uytterhoeven, Sent: Friday, November 19, 2021 3:42 AM > > On Tue, Nov 16, 2021 at 8:42 AM Yoshihiro Shimoda > <yoshihiro.shimoda.uh@renesas.com> wrote: > > Add power domain indices for R-Car S4-8 (r8a779f0). > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Thanks for your patch! > > > --- /dev/null > > +++ b/include/dt-bindings/power/r8a779f0-sysc.h > > @@ -0,0 +1,30 @@ <snip> > > + > > +/* Always-on power area */ > > +#define R8A779F0_PD_ALWAYS_ON 22 > > This should be 64 (i.e. beyond the range supported by the hardware > block). I got it. I'll fix it in v2. Best regards, Yoshihiro Shimoda
diff --git a/include/dt-bindings/power/r8a779f0-sysc.h b/include/dt-bindings/power/r8a779f0-sysc.h new file mode 100644 index 000000000000..97e6ed5c16d5 --- /dev/null +++ b/include/dt-bindings/power/r8a779f0-sysc.h @@ -0,0 +1,30 @@ +/* SPDX-License-Identifier: (GPL-2.0 or MIT) */ +/* + * Copyright (C) 2021 Renesas Electronics Corp. + */ +#ifndef __DT_BINDINGS_POWER_R8A779F0_SYSC_H__ +#define __DT_BINDINGS_POWER_R8A779F0_SYSC_H__ + +/* + * These power domain indices match the Power Domain Register Numbers (PDR) + */ + +#define R8A779F0_PD_A1E0D0C0 0 +#define R8A779F0_PD_A1E0D0C1 1 +#define R8A779F0_PD_A1E0D1C0 2 +#define R8A779F0_PD_A1E0D1C1 3 +#define R8A779F0_PD_A1E1D0C0 4 +#define R8A779F0_PD_A1E1D0C1 5 +#define R8A779F0_PD_A1E1D1C0 6 +#define R8A779F0_PD_A1E1D1C1 7 +#define R8A779F0_PD_A2E0D0 16 +#define R8A779F0_PD_A2E0D1 17 +#define R8A779F0_PD_A2E1D0 18 +#define R8A779F0_PD_A2E1D1 19 +#define R8A779F0_PD_A3E0 20 +#define R8A779F0_PD_A3E1 21 + +/* Always-on power area */ +#define R8A779F0_PD_ALWAYS_ON 22 + +#endif /* __DT_BINDINGS_POWER_R8A779A0_SYSC_H__*/
Add power domain indices for R-Car S4-8 (r8a779f0). Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- include/dt-bindings/power/r8a779f0-sysc.h | 30 +++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 include/dt-bindings/power/r8a779f0-sysc.h