| Message ID | 20211103231327.385186-2-f.fainelli@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Removal of bcm63xx-wdt | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 40 lines checked |
| robh/dt-meta-schema | fail | build log |
On Wed, 03 Nov 2021 16:13:21 -0700, Florian Fainelli wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > This helps validating DTS files. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > .../bindings/watchdog/brcm,bcm7038-wdt.txt | 19 --------- > .../bindings/watchdog/brcm,bcm7038-wdt.yaml | 40 +++++++++++++++++++ > 2 files changed, 40 insertions(+), 19 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt > create mode 100644 Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml: $id: relative path/filename doesn't match actual path or filename expected: http://devicetree.org/schemas/watchdog/brcm,bcm7038-wdt.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1550624 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 11/3/21 4:13 PM, Florian Fainelli wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > This helps validating DTS files. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > .../bindings/watchdog/brcm,bcm7038-wdt.txt | 19 --------- > .../bindings/watchdog/brcm,bcm7038-wdt.yaml | 40 +++++++++++++++++++ > 2 files changed, 40 insertions(+), 19 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt > create mode 100644 Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt b/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt > deleted file mode 100644 > index 84122270be8f..000000000000 > --- a/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt > +++ /dev/null > @@ -1,19 +0,0 @@ > -BCM7038 Watchdog timer > - > -Required properties: > - > -- compatible : should be "brcm,bcm7038-wdt" > -- reg : Specifies base physical address and size of the registers. > - > -Optional properties: > - > -- clocks: The clock running the watchdog. If no clock is found the > - driver will default to 27000000 Hz. > - > -Example: > - > -watchdog@f040a7e8 { > - compatible = "brcm,bcm7038-wdt"; > - clocks = <&upg_fixed>; > - reg = <0xf040a7e8 0x16>; > -}; > diff --git a/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml b/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml > new file mode 100644 > index 000000000000..69e5a1ef6a1f > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml > @@ -0,0 +1,40 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/brcm,bcm63xx-wdt.yaml# Looks like this requires s/63xx/7038/ Guenter > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: BCM7038 watchdog timer > + > +allOf: > + - $ref: "watchdog.yaml#" > + > +maintainers: > + - Florian Fainelli <f.fainelli@gmail.com> > + - Justin Chen <justinpopo6@gmail.com> > + - Rafał Miłecki <rafal@milecki.pl> > + > +properties: > + compatible: > + const: brcm,bcm7038-wdt > + > + reg: > + maxItems: 1 > + > + clocks: > + description: > > + The clock running the watchdog. If no clock is found the driver will > + default to 27000000 Hz. > + > +unevaluatedProperties: false > + > +required: > + - reg > + > +examples: > + - | > + watchdog@f040a7e8 { > + compatible = "brcm,bcm7038-wdt"; > + reg = <0xf040a7e8 0x16>; > + clocks = <&upg_fixed>; > + }; >
diff --git a/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt b/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt deleted file mode 100644 index 84122270be8f..000000000000 --- a/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt +++ /dev/null @@ -1,19 +0,0 @@ -BCM7038 Watchdog timer - -Required properties: - -- compatible : should be "brcm,bcm7038-wdt" -- reg : Specifies base physical address and size of the registers. - -Optional properties: - -- clocks: The clock running the watchdog. If no clock is found the - driver will default to 27000000 Hz. - -Example: - -watchdog@f040a7e8 { - compatible = "brcm,bcm7038-wdt"; - clocks = <&upg_fixed>; - reg = <0xf040a7e8 0x16>; -}; diff --git a/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml b/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml new file mode 100644 index 000000000000..69e5a1ef6a1f --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml @@ -0,0 +1,40 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/brcm,bcm63xx-wdt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: BCM7038 watchdog timer + +allOf: + - $ref: "watchdog.yaml#" + +maintainers: + - Florian Fainelli <f.fainelli@gmail.com> + - Justin Chen <justinpopo6@gmail.com> + - Rafał Miłecki <rafal@milecki.pl> + +properties: + compatible: + const: brcm,bcm7038-wdt + + reg: + maxItems: 1 + + clocks: + description: > + The clock running the watchdog. If no clock is found the driver will + default to 27000000 Hz. + +unevaluatedProperties: false + +required: + - reg + +examples: + - | + watchdog@f040a7e8 { + compatible = "brcm,bcm7038-wdt"; + reg = <0xf040a7e8 0x16>; + clocks = <&upg_fixed>; + };