diff mbox series

[08/13] dt-bindings: serial: fsl-lpuart: add i.MXRT compatible

Message ID 20211024154027.1479261-9-Mr.Bossman075@gmail.com
State Not Applicable, archived
Headers show
Series This patchset aims to add initial support for the i.MXRT10xx family | expand

Checks

Context Check Description
robh/checkpatch success
robh/dt-meta-schema success
robh/dtbs-check fail build log

Commit Message

Jesse T Oct. 24, 2021, 3:40 p.m. UTC
Add i.MXRT documentation for compatible string.

Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
---
 Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring Nov. 1, 2021, 8:11 p.m. UTC | #1
On Sun, 24 Oct 2021 11:40:22 -0400, Jesse Taube wrote:
> Add i.MXRT documentation for compatible string.
> 
> Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> ---
>  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Rob Herring Nov. 1, 2021, 8:13 p.m. UTC | #2
On Sun, Oct 24, 2021 at 11:40:22AM -0400, Jesse Taube wrote:
> Add i.MXRT documentation for compatible string.
> 
> Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> ---
>  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> index a90c971b4f1f..4b4340def2aa 100644
> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> @@ -21,6 +21,7 @@ properties:
>            - fsl,ls1028a-lpuart
>            - fsl,imx7ulp-lpuart
>            - fsl,imx8qm-lpuart
> +          - fsl,imxrt-lpuart

Actually, 'rt' is not a single part is it? If the variations are same 
die, but fused off then no need to distinguish. Otherwise, these should 
be SoC specific.

Same applies to other compatible strings.

>        - items:
>            - const: fsl,imx8qxp-lpuart
>            - const: fsl,imx7ulp-lpuart
> -- 
> 2.33.0
> 
>
Jesse T Nov. 1, 2021, 11:34 p.m. UTC | #3
On 11/1/21 16:13, Rob Herring wrote:
> On Sun, Oct 24, 2021 at 11:40:22AM -0400, Jesse Taube wrote:
>> Add i.MXRT documentation for compatible string.
>>
>> Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
>> ---
>>  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
>> index a90c971b4f1f..4b4340def2aa 100644
>> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
>> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
>> @@ -21,6 +21,7 @@ properties:
>>            - fsl,ls1028a-lpuart
>>            - fsl,imx7ulp-lpuart
>>            - fsl,imx8qm-lpuart
>> +          - fsl,imxrt-lpuart
> 
> Actually, 'rt' is not a single part is it? If the variations are same 
> die, but fused off then no need to distinguish. Otherwise, these should 
> be SoC specific.
> 
I don't exactly know what "but fused off" means I would assume
disconnected but on-die? The imxrtxxx is a series that has the same UART
controller across them. Should I add ACK?
> Same applies to other compatible strings.
> 
>>        - items:
>>            - const: fsl,imx8qxp-lpuart
>>            - const: fsl,imx7ulp-lpuart
>> -- 
>> 2.33.0
>>
>>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
index a90c971b4f1f..4b4340def2aa 100644
--- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
+++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
@@ -21,6 +21,7 @@  properties:
           - fsl,ls1028a-lpuart
           - fsl,imx7ulp-lpuart
           - fsl,imx8qm-lpuart
+          - fsl,imxrt-lpuart
       - items:
           - const: fsl,imx8qxp-lpuart
           - const: fsl,imx7ulp-lpuart