| Message ID | 20211024002358.225750-1-marex@denx.de |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/2] dt-bindings: leds: Document none trigger | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | success |
Hi! > There is a trigger called "none" which triggers never, add it to the > list of valid trigger values. We can do this, but is it useful? If you avoid putting trigger property, it will do the same thing. Best regards, Pavel
On 10/24/21 10:41 AM, Pavel Machek wrote: > Hi! > >> There is a trigger called "none" which triggers never, add it to the >> list of valid trigger values. > > We can do this, but is it useful? If you avoid putting trigger > property, it will do the same thing. It's not that simple. If you have a DT which specifies a trigger type and a DTO which overrides that trigger type, then the DTO cannot remove the trigger from the base DT, it has to set trigger type to "none". So I believe there is a valid use case for existence of the "none" type.
On Sun, Oct 24, 2021 at 08:05:55PM +0200, Marek Vasut wrote: > On 10/24/21 10:41 AM, Pavel Machek wrote: > > Hi! > > > > > There is a trigger called "none" which triggers never, add it to the > > > list of valid trigger values. > > > > We can do this, but is it useful? If you avoid putting trigger > > property, it will do the same thing. > > It's not that simple. If you have a DT which specifies a trigger type and a > DTO which overrides that trigger type, then the DTO cannot remove the > trigger from the base DT, it has to set trigger type to "none". So I believe > there is a valid use case for existence of the "none" type. Sounds like an incorrect partitioning of base and overlays IMO. There's also already /delete-property/ directive though I'm not sure if that's supported in overlays. Rob
On 11/8/21 6:51 PM, Rob Herring wrote: > On Sun, Oct 24, 2021 at 08:05:55PM +0200, Marek Vasut wrote: >> On 10/24/21 10:41 AM, Pavel Machek wrote: >>> Hi! >>> >>>> There is a trigger called "none" which triggers never, add it to the >>>> list of valid trigger values. >>> >>> We can do this, but is it useful? If you avoid putting trigger >>> property, it will do the same thing. >> >> It's not that simple. If you have a DT which specifies a trigger type and a >> DTO which overrides that trigger type, then the DTO cannot remove the >> trigger from the base DT, it has to set trigger type to "none". So I believe >> there is a valid use case for existence of the "none" type. > > Sounds like an incorrect partitioning of base and overlays IMO. Note that you might not have control over the base DT. > There's also already /delete-property/ directive though I'm not sure if > that's supported in overlays. How do you encode /delete-property/ into the DT overlay blob .dtbo ? I thought that /delete-property/ and /delete-node/ was a DTC directive and the DT blob has no way to represent either ?
diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml index 697102707703a..22197376fa3c7 100644 --- a/Documentation/devicetree/bindings/leds/common.yaml +++ b/Documentation/devicetree/bindings/leds/common.yaml @@ -92,6 +92,8 @@ properties: # LED indicates IDE disk activity (deprecated), in new implementations # use "disk-activity" - ide-disk + # LED is not triggered + - none # LED flashes at a fixed, configurable rate - timer # LED alters the brightness for the specified duration with one software
There is a trigger called "none" which triggers never, add it to the list of valid trigger values. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com> Cc: Pavel Machek <pavel@ucw.cz> Cc: Rob Herring <robh+dt@kernel.org> Cc: devicetree@vger.kernel.org To: linux-leds@vger.kernel.org --- Documentation/devicetree/bindings/leds/common.yaml | 2 ++ 1 file changed, 2 insertions(+)