| Message ID | 20211018192952.2736913-3-vladimir.oltean@nxp.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | New RGMII delay DT bindings for the SJA1105 DSA driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | success |
On Mon, Oct 18, 2021 at 10:29:50PM +0300, Vladimir Oltean wrote: > Since a switch is basically a bunch of Ethernet controllers, just > inherit the common schema for one to get stronger type validation of the > properties of a port. > > For example, before this change it was valid to have a phy-mode = "xfi" > even if "xfi" is not part of ethernet-controller.yaml, now it is not. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > --- > Documentation/devicetree/bindings/net/dsa/dsa.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.yaml b/Documentation/devicetree/bindings/net/dsa/dsa.yaml > index 224cfa45de9a..9cfd08cd31da 100644 > --- a/Documentation/devicetree/bindings/net/dsa/dsa.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/dsa.yaml > @@ -46,6 +46,9 @@ patternProperties: > type: object > description: Ethernet switch ports > > + allOf: > + - $ref: "http://devicetree.org/schemas/net/ethernet-controller.yaml#" $ref: /schemas/net/ethernet-controller.yaml# And don't need 'allOf'. > + > properties: > reg: > description: Port number > -- > 2.25.1 > >
diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.yaml b/Documentation/devicetree/bindings/net/dsa/dsa.yaml index 224cfa45de9a..9cfd08cd31da 100644 --- a/Documentation/devicetree/bindings/net/dsa/dsa.yaml +++ b/Documentation/devicetree/bindings/net/dsa/dsa.yaml @@ -46,6 +46,9 @@ patternProperties: type: object description: Ethernet switch ports + allOf: + - $ref: "http://devicetree.org/schemas/net/ethernet-controller.yaml#" + properties: reg: description: Port number