diff mbox series

[1/3] dt-bindings: arm: fsl: add TQ-Systems boards based on i.MX6Q/QP/DL

Message ID 20211013111202.6231-1-matthias.schiffer@ew.tq-group.com
State Not Applicable, archived
Headers show
Series [1/3] dt-bindings: arm: fsl: add TQ-Systems boards based on i.MX6Q/QP/DL | expand

Checks

Context Check Description
robh/checkpatch success
robh/dt-meta-schema success
robh/dtbs-check fail build log

Commit Message

Matthias Schiffer Oct. 13, 2021, 11:12 a.m. UTC
The TQ-Systems MBa6x mainboard can be used with TQMa6 variants with
i.MX6Q/QP/DL SoCs (TQMa6Q/QP/DL). The TQMa6Q and DL exist in two variants:
The newer variants "A" have a hardware workaround for Erratum ERR006687,
while variants "B" are missing such a workaround, so it needs to be
handled in software. The erratum was fixed in i.MX6QP, so no "A" variant
of the TQMa6QP exists.

Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
 .../devicetree/bindings/arm/fsl.yaml          | 35 +++++++++++++++++++
 1 file changed, 35 insertions(+)

Comments

Rob Herring Oct. 26, 2021, 8:15 p.m. UTC | #1
On Wed, Oct 13, 2021 at 01:12:02PM +0200, Matthias Schiffer wrote:
> From: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> 
> Add device trees for the MBa6x mainboard with TQMa6Q/QP/DL SoMs.
> 
> Files are imported with (GPL-2.0-or-later OR MIT) license where the
> copyright is held fully by TQ-Systems. Other files with less clear
> copyright ownership use their original GPL-2.0-or-later license.

Thanks for giving it some thought, but I don't think 'or-later' works 
given imx6dl.dtsi is GPL-2.0-only. It's kind of a mess though:

$ git grep -ho 'SPDX.*' arch/arm/boot/dts/imx6dl* | sort -u
SPDX-License-Identifier: GPL-2.0
SPDX-License-Identifier: GPL-2.0+
SPDX-License-Identifier: GPL-2.0-only
SPDX-License-Identifier: GPL-2.0-only */
SPDX-License-Identifier: GPL-2.0-or-later
SPDX-License-Identifier: GPL-2.0-or-later OR MIT
SPDX-License-Identifier: (GPL-2.0 or MIT)
SPDX-License-Identifier: GPL-2.0 or MIT
SPDX-License-Identifier: (GPL-2.0 OR MIT)
SPDX-License-Identifier: GPL-2.0 OR MIT
SPDX-License-Identifier: (GPL-2.0+ OR MIT)
SPDX-License-Identifier: GPL-2.0+ OR MIT
SPDX-License-Identifier: GPL-2.0 OR X11

The dts files are all too intertwined to be different licenses IMO.

Rob
Rob Herring Oct. 26, 2021, 8:16 p.m. UTC | #2
On Wed, 13 Oct 2021 13:12:00 +0200, Matthias Schiffer wrote:
> The TQ-Systems MBa6x mainboard can be used with TQMa6 variants with
> i.MX6Q/QP/DL SoCs (TQMa6Q/QP/DL). The TQMa6Q and DL exist in two variants:
> The newer variants "A" have a hardware workaround for Erratum ERR006687,
> while variants "B" are missing such a workaround, so it needs to be
> handled in software. The erratum was fixed in i.MX6QP, so no "A" variant
> of the TQMa6QP exists.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
>  .../devicetree/bindings/arm/fsl.yaml          | 35 +++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index f08d77b4a1f0..a48e48e524c2 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -323,6 +323,20 @@  properties:
           - const: toradex,apalis_imx6q
           - const: fsl,imx6q
 
+      - description: TQ-Systems TQMa6Q SoM (variant A) on MBa6x
+        items:
+          - const: tq,imx6q-mba6x-a
+          - const: tq,mba6a               # Expected by bootloader, to be removed in the future
+          - const: tq,imx6q-tqma6q-a
+          - const: fsl,imx6q
+
+      - description: TQ-Systems TQMa6Q SoM (variant B) on MBa6x
+        items:
+          - const: tq,imx6q-mba6x-b
+          - const: tq,mba6b               # Expected by bootloader, to be removed in the future
+          - const: tq,imx6q-tqma6q-b
+          - const: fsl,imx6q
+
       - description: i.MX6QP based Boards
         items:
           - enum:
@@ -344,6 +358,13 @@  properties:
           - const: phytec,imx6qdl-pcm058  # PHYTEC phyCORE-i.MX6
           - const: fsl,imx6qp
 
+      - description: TQ-Systems TQMa6QP SoM on MBa6x
+        items:
+          - const: tq,imx6qp-mba6x-b
+          - const: tq,mba6b               # Expected by bootloader, to be removed in the future
+          - const: tq,imx6qp-tqma6qp-b
+          - const: fsl,imx6qp
+
       - description: i.MX6DL based Boards
         items:
           - enum:
@@ -482,6 +503,20 @@  properties:
           - const: dh,imx6s-dhcom-som
           - const: fsl,imx6dl
 
+      - description: TQ-Systems TQMa6DL SoM (variant A) on MBa6x
+        items:
+          - const: tq,imx6dl-mba6x-a
+          - const: tq,mba6a               # Expected by bootloader, to be removed in the future
+          - const: tq,imx6dl-tqma6dl-a
+          - const: fsl,imx6dl
+
+      - description: TQ-Systems TQMa6DL SoM (variant B) on MBa6x
+        items:
+          - const: tq,imx6dl-mba6x-b
+          - const: tq,mba6b               # Expected by bootloader, to be removed in the future
+          - const: tq,imx6dl-tqma6dl-b
+          - const: fsl,imx6dl
+
       - description: i.MX6SL based Boards
         items:
           - enum: