| Message ID | 20211013105541.68045-6-bhupesh.sharma@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Enable Qualcomm Crypto Engine on sm8250 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | fail | build log |
Hi Bhupesh, On 10/13/21 1:55 PM, Bhupesh Sharma wrote: > Add new optional properties - 'interconnects' and > 'interconnect-names' to the device-tree binding documentation for > qcom-bam DMA IP. > > These properties describe the interconnect path between bam and main > memory and the interconnect type respectively. > > Cc: Thara Gopinath <thara.gopinath@linaro.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml b/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml > index 32b47e3b7769..602e68df971f 100644 > --- a/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml > +++ b/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml > @@ -45,6 +45,14 @@ properties: > const: 1 > description: The single cell represents the channel index. > > + interconnects: > + maxItems: 1 > + description: | here I have the same comment about the set literal style of the multi-line description, which is one-line, likely the specifier is not needed... > + Interconnect path between bam and main memory. > + > + interconnect-names: > + const: memory > + > qcom,ee: > $ref: /schemas/types.yaml#/definitions/uint32 > description: > -- Best wishes, Vladimir
Hi Vladimir, On Wed, 13 Oct 2021 at 18:33, Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> wrote: > > Hi Bhupesh, > > On 10/13/21 1:55 PM, Bhupesh Sharma wrote: > > Add new optional properties - 'interconnects' and > > 'interconnect-names' to the device-tree binding documentation for > > qcom-bam DMA IP. > > > > These properties describe the interconnect path between bam and main > > memory and the interconnect type respectively. > > > > Cc: Thara Gopinath <thara.gopinath@linaro.org> > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > Cc: Rob Herring <robh+dt@kernel.org> > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > --- > > Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml b/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml > > index 32b47e3b7769..602e68df971f 100644 > > --- a/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml > > +++ b/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml > > @@ -45,6 +45,14 @@ properties: > > const: 1 > > description: The single cell represents the channel index. > > > > + interconnects: > > + maxItems: 1 > > + description: | > > here I have the same comment about the set literal style of the > multi-line description, which is one-line, likely the specifier > is not needed... Ok, I will fix it in v5. Regards, Bhupesh > > + Interconnect path between bam and main memory. > > + > > + interconnect-names: > > + const: memory > > + > > qcom,ee: > > $ref: /schemas/types.yaml#/definitions/uint32 > > description: > > > > -- > Best wishes, > Vladimir
On Wed, 13 Oct 2021 16:25:26 +0530, Bhupesh Sharma wrote: > Add new optional properties - 'interconnects' and > 'interconnect-names' to the device-tree binding documentation for > qcom-bam DMA IP. > > These properties describe the interconnect path between bam and main > memory and the interconnect type respectively. > > Cc: Thara Gopinath <thara.gopinath@linaro.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1540390 dma@12142000: $nodename:0: 'dma@12142000' does not match '^dma-controller(@.*)?$' arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml dma@12182000: $nodename:0: 'dma@12182000' does not match '^dma-controller(@.*)?$' arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml arch/arm/boot/dts/qcom-ipq8064-ap148.dt.yaml arch/arm/boot/dts/qcom-ipq8064-rb3011.dt.yaml arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml dma@121c2000: $nodename:0: 'dma@121c2000' does not match '^dma-controller(@.*)?$' arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml dma@12402000: $nodename:0: 'dma@12402000' does not match '^dma-controller(@.*)?$' arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml arch/arm/boot/dts/qcom-ipq8064-ap148.dt.yaml arch/arm/boot/dts/qcom-ipq8064-rb3011.dt.yaml dma@1dc4000: $nodename:0: 'dma@1dc4000' does not match '^dma-controller(@.*)?$' arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml dma@1dc4000: 'iommus' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml dma@1dc4000: qcom,controlled-remotely: 'oneOf' conditional failed, one must be fixed: arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml dma@704000: $nodename:0: 'dma@704000' does not match '^dma-controller(@.*)?$' arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml dma@704000: qcom,controlled-remotely: 'oneOf' conditional failed, one must be fixed: arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml dma@7544000: $nodename:0: 'dma@7544000' does not match '^dma-controller(@.*)?$' arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml dma@7584000: $nodename:0: 'dma@7584000' does not match '^dma-controller(@.*)?$' arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml dma@7884000: $nodename:0: 'dma@7884000' does not match '^dma-controller(@.*)?$' arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml dma@7984000: $nodename:0: 'dma@7984000' does not match '^dma-controller(@.*)?$' arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml dma@8e04000: $nodename:0: 'dma@8e04000' does not match '^dma-controller(@.*)?$' arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml dma@c184000: $nodename:0: 'dma@c184000' does not match '^dma-controller(@.*)?$' arch/arm64/boot/dts/qcom/msm8998-asus-novago-tp370ql.dt.yaml arch/arm64/boot/dts/qcom/msm8998-hp-envy-x2.dt.yaml arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dt.yaml arch/arm64/boot/dts/qcom/msm8998-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dt.yaml arch/arm64/boot/dts/qcom/msm8998-oneplus-dumpling.dt.yaml dma-controller@17184000: 'iommus' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml dma-controller@704000: 'qcom,config-pipe-trust-reg' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml dma-controller@704000: qcom,controlled-remotely: 'oneOf' conditional failed, one must be fixed: arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml dma-controller@7984000: clock-names:0: 'bam_clk' was expected arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml dma-controller@7984000: clock-names: Additional items are not allowed ('bam_clk' was unexpected) arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml dma-controller@7984000: clock-names: ['iface_clk', 'bam_clk'] is too long arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml dma-controller@7984000: clocks: [[9, 138], [9, 137]] is too long arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml
Hello Rob, Thanks for your review. These issues are already fixed via patches within this series itself (as some dts also need correction to pass the 'make dtbs_check' check). I am not sure, but it seems the check was run without applying other patches from this series. See details below: On Thu, 14 Oct 2021 at 00:09, Rob Herring <robh@kernel.org> wrote: > > On Wed, 13 Oct 2021 16:25:26 +0530, Bhupesh Sharma wrote: > > Add new optional properties - 'interconnects' and > > 'interconnect-names' to the device-tree binding documentation for > > qcom-bam DMA IP. > > > > These properties describe the interconnect path between bam and main > > memory and the interconnect type respectively. > > > > Cc: Thara Gopinath <thara.gopinath@linaro.org> > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > Cc: Rob Herring <robh+dt@kernel.org> > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > --- > > Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1540390 > > > dma@12142000: $nodename:0: 'dma@12142000' does not match '^dma-controller(@.*)?$' > arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml > > dma@12182000: $nodename:0: 'dma@12182000' does not match '^dma-controller(@.*)?$' > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml > arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml > arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml > arch/arm/boot/dts/qcom-ipq8064-ap148.dt.yaml > arch/arm/boot/dts/qcom-ipq8064-rb3011.dt.yaml > arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml > > dma@121c2000: $nodename:0: 'dma@121c2000' does not match '^dma-controller(@.*)?$' > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml > arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml > arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml > > dma@12402000: $nodename:0: 'dma@12402000' does not match '^dma-controller(@.*)?$' > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml > arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml > arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml > arch/arm/boot/dts/qcom-ipq8064-ap148.dt.yaml > arch/arm/boot/dts/qcom-ipq8064-rb3011.dt.yaml > > dma@1dc4000: $nodename:0: 'dma@1dc4000' does not match '^dma-controller(@.*)?$' > arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml All the above will be fixed by '[PATCH 01/20] arm64/dts: qcom: Fix 'dma' & 'qcom,controlled-remotely' nodes in dts' in this series. See the git log of the this patch for details: 'A few qcom device-tree files define dma-controller nodes with non-standard 'node names' and also set the bool property 'qcom,controlled-remotely' incorrectly, which leads to following errors with 'make dtbs_check': $ arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml: dma@1dc4000: $nodename:0: 'dma@1dc4000' does not match '^dma-controller(@.*)?$' $ arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml: dma@1dc4000: qcom,controlled-remotely: 'oneOf' conditional failed, one must be fixed: [[1]] is not of type 'boolean' True was expected [[1]] is not of type 'null' Fix the same. ' > dma@1dc4000: 'iommus' does not match any of the regexes: 'pinctrl-[0-9]+' > arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml Fixed by ' [PATCH 06/20] dt-bindings: qcom-bam: Add 'iommus' to optional properties ' in this series. > dma@1dc4000: qcom,controlled-remotely: 'oneOf' conditional failed, one must be fixed: > arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml Again this would be fixed by '[PATCH 01/20] arm64/dts: qcom: Fix 'dma' & 'qcom,controlled-remotely' nodes in dts' in this series. > dma@704000: $nodename:0: 'dma@704000' does not match '^dma-controller(@.*)?$' > arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml > arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml > arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml Fixed by '[PATCH 01/20] arm64/dts: qcom: Fix 'dma' & 'qcom,controlled-remotely' nodes in dts' in this series > dma@704000: qcom,controlled-remotely: 'oneOf' conditional failed, one must be fixed: > arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml > arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml > arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml Fixed by '[PATCH 01/20] arm64/dts: qcom: Fix 'dma' & 'qcom,controlled-remotely' nodes in dts' in this series > dma@7544000: $nodename:0: 'dma@7544000' does not match '^dma-controller(@.*)?$' > arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml > arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml > > dma@7584000: $nodename:0: 'dma@7584000' does not match '^dma-controller(@.*)?$' > arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml > arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml > > dma@7884000: $nodename:0: 'dma@7884000' does not match '^dma-controller(@.*)?$' > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml > arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml > > dma@7984000: $nodename:0: 'dma@7984000' does not match '^dma-controller(@.*)?$' > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml > arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml > > dma@8e04000: $nodename:0: 'dma@8e04000' does not match '^dma-controller(@.*)?$' > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml > arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml > > dma@c184000: $nodename:0: 'dma@c184000' does not match '^dma-controller(@.*)?$' > arch/arm64/boot/dts/qcom/msm8998-asus-novago-tp370ql.dt.yaml > arch/arm64/boot/dts/qcom/msm8998-hp-envy-x2.dt.yaml > arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dt.yaml > arch/arm64/boot/dts/qcom/msm8998-mtp.dt.yaml > arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dt.yaml > arch/arm64/boot/dts/qcom/msm8998-oneplus-dumpling.dt.yaml All the above 6 issues are fixed by '[PATCH 01/20] arm64/dts: qcom: Fix 'dma' & 'qcom,controlled-remotely' nodes in dts' in this series. > dma-controller@17184000: 'iommus' does not match any of the regexes: 'pinctrl-[0-9]+' > arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml Fixed by ' [PATCH 06/20] dt-bindings: qcom-bam: Add 'iommus' to optional properties ' in this series. > dma-controller@704000: 'qcom,config-pipe-trust-reg' does not match any of the regexes: 'pinctrl-[0-9]+' > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml Fixed by '[PATCH 02/20] arm64/dts: qcom: ipq6018: Remove unused 'qcom,config-pipe-trust-reg' property' in this series. > dma-controller@704000: qcom,controlled-remotely: 'oneOf' conditional failed, one must be fixed: > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml Fixed by '[PATCH 01/20] arm64/dts: qcom: Fix 'dma' & ''qcom,controlled-remotely' nodes in dts' in this series. > dma-controller@7984000: clock-names:0: 'bam_clk' was expected > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml > > dma-controller@7984000: clock-names: Additional items are not allowed ('bam_clk' was unexpected) > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml > > dma-controller@7984000: clock-names: ['iface_clk', 'bam_clk'] is too long > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml > > dma-controller@7984000: clocks: [[9, 138], [9, 137]] is too long > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml Fixed by '[PATCH 03/20] arm64/dts: qcom: ipq6018: Remove unused 'iface_clk' property from dma-controller node' in this series. In summary, I ran 'make dtbs_check' after applying this series on linus's tip and linux-next's tip as well and saw no errors being reported for 'Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml'. Regards, Bhupesh
Hi Rob, On Thu, 14 Oct 2021 at 12:33, Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote: > > Hello Rob, > > Thanks for your review. > These issues are already fixed via patches within this series itself > (as some dts also need correction to pass the 'make dtbs_check' > check). I am not sure, but it seems the check was run without applying > other patches from this series. > > See details below: > > On Thu, 14 Oct 2021 at 00:09, Rob Herring <robh@kernel.org> wrote: > > > > On Wed, 13 Oct 2021 16:25:26 +0530, Bhupesh Sharma wrote: > > > Add new optional properties - 'interconnects' and > > > 'interconnect-names' to the device-tree binding documentation for > > > qcom-bam DMA IP. > > > > > > These properties describe the interconnect path between bam and main > > > memory and the interconnect type respectively. > > > > > > Cc: Thara Gopinath <thara.gopinath@linaro.org> > > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > > Cc: Rob Herring <robh+dt@kernel.org> > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > > --- > > > Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > following warnings. Consider if they are expected or the schema is > > incorrect. These may not be new warnings. > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > This will change in the future. > > > > Full log is available here: https://patchwork.ozlabs.org/patch/1540390 > > > > > > dma@12142000: $nodename:0: 'dma@12142000' does not match '^dma-controller(@.*)?$' > > arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml > > > > dma@12182000: $nodename:0: 'dma@12182000' does not match '^dma-controller(@.*)?$' > > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml > > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml > > arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml > > arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml > > arch/arm/boot/dts/qcom-ipq8064-ap148.dt.yaml > > arch/arm/boot/dts/qcom-ipq8064-rb3011.dt.yaml > > arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml > > > > dma@121c2000: $nodename:0: 'dma@121c2000' does not match '^dma-controller(@.*)?$' > > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml > > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml > > arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml > > arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml > > > > dma@12402000: $nodename:0: 'dma@12402000' does not match '^dma-controller(@.*)?$' > > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml > > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml > > arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml > > arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml > > arch/arm/boot/dts/qcom-ipq8064-ap148.dt.yaml > > arch/arm/boot/dts/qcom-ipq8064-rb3011.dt.yaml > > > > dma@1dc4000: $nodename:0: 'dma@1dc4000' does not match '^dma-controller(@.*)?$' > > arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml > > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml > > All the above will be fixed by '[PATCH 01/20] arm64/dts: qcom: Fix 'dma' & > 'qcom,controlled-remotely' nodes in dts' in this series. See the git > log of the this patch for details: > > 'A few qcom device-tree files define dma-controller nodes > with non-standard 'node names' and also set > the bool property 'qcom,controlled-remotely' incorrectly, which > leads to following errors with 'make dtbs_check': > > $ arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml: > dma@1dc4000: $nodename:0: 'dma@1dc4000' does not match > '^dma-controller(@.*)?$' > > $ arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml: > dma@1dc4000: qcom,controlled-remotely: 'oneOf' conditional > failed, one must be fixed: > [[1]] is not of type 'boolean' > True was expected > [[1]] is not of type 'null' > > Fix the same. > ' > > > dma@1dc4000: 'iommus' does not match any of the regexes: 'pinctrl-[0-9]+' > > arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml > > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml > > Fixed by ' [PATCH 06/20] dt-bindings: qcom-bam: Add 'iommus' to optional > properties ' in this series. > > > dma@1dc4000: qcom,controlled-remotely: 'oneOf' conditional failed, one must be fixed: > > arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml > > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml > > Again this would be fixed by '[PATCH 01/20] arm64/dts: qcom: Fix 'dma' & > 'qcom,controlled-remotely' nodes in dts' in this series. > > > dma@704000: $nodename:0: 'dma@704000' does not match '^dma-controller(@.*)?$' > > arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml > > arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml > > arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml > > Fixed by '[PATCH 01/20] arm64/dts: qcom: Fix 'dma' & > 'qcom,controlled-remotely' nodes in dts' in this series > > > dma@704000: qcom,controlled-remotely: 'oneOf' conditional failed, one must be fixed: > > arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml > > arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml > > arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml > > Fixed by '[PATCH 01/20] arm64/dts: qcom: Fix 'dma' & > 'qcom,controlled-remotely' nodes in dts' in this series > > > dma@7544000: $nodename:0: 'dma@7544000' does not match '^dma-controller(@.*)?$' > > arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml > > arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml > > arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml > > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml > > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml > > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml > > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml > > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml > > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml > > > > dma@7584000: $nodename:0: 'dma@7584000' does not match '^dma-controller(@.*)?$' > > arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml > > arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml > > arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml > > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml > > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml > > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml > > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml > > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml > > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml > > > > dma@7884000: $nodename:0: 'dma@7884000' does not match '^dma-controller(@.*)?$' > > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml > > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml > > arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml > > arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml > > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml > > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml > > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml > > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml > > > > dma@7984000: $nodename:0: 'dma@7984000' does not match '^dma-controller(@.*)?$' > > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml > > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml > > arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml > > arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml > > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml > > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml > > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml > > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml > > > > dma@8e04000: $nodename:0: 'dma@8e04000' does not match '^dma-controller(@.*)?$' > > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml > > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml > > arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml > > arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml > > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml > > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml > > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml > > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml > > > > dma@c184000: $nodename:0: 'dma@c184000' does not match '^dma-controller(@.*)?$' > > arch/arm64/boot/dts/qcom/msm8998-asus-novago-tp370ql.dt.yaml > > arch/arm64/boot/dts/qcom/msm8998-hp-envy-x2.dt.yaml > > arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dt.yaml > > arch/arm64/boot/dts/qcom/msm8998-mtp.dt.yaml > > arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dt.yaml > > arch/arm64/boot/dts/qcom/msm8998-oneplus-dumpling.dt.yaml > > All the above 6 issues are fixed by '[PATCH 01/20] arm64/dts: qcom: Fix 'dma' & > 'qcom,controlled-remotely' nodes in dts' in this series. > > > dma-controller@17184000: 'iommus' does not match any of the regexes: 'pinctrl-[0-9]+' > > arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml > > arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml > > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml > > Fixed by ' [PATCH 06/20] dt-bindings: qcom-bam: Add 'iommus' to optional > properties ' in this series. > > > dma-controller@704000: 'qcom,config-pipe-trust-reg' does not match any of the regexes: 'pinctrl-[0-9]+' > > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml > > Fixed by '[PATCH 02/20] arm64/dts: qcom: ipq6018: Remove unused > 'qcom,config-pipe-trust-reg' property' in this series. > > > dma-controller@704000: qcom,controlled-remotely: 'oneOf' conditional failed, one must be fixed: > > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml > > Fixed by '[PATCH 01/20] arm64/dts: qcom: Fix 'dma' & > ''qcom,controlled-remotely' nodes in dts' in this series. > > > dma-controller@7984000: clock-names:0: 'bam_clk' was expected > > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml > > > > dma-controller@7984000: clock-names: Additional items are not allowed ('bam_clk' was unexpected) > > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml > > > > dma-controller@7984000: clock-names: ['iface_clk', 'bam_clk'] is too long > > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml > > > > dma-controller@7984000: clocks: [[9, 138], [9, 137]] is too long > > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml > > Fixed by '[PATCH 03/20] arm64/dts: qcom: ipq6018: Remove unused 'iface_clk' > property from dma-controller node' in this series. > > In summary, I ran 'make dtbs_check' after applying this series on > linus's tip and linux-next's tip as well and saw no errors being > reported for 'Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml'. Ping. Do I need to fix anything in v5 or are the fixes regarding the YAML documentation fine? I am about to send the v5. Regards, Bhupesh
diff --git a/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml b/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml index 32b47e3b7769..602e68df971f 100644 --- a/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml +++ b/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml @@ -45,6 +45,14 @@ properties: const: 1 description: The single cell represents the channel index. + interconnects: + maxItems: 1 + description: | + Interconnect path between bam and main memory. + + interconnect-names: + const: memory + qcom,ee: $ref: /schemas/types.yaml#/definitions/uint32 description:
Add new optional properties - 'interconnects' and 'interconnect-names' to the device-tree binding documentation for qcom-bam DMA IP. These properties describe the interconnect path between bam and main memory and the interconnect type respectively. Cc: Thara Gopinath <thara.gopinath@linaro.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Rob Herring <robh+dt@kernel.org> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)