| Message ID | 20210930100501.15690-1-o.rempel@pengutronix.de |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v1,1/3] dt-bindings: display: simple: add Innolux G070Y2-T02 panel | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | fail | build log |
On Thu, 30 Sep 2021 12:04:59 +0200, Oleksij Rempel wrote: > Add binding for the Innolux G070Y2-T02 panel. It is 7" WVGA (800x480) > TFT LCD panel with TTL interface and a backlight unit. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
On Sat, Oct 09, 2021 at 05:12:44PM +0200, Sam Ravnborg wrote: > Hi Oleksij, Robin, > > On Thu, Sep 30, 2021 at 12:05:00PM +0200, Oleksij Rempel wrote: > > Add compatible and timings for the Innolux G070Y2-T02 panel. It is 7" > > WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit. > > > > Co-Developed-by: Robin van der Gracht <robin@protonic.nl> > > Signed-off-by: Robin van der Gracht <robin@protonic.nl> > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > --- > > drivers/gpu/drm/panel/panel-simple.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > index 9b6c4e6c38a1..a03b60f6fa99 100644 > > --- a/drivers/gpu/drm/panel/panel-simple.c > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > @@ -2524,6 +2524,19 @@ static const struct panel_desc innolux_g070y2_l01 = { > > .connector_type = DRM_MODE_CONNECTOR_LVDS, > > }; > > > > +static const struct panel_desc innolux_g070y2_t02 = { > > + .modes = &innolux_at070tn92_mode, > > It is suprising to see that the innolux_g070y2_t02 uses the mode > innolux_at070tn92_mode. > Is it on purpose? yes. > If yes then I would expect the changelog to say so. > > In most (all?) other cases the panel provide their own mode. It works with same timing values. What is the preferred way, add own mode or extend the changelog? Regards, Oleksij
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml index 335776c45474..2f1c0928d260 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml @@ -166,6 +166,8 @@ properties: - innolux,at070tn92 # Innolux G070Y2-L01 7" WVGA (800x480) TFT LCD panel - innolux,g070y2-l01 + # Innolux G070Y2-T02 7" WVGA (800x480) TFT LCD TTL panel + - innolux,g070y2-t02 # Innolux Corporation 10.1" G101ICE-L01 WXGA (1280x800) LVDS panel - innolux,g101ice-l01 # Innolux Corporation 12.1" WXGA (1280x800) TFT LCD panel
Add binding for the Innolux G070Y2-T02 panel. It is 7" WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+)