| Message ID | 20210913080024.6951-3-zajec5@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/4] dt-bindings: mfd: brcm,cru: add clkset syscon | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Mon, 13 Sep 2021 10:00:23 +0200, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > Northstar's USB 2.0 PHY is part of the CRU MFD. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > .../devicetree/bindings/mfd/brcm,cru.yaml | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Mon, 13 Sep 2021, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > Northstar's USB 2.0 PHY is part of the CRU MFD. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > .../devicetree/bindings/mfd/brcm,cru.yaml | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) Applied, thanks.
On Wed, Sep 22, 2021 at 2:58 AM Lee Jones <lee.jones@linaro.org> wrote: > > On Mon, 13 Sep 2021, Rafał Miłecki wrote: > > > From: Rafał Miłecki <rafal@milecki.pl> > > > > Northstar's USB 2.0 PHY is part of the CRU MFD. > > > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > > --- > > .../devicetree/bindings/mfd/brcm,cru.yaml | 15 ++++++++++++++- > > 1 file changed, 14 insertions(+), 1 deletion(-) > > Applied, thanks. Hopefully this works without patch 2??? Rob
On Thu, 23 Sep 2021, Rob Herring wrote: > On Wed, Sep 22, 2021 at 2:58 AM Lee Jones <lee.jones@linaro.org> wrote: > > > > On Mon, 13 Sep 2021, Rafał Miłecki wrote: > > > > > From: Rafał Miłecki <rafal@milecki.pl> > > > > > > Northstar's USB 2.0 PHY is part of the CRU MFD. > > > > > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > > > --- > > > .../devicetree/bindings/mfd/brcm,cru.yaml | 15 ++++++++++++++- > > > 1 file changed, 14 insertions(+), 1 deletion(-) > > > > Applied, thanks. > > Hopefully this works without patch 2??? What do you mean by 'works'? It's documentation.
diff --git a/Documentation/devicetree/bindings/mfd/brcm,cru.yaml b/Documentation/devicetree/bindings/mfd/brcm,cru.yaml index bf4e585d3c18..262284ae80f1 100644 --- a/Documentation/devicetree/bindings/mfd/brcm,cru.yaml +++ b/Documentation/devicetree/bindings/mfd/brcm,cru.yaml @@ -39,6 +39,9 @@ patternProperties: '^clock-controller@[a-f0-9]+$': $ref: ../clock/brcm,iproc-clocks.yaml + '^phy@[a-f0-9]+$': + $ref: ../phy/bcm-ns-usb2-phy.yaml + '^syscon@[a-f0-9]+$': $ref: syscon.yaml @@ -52,6 +55,7 @@ required: examples: - | + #include <dt-bindings/clock/bcm-nsp.h> cru-bus@1800c100 { compatible = "brcm,ns-cru", "simple-mfd"; reg = <0x1800c100 0x1d0>; @@ -76,7 +80,16 @@ examples: "iprocfast", "sata1", "sata2"; }; - syscon@180 { + phy@164 { + compatible = "brcm,ns-usb2-phy"; + reg = <0x164 0x4>; + brcm,syscon-clkset = <&clkset>; + clocks = <&genpll BCM_NSP_GENPLL_USB_PHY_REF_CLK>; + clock-names = "phy-ref-clk"; + #phy-cells = <0>; + }; + + clkset: syscon@180 { compatible = "brcm,cru-clkset", "syscon"; reg = <0x180 0x4>; };