| Message ID | 20210820150353.161161-1-krzysztof.kozlowski@canonical.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v2,1/4] dt-bindings: devfreq: event: convert Samsung Exynos NoCP to dtschema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 3 warnings, 48 lines checked |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | success |
On Fri, 20 Aug 2021 17:03:50 +0200, Krzysztof Kozlowski wrote: > Convert Samsung Exynos NoC Probe bindings to DT schema format using > json-schema. > > New bindings contain copied description from previous bindings document, > therefore the license is set as GPL-2.0-only. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > > --- > > Changes since v1: > 1. New patch > --- > .../bindings/devfreq/event/exynos-nocp.txt | 26 ---------- > .../devfreq/event/samsung,exynos-nocp.yaml | 48 +++++++++++++++++++ > 2 files changed, 48 insertions(+), 26 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/devfreq/event/exynos-nocp.txt > create mode 100644 Documentation/devicetree/bindings/devfreq/event/samsung,exynos-nocp.yaml > Applied, thanks!
On Fri, 20 Aug 2021 17:03:53 +0200, Krzysztof Kozlowski wrote: > Use hyphen instead of underscore and align the PPMU event node name with > dtschema. > > Applied, thanks! [4/4] ARM: dts: exynos: align PPMU event node names with dtschema commit: fb9b199e562d66af90f61d70eb737fa5e4deac2c Best regards,
Hi Krzysztof, On 15.09.2021 09:50, Krzysztof Kozlowski wrote: > On Fri, 20 Aug 2021 17:03:53 +0200, Krzysztof Kozlowski wrote: >> Use hyphen instead of underscore and align the PPMU event node name with >> dtschema. >> >> > Applied, thanks! > > [4/4] ARM: dts: exynos: align PPMU event node names with dtschema > commit: fb9b199e562d66af90f61d70eb737fa5e4deac2c > This breaks probing of Exynos event counters, which are needed by the Exynos DMC driver on Odroid XU3/XU4/HC1 boards. Just check the today's linux-next. I had no time to analyze which part of the code depends on the node names though... Best regards
On 16/09/2021 13:15, Marek Szyprowski wrote: > Hi Krzysztof, > > On 15.09.2021 09:50, Krzysztof Kozlowski wrote: >> On Fri, 20 Aug 2021 17:03:53 +0200, Krzysztof Kozlowski wrote: >>> Use hyphen instead of underscore and align the PPMU event node name with >>> dtschema. >>> >>> >> Applied, thanks! >> >> [4/4] ARM: dts: exynos: align PPMU event node names with dtschema >> commit: fb9b199e562d66af90f61d70eb737fa5e4deac2c >> > This breaks probing of Exynos event counters, which are needed by the > Exynos DMC driver on Odroid XU3/XU4/HC1 boards. Just check the today's > linux-next. I had no time to analyze which part of the code depends on > the node names though... Thanks for the report. I'll drop the patch from my queue and check later the driver. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/devfreq/event/exynos-nocp.txt b/Documentation/devicetree/bindings/devfreq/event/exynos-nocp.txt deleted file mode 100644 index aeaebd425d1f..000000000000 --- a/Documentation/devicetree/bindings/devfreq/event/exynos-nocp.txt +++ /dev/null @@ -1,26 +0,0 @@ - -* Samsung Exynos NoC (Network on Chip) Probe device - -The Samsung Exynos542x SoC has NoC (Network on Chip) Probe for NoC bus. -NoC provides the primitive values to get the performance data. The packets -that the Network on Chip (NoC) probes detects are transported over -the network infrastructure to observer units. You can configure probes to -capture packets with header or data on the data request response network, -or as traffic debug or statistic collectors. Exynos542x bus has multiple -NoC probes to provide bandwidth information about behavior of the SoC -that you can use while analyzing system performance. - -Required properties: -- compatible: Should be "samsung,exynos5420-nocp" -- reg: physical base address of each NoC Probe and length of memory mapped region. - -Optional properties: -- clock-names : the name of clock used by the NoC Probe, "nocp" -- clocks : phandles for clock specified in "clock-names" property - -Example : NoC Probe nodes in Device Tree are listed below. - - nocp_mem0_0: nocp@10ca1000 { - compatible = "samsung,exynos5420-nocp"; - reg = <0x10CA1000 0x200>; - }; diff --git a/Documentation/devicetree/bindings/devfreq/event/samsung,exynos-nocp.yaml b/Documentation/devicetree/bindings/devfreq/event/samsung,exynos-nocp.yaml new file mode 100644 index 000000000000..d318fccf78f1 --- /dev/null +++ b/Documentation/devicetree/bindings/devfreq/event/samsung,exynos-nocp.yaml @@ -0,0 +1,48 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/devfreq/event/samsung,exynos-nocp.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung Exynos NoC (Network on Chip) Probe + +maintainers: + - Chanwoo Choi <cw00.choi@samsung.com> + - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> + +description: | + The Samsung Exynos542x SoC has a NoC (Network on Chip) Probe for NoC bus. + NoC provides the primitive values to get the performance data. The packets + that the Network on Chip (NoC) probes detects are transported over the + network infrastructure to observer units. You can configure probes to capture + packets with header or data on the data request response network, or as + traffic debug or statistic collectors. Exynos542x bus has multiple NoC probes + to provide bandwidth information about behavior of the SoC that you can use + while analyzing system performance. + +properties: + compatible: + const: samsung,exynos5420-nocp + + clock-names: + items: + - const: nocp + + clocks: + maxItems: 1 + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + nocp_mem0_0: nocp@10ca1000 { + compatible = "samsung,exynos5420-nocp"; + reg = <0x10ca1000 0x200>; + };
Convert Samsung Exynos NoC Probe bindings to DT schema format using json-schema. New bindings contain copied description from previous bindings document, therefore the license is set as GPL-2.0-only. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- Changes since v1: 1. New patch --- .../bindings/devfreq/event/exynos-nocp.txt | 26 ---------- .../devfreq/event/samsung,exynos-nocp.yaml | 48 +++++++++++++++++++ 2 files changed, 48 insertions(+), 26 deletions(-) delete mode 100644 Documentation/devicetree/bindings/devfreq/event/exynos-nocp.txt create mode 100644 Documentation/devicetree/bindings/devfreq/event/samsung,exynos-nocp.yaml