| Message ID | 20210817174743.541353-1-robh@kernel.org |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | dt-bindings: PCI: faraday,ftpci100: Fix 'contains' schema usage | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 10 lines checked |
On Tue, Aug 17, 2021 at 7:47 PM Rob Herring <robh@kernel.org> wrote: > The 'contains' keyword applies to elements within an array, so > using 'items' only makes sense if the elements of the array are another > array which is not the case for 'compatible' properties. > > Looking at the driver, it seems the intent was the condition should be > true when 'faraday,ftpci100' is present, so we can drop > 'cortina,gemini-pci'. > > Fixes: 2720b991337d ("dt-bindings: PCI: ftpci100: convert faraday,ftpci100 to YAML") > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: linux-pci@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml b/Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml index fb32f7b55035..92efbf0f1297 100644 --- a/Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml +++ b/Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml @@ -113,9 +113,7 @@ if: properties: compatible: contains: - items: - - const: cortina,gemini-pci - - const: faraday,ftpci100 + const: faraday,ftpci100 then: required: - interrupt-controller
The 'contains' keyword applies to elements within an array, so using 'items' only makes sense if the elements of the array are another array which is not the case for 'compatible' properties. Looking at the driver, it seems the intent was the condition should be true when 'faraday,ftpci100' is present, so we can drop 'cortina,gemini-pci'. Fixes: 2720b991337d ("dt-bindings: PCI: ftpci100: convert faraday,ftpci100 to YAML") Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: linux-pci@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)