diff mbox series

[v2,1/4] dt-bindings: iio: accel: bma255: Add interrupt-names

Message ID 20210802155657.102766-2-stephan@gerhold.net
State Not Applicable, archived
Headers show
Series [v2,1/4] dt-bindings: iio: accel: bma255: Add interrupt-names | expand

Checks

Context Check Description
robh/checkpatch success

Commit Message

Stephan Gerhold Aug. 2, 2021, 3:56 p.m. UTC 
The binding already allows specifying both interrupt pins, but there
is currently no way to describe a board where (for whatever reason)
only INT2 is connected. Make it possible to use "interrupt-names"
to make it explicit which interrupt pin is meant in the interrupts.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
---
Changes in v2:
  - Add "Without interrupt-names, ..." to "interrupts" description
    to clarify that ordering of interrupts can be relaxed if
    interrupt-names is used.
---
 .../bindings/iio/accel/bosch,bma255.yaml         | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

Comments

Rob Herring Aug. 6, 2021, 9:49 p.m. UTC | #1 
On Mon, 02 Aug 2021 17:56:54 +0200, Stephan Gerhold wrote:
> The binding already allows specifying both interrupt pins, but there
> is currently no way to describe a board where (for whatever reason)
> only INT2 is connected. Make it possible to use "interrupt-names"
> to make it explicit which interrupt pin is meant in the interrupts.
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> Changes in v2:
>   - Add "Without interrupt-names, ..." to "interrupts" description
>     to clarify that ordering of interrupts can be relaxed if
>     interrupt-names is used.
> ---
>  .../bindings/iio/accel/bosch,bma255.yaml         | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
index 5b35856b1942..253b2051d0b1 100644
--- a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
+++ b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
@@ -45,9 +45,18 @@  properties:
     minItems: 1
     maxItems: 2
     description: |
-      The first interrupt listed must be the one connected to the INT1 pin,
-      the second (optional) interrupt listed must be the one connected to the
-      INT2 pin (if available). The type should be IRQ_TYPE_EDGE_RISING.
+      Without interrupt-names, the first interrupt listed must be the one
+      connected to the INT1 pin, the second (optional) interrupt listed must be
+      the one connected to the INT2 pin (if available). The type should be
+      IRQ_TYPE_EDGE_RISING.
+
+  interrupt-names:
+    minItems: 1
+    maxItems: 2
+    items:
+      enum:
+        - INT1
+        - INT2
 
   mount-matrix:
     description: an optional 3x3 mounting rotation matrix.
@@ -73,6 +82,7 @@  examples:
             vddio-supply = <&vddio>;
             vdd-supply = <&vdd>;
             interrupts = <57 IRQ_TYPE_EDGE_RISING>;
+            interrupt-names = "INT1";
         };
     };
   - |