diff mbox series

dt-bindings: net: can: Document power-domains property

Message ID 20210731045138.29912-1-a-govindraju@ti.com
State Superseded, archived
Headers show
Series dt-bindings: net: can: Document power-domains property | expand

Checks

Context Check Description
robh/dtbs-check success
robh/checkpatch success
robh/dt-meta-schema success

Commit Message

Aswath Govindraju July 31, 2021, 4:51 a.m. UTC
Document power-domains property for adding the Power domain provider.

Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---
 Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Marc Kleine-Budde Aug. 2, 2021, 7:10 a.m. UTC | #1
On 31.07.2021 10:21:38, Aswath Govindraju wrote:
> Document power-domains property for adding the Power domain provider.
> 
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
>  Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> index a7b5807c5543..d633fe1da870 100644
> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> @@ -104,6 +104,13 @@ properties:
>            maximum: 32
>      maxItems: 1
>  
> +  power-domains:
> +    description:
> +      Power domain provider node and an args specifier containing
> +      the can device id value. Please see,
> +      Documentation/devicetree/bindings/soc/ti/sci-pm-domain.yaml

Why are you referring to a TI specific file in a generic binding?

Marc
Aswath Govindraju Aug. 2, 2021, 8:31 a.m. UTC | #2
Hi Marc,

On 02/08/21 12:40 pm, Marc Kleine-Budde wrote:
> On 31.07.2021 10:21:38, Aswath Govindraju wrote:
>> Document power-domains property for adding the Power domain provider.
>>
>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
>> ---
>>  Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
>> index a7b5807c5543..d633fe1da870 100644
>> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
>> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
>> @@ -104,6 +104,13 @@ properties:
>>            maximum: 32
>>      maxItems: 1
>>  
>> +  power-domains:
>> +    description:
>> +      Power domain provider node and an args specifier containing
>> +      the can device id value. Please see,
>> +      Documentation/devicetree/bindings/soc/ti/sci-pm-domain.yaml
> 
> Why are you referring to a TI specific file in a generic binding?
> 

I was trying to refer to an example. If it shouldn't be referred then I
will remove it an post a post a respin.

Thanks,
Aswath

> Marc
>
Aswath Govindraju Aug. 2, 2021, 9:21 a.m. UTC | #3
Hi all,

On 31/07/21 10:21 am, Aswath Govindraju wrote:
> Document power-domains property for adding the Power domain provider.
> 
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---

Posted respin v2[1] for this patch, after removing the reference in
description.

[1] - https://lore.kernel.org/patchwork/patch/1470806/

Thanks,
Aswath

>  Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> index a7b5807c5543..d633fe1da870 100644
> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> @@ -104,6 +104,13 @@ properties:
>            maximum: 32
>      maxItems: 1
>  
> +  power-domains:
> +    description:
> +      Power domain provider node and an args specifier containing
> +      the can device id value. Please see,
> +      Documentation/devicetree/bindings/soc/ti/sci-pm-domain.yaml
> +    maxItems: 1
> +
>    can-transceiver:
>      $ref: can-transceiver.yaml#
>  
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
index a7b5807c5543..d633fe1da870 100644
--- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
+++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
@@ -104,6 +104,13 @@  properties:
           maximum: 32
     maxItems: 1
 
+  power-domains:
+    description:
+      Power domain provider node and an args specifier containing
+      the can device id value. Please see,
+      Documentation/devicetree/bindings/soc/ti/sci-pm-domain.yaml
+    maxItems: 1
+
   can-transceiver:
     $ref: can-transceiver.yaml#