| Message ID | 20210716232916.3572966-11-l.stach@pengutronix.de |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | i.MX8MM GPC improvements and BLK_CTRL driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Sat, 17 Jul 2021 01:29:09 +0200, Lucas Stach wrote: > This adds the DT binding for the i.MX8MM VPU blk-ctrl. > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > --- > .../soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml | 97 +++++++++++++++++++ > 1 file changed, 97 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml: properties:compatible: [{'const': 'fsl,imx8mm-disp-blk-ctrl'}, {'const': 'syscon'}] is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml: properties:clock-names:items: 'anyOf' conditional failed, one must be fixed: ['csi-bridge-axi', 'csi-bridge-apb', 'csi-bridge-core', 'lcdif-axi', 'lcdif-apb', 'lcdif-pix', 'dsi-pclk', 'dsi-ref', 'csi-aclk', 'csi-pclk'] is not of type 'object', 'boolean' 'csi-bridge-axi' is not of type 'object', 'boolean' 'csi-bridge-apb' is not of type 'object', 'boolean' 'csi-bridge-core' is not of type 'object', 'boolean' 'lcdif-axi' is not of type 'object', 'boolean' 'lcdif-apb' is not of type 'object', 'boolean' 'lcdif-pix' is not of type 'object', 'boolean' 'dsi-pclk' is not of type 'object', 'boolean' 'dsi-ref' is not of type 'object', 'boolean' 'csi-aclk' is not of type 'object', 'boolean' 'csi-pclk' is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml: properties:power-domain-names:items: 'anyOf' conditional failed, one must be fixed: ['bus', 'csi-bridge', 'lcdif', 'mipi-dsi', 'mipi-csi'] is not of type 'object', 'boolean' 'bus' is not of type 'object', 'boolean' 'csi-bridge' is not of type 'object', 'boolean' 'lcdif' is not of type 'object', 'boolean' 'mipi-dsi' is not of type 'object', 'boolean' 'mipi-csi' is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml: $id: 'http://devicetree.org/schemas/soc/imx/fsl,imx8mm-disp-blk-ctrl#' does not match 'http://devicetree.org/schemas/.*\\.yaml#' from schema $id: http://devicetree.org/meta-schemas/base.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml: properties:power-domain-names:minItems: False schema does not allow 5 hint: "minItems/maxItems" equal to the "items" list length are not necessary from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml: properties:power-domain-names:maxItems: False schema does not allow 5 hint: "minItems/maxItems" equal to the "items" list length are not necessary from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml: properties:clock-names:minItems: False schema does not allow 10 hint: "minItems/maxItems" equal to the "items" list length are not necessary from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml: properties:clock-names:maxItems: False schema does not allow 10 hint: "minItems/maxItems" equal to the "items" list length are not necessary from schema $id: http://devicetree.org/meta-schemas/items.yaml# ./Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml: $id: relative path/filename doesn't match actual path or filename expected: http://devicetree.org/schemas/soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml: ignoring, error in schema: properties: clock-names: items warning: no schema found in file: ./Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-disp-blk-ctrl.example.dts:20:51: error: missing terminating > character 20 | #include <dt-bindings/power/imx8mm-power.h | ^ make[1]: *** [scripts/Makefile.lib:380: Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-disp-blk-ctrl.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1418: dt_binding_check] Error 2 \ndoc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1506316 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml new file mode 100644 index 000000000000..a2c947b8dd52 --- /dev/null +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml @@ -0,0 +1,97 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/imx/fsl,imx8mm-disp-blk-ctrl# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP i.MX8MM DISP blk-ctrl + +maintainers: + - Lucas Stach <l.stach@pengutronix.de> + +description: + The i.MX8MM DISP blk-ctrl is a top-level peripheral providing access to + the NoC and ensuring proper power sequencing of the display and MIPI CSI + peripherals located in the DISP domain of the SoC. + +properties: + compatible: + - const: fsl,imx8mm-disp-blk-ctrl + - const: syscon + + reg: + maxItems: 1 + + "#power-domains-cells": + const: 1 + + power-domains: + minItems: 5 + maxItems: 5 + + power-domain-names: + minItems: 5 + maxItems: 5 + items: + - bus + - csi-bridge + - lcdif + - mipi-dsi + - mipi-csi + + clocks: + minItems: 10 + maxItems: 10 + + clock-names: + minItems: 10 + maxItems: 10 + items: + - csi-bridge-axi + - csi-bridge-apb + - csi-bridge-core + - lcdif-axi + - lcdif-apb + - lcdif-pix + - dsi-pclk + - dsi-ref + - csi-aclk + - csi-pclk + +required: + - compatible + - reg + - power-domains + - power-domain-names + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/imx8mm-clock.h> + #include <dt-bindings/power/imx8mm-power.h + + disp_blk_ctl: blk_ctrl@32e28000 { + compatible = "fsl,imx8mm-disp-blk-ctrl", "syscon"; + reg = <0x32e28000 0x100>; + power-domains = <&pgc_dispmix>, <&pgc_dispmix>, <&pgc_dispmix>, + <&pgc_mipi>, <&pgc_mipi>; + power-domain-names = "bus", "csi-bridge", "lcdif", + "mipi-dsi", "mipi-csi"; + clocks = <&clk IMX8MM_CLK_DISP_AXI_ROOT>, + <&clk IMX8MM_CLK_DISP_APB_ROOT>, + <&clk IMX8MM_CLK_CSI1_ROOT>, + <&clk IMX8MM_CLK_DISP_AXI_ROOT>, + <&clk IMX8MM_CLK_DISP_APB_ROOT>, + <&clk IMX8MM_CLK_DISP_ROOT>, + <&clk IMX8MM_CLK_DSI_CORE>, + <&clk IMX8MM_CLK_DSI_PHY_REF>, + <&clk IMX8MM_CLK_CSI1_CORE>, + <&clk IMX8MM_CLK_CSI1_PHY_REF>; + clock-names = "csi-bridge-axi","csi-bridge-apb", "csi-bridge-core", + "lcdif-axi", "lcdif-apb", "lcdif-pix", "dsi-pclk", + "dsi-ref","csi-aclk", "csi-pclk"; + #power-domain-cells = <1>; + };
This adds the DT binding for the i.MX8MM VPU blk-ctrl. Signed-off-by: Lucas Stach <l.stach@pengutronix.de> --- .../soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml | 97 +++++++++++++++++++ 1 file changed, 97 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-disp-blk-ctrl.yaml