| Message ID | 20210604190338.2248295-2-martin.blumenstingl@googlemail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | phy: Add support for the HDMI TX PHY on Meson8/8b/8m2 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | success |
On Fri, Jun 04, 2021 at 09:03:37PM +0200, Martin Blumenstingl wrote: > Amlogic Meson8, Meson8b and Meson8m2 all include an identical (or at > least very similar) HDMI TX PHY. The PHY registers are part of the HHI > register area. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > .../phy/amlogic,meson8-hdmi-tx-phy.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml > new file mode 100644 > index 000000000000..18a123b9bb0a > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/amlogic,meson8-hdmi-tx-phy.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Amlogic Meson8, Meson8b and Meson8m2 HDMI TX PHY > + > +maintainers: > + - Martin Blumenstingl <martin.blumenstingl@googlemail.com> > + > +description: |+ > + The HDMI TX PHY node should be the child of a syscon node with the > + required property: > + > + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon" Is there a sub range of registers for this functionality in "amlogic,meson-hhi-sysctrl"? If so, please add a 'reg' property. > + > + Refer to the bindings described in > + Documentation/devicetree/bindings/mfd/syscon.yaml > + > +properties: > + $nodename: > + pattern: "^hdmi-phy$" > + > + compatible: > + enum: > + - amlogic,meson8-hdmi-tx-phy > + - amlogic,meson8b-hdmi-tx-phy > + - amlogic,meson8m2-hdmi-tx-phy > + > + clocks: > + minItems: 1 > + description: > + HDMI TMDS clock > + > + "#phy-cells": > + const: 0 > + > +required: > + - compatible > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + hdmi_tx_phy: hdmi-phy { > + compatible = "amlogic,meson8-hdmi-tx-phy"; > + clocks = <&tmds_clock>; > + #phy-cells = <0>; > + }; > -- > 2.31.1
Hi Rob, On Thu, Jun 17, 2021 at 1:31 AM Rob Herring <robh@kernel.org> wrote: [...] > > +description: |+ > > + The HDMI TX PHY node should be the child of a syscon node with the > > + required property: > > + > > + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon" > > Is there a sub range of registers for this functionality in > "amlogic,meson-hhi-sysctrl"? If so, please add a 'reg' property. yes, for this part of the HHI registers there's a dedicated sub range. I'll add a reg property with register offset and size one question about .dts validation: at least the clock controller (which is also a sub-node of this) does not have a dedicated sub range. Is it still OK in this case to set #size-cells = <1> and #address-cells = <1> in the HHI node? Best regards, Martin
diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml new file mode 100644 index 000000000000..18a123b9bb0a --- /dev/null +++ b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/amlogic,meson8-hdmi-tx-phy.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Amlogic Meson8, Meson8b and Meson8m2 HDMI TX PHY + +maintainers: + - Martin Blumenstingl <martin.blumenstingl@googlemail.com> + +description: |+ + The HDMI TX PHY node should be the child of a syscon node with the + required property: + + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon" + + Refer to the bindings described in + Documentation/devicetree/bindings/mfd/syscon.yaml + +properties: + $nodename: + pattern: "^hdmi-phy$" + + compatible: + enum: + - amlogic,meson8-hdmi-tx-phy + - amlogic,meson8b-hdmi-tx-phy + - amlogic,meson8m2-hdmi-tx-phy + + clocks: + minItems: 1 + description: + HDMI TMDS clock + + "#phy-cells": + const: 0 + +required: + - compatible + - "#phy-cells" + +additionalProperties: false + +examples: + - | + hdmi_tx_phy: hdmi-phy { + compatible = "amlogic,meson8-hdmi-tx-phy"; + clocks = <&tmds_clock>; + #phy-cells = <0>; + };
Amlogic Meson8, Meson8b and Meson8m2 all include an identical (or at least very similar) HDMI TX PHY. The PHY registers are part of the HHI register area. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- .../phy/amlogic,meson8-hdmi-tx-phy.yaml | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml