diff mbox series

[1/2] dt-bindings: arm: ti: Add bindings for J721E EAIK

Message ID 20210602182237.12632-2-sinthu.raja@ti.com
State Changes Requested, archived
Headers show
Series arm64: Initial support for Texas Instruments J721E EAIK | expand

Checks

Context Check Description
robh/checkpatch success
robh/dt-meta-schema fail build log

Commit Message

Sinthu Raja June 2, 2021, 6:22 p.m. UTC
From: Sinthu Raja <sinthu.raja@ti.com>

J721E EdgeAI Kit (EAIK) is a low cost, small form factor board designed
for TI’s J721E SoC.
Add DT binding documentation for J721E EAIK

Signed-off-by: Amarnath MB <amarnath.mb@ti.com>
Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
---
 Documentation/devicetree/bindings/arm/ti/k3.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Rob Herring June 2, 2021, 8:19 p.m. UTC | #1
On Wed, 02 Jun 2021 23:52:36 +0530, Sinthu Raja wrote:
> From: Sinthu Raja <sinthu.raja@ti.com>
> 
> J721E EdgeAI Kit (EAIK) is a low cost, small form factor board designed
> for TI’s J721E SoC.
> Add DT binding documentation for J721E EAIK
> 
> Signed-off-by: Amarnath MB <amarnath.mb@ti.com>
> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> ---
>  Documentation/devicetree/bindings/arm/ti/k3.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dt.yaml: /: compatible: 'oneOf' conditional failed, one must be fixed:
	['ti,j721e'] is too short
	'ti,j721e' is not one of ['ti,am654-evm', 'siemens,iot2050-basic', 'siemens,iot2050-advanced']
	'ti,j721e' is not one of ['ti,j721e-eaik']
	'ti,j7200' was expected
	'ti,j721e' is not one of ['ti,am642-evm', 'ti,am642-sk']
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/ti/k3.yaml

See https://patchwork.ozlabs.org/patch/1486849

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.
Sinthu Raja June 3, 2021, 12:24 p.m. UTC | #2
On Thu, Jun 3, 2021 at 1:49 AM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, 02 Jun 2021 23:52:36 +0530, Sinthu Raja wrote:
> > From: Sinthu Raja <sinthu.raja@ti.com>
> >
> > J721E EdgeAI Kit (EAIK) is a low cost, small form factor board designed
> > for TI’s J721E SoC.
> > Add DT binding documentation for J721E EAIK
> >
> > Signed-off-by: Amarnath MB <amarnath.mb@ti.com>
> > Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> > ---
> >  Documentation/devicetree/bindings/arm/ti/k3.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dt.yaml: /: compatible: 'oneOf' conditional failed, one must be fixed:
>         ['ti,j721e'] is too short
>         'ti,j721e' is not one of ['ti,am654-evm', 'siemens,iot2050-basic', 'siemens,iot2050-advanced']
>         'ti,j721e' is not one of ['ti,j721e-eaik']
>         'ti,j7200' was expected
>         'ti,j721e' is not one of ['ti,am642-evm', 'ti,am642-sk']
>         From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/ti/k3.yaml
>
> See https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fpatchwork.ozlabs.org%2fpatch%2f1486849&c=E,1,iIjO1U6FeYcns7IR90F8V0U--545Y71F5JY6Imzb3PvTuPMht6sg0BpDbx7zvPe6hiInzXD-Jlt9L7harG-5n6pTJTnQ-haZhbukv25Bt-8NVFlY-Xcc9fR68g,,&typo=1
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
Hi Rob,
Thanks for your comment and valuable inputs. Earlier with the 'make
dt_binding_check', I didn't get the mentioned error. After installing
the yamllint and dt-schema update I am able to see the error(s).
Will fix and resubmit the patches.

Regards
Sinthu Raja
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
index c5aa362e4026..923dd7cf1dc6 100644
--- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
+++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
@@ -29,6 +29,8 @@  properties:
 
       - description: K3 J721E SoC
         items:
+          - enum:
+              - ti,j721e-eaik
           - const: ti,j721e
 
       - description: K3 J7200 SoC