| Message ID | 20210524165920.v8.4.I79c7ed8815a07d285dd3b38e680e980d1024dbf1@changeid |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | drm: Fix EDID reading on ti-sn65dsi86 by introducing the DP AUX bus | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | success |
On Tue, May 25, 2021 at 2:02 AM Douglas Anderson <dianders@chromium.org> wrote: > Now that we have an eDP controller that lists aux-bus, we can safely > add an example to the aux-bus bindings. > > NOTE: this example is just a copy of the one in the 'ti-sn65dsi86' > one. It feels useful to have the example in both places simply because > it's important to document the interaction between the two bindings in > both places. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> Looks good. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Mon, May 24, 2021 at 05:01:52PM -0700, Douglas Anderson wrote: > Now that we have an eDP controller that lists aux-bus, we can safely > add an example to the aux-bus bindings. > > NOTE: this example is just a copy of the one in the 'ti-sn65dsi86' > one. It feels useful to have the example in both places simply because > it's important to document the interaction between the two bindings in > both places. Don't forget the 3rd copy that exists in some .dts file most likely. That's 3 places to fix when we improve or add some schema. I've generally been trying to de-duplicate examples... Rob
Hi, On Wed, Jun 2, 2021 at 11:16 AM Rob Herring <robh@kernel.org> wrote: > > On Mon, May 24, 2021 at 05:01:52PM -0700, Douglas Anderson wrote: > > Now that we have an eDP controller that lists aux-bus, we can safely > > add an example to the aux-bus bindings. > > > > NOTE: this example is just a copy of the one in the 'ti-sn65dsi86' > > one. It feels useful to have the example in both places simply because > > it's important to document the interaction between the two bindings in > > both places. > > Don't forget the 3rd copy that exists in some .dts file most likely. > That's 3 places to fix when we improve or add some schema. > > I've generally been trying to de-duplicate examples... I'm interpreting your response as: please drop ${SUBJECT} patch from the series and leave the 'dp-aux-bus.yaml' without any example. The existing example in the bridge chip is sufficient. -Doug
diff --git a/Documentation/devicetree/bindings/display/dp-aux-bus.yaml b/Documentation/devicetree/bindings/display/dp-aux-bus.yaml index 5e4afe9f98fb..43494d2a32a1 100644 --- a/Documentation/devicetree/bindings/display/dp-aux-bus.yaml +++ b/Documentation/devicetree/bindings/display/dp-aux-bus.yaml @@ -35,3 +35,68 @@ additionalProperties: false required: - panel + +examples: + - | + #include <dt-bindings/clock/qcom,rpmh.h> + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/irq.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + bridge@2d { + compatible = "ti,sn65dsi86"; + reg = <0x2d>; + + interrupt-parent = <&tlmm>; + interrupts = <10 IRQ_TYPE_LEVEL_HIGH>; + + enable-gpios = <&tlmm 102 GPIO_ACTIVE_HIGH>; + + vpll-supply = <&src_pp1800_s4a>; + vccio-supply = <&src_pp1800_s4a>; + vcca-supply = <&src_pp1200_l2a>; + vcc-supply = <&src_pp1200_l2a>; + + clocks = <&rpmhcc RPMH_LN_BB_CLK2>; + clock-names = "refclk"; + + no-hpd; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + endpoint { + remote-endpoint = <&dsi0_out>; + }; + }; + + port@1 { + reg = <1>; + sn65dsi86_out: endpoint { + remote-endpoint = <&panel_in_edp>; + }; + }; + }; + + aux-bus { + panel { + compatible = "boe,nv133fhm-n62"; + power-supply = <&pp3300_dx_edp>; + backlight = <&backlight>; + hpd-gpios = <&sn65dsi86_bridge 2 GPIO_ACTIVE_HIGH>; + + port { + panel_in_edp: endpoint { + remote-endpoint = <&sn65dsi86_out>; + }; + }; + }; + }; + }; + };
Now that we have an eDP controller that lists aux-bus, we can safely add an example to the aux-bus bindings. NOTE: this example is just a copy of the one in the 'ti-sn65dsi86' one. It feels useful to have the example in both places simply because it's important to document the interaction between the two bindings in both places. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- Changes in v8: - Separate DP AUX bus binding is new for v8. .../bindings/display/dp-aux-bus.yaml | 65 +++++++++++++++++++ 1 file changed, 65 insertions(+)