| Message ID | 20210524165920.v8.3.I98bf729846c37c4c143f6ab88b1e299280e2fe26@changeid |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | drm: Fix EDID reading on ti-sn65dsi86 by introducing the DP AUX bus | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | fail | build log |
On Tue, May 25, 2021 at 2:02 AM Douglas Anderson <dianders@chromium.org> wrote: > The patch ("dt-bindings: drm: Introduce the DP AUX bus") talks about > how using the DP AUX bus is better than learning how to slice > bread. Let's add it to the ti-sn65dsi86 bindings. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> (...) > description: See ../../pwm/pwm.yaml for description of the cell formats.> Just use the full path: /schemas/pwm/pwm.yaml > + aux-bus: > + $ref: ../dp-aux-bus.yaml# Use the full path. (Same method as above) This removes the need for ../../... .... You do it here: > ports: > $ref: /schemas/graph.yaml#/properties/ports Other than that I think it looks all right! Yours, Linus Walleij
On Fri, May 28, 2021 at 02:29:53AM +0200, Linus Walleij wrote: > On Tue, May 25, 2021 at 2:02 AM Douglas Anderson <dianders@chromium.org> wrote: > > > The patch ("dt-bindings: drm: Introduce the DP AUX bus") talks about > > how using the DP AUX bus is better than learning how to slice > > bread. Let's add it to the ti-sn65dsi86 bindings. > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > (...) > > description: See ../../pwm/pwm.yaml for description of the cell formats.> > > Just use the full path: > /schemas/pwm/pwm.yaml Really, just drop it. If we want have generic references and/or descriptions for common properties, we should generate that in pretty documentation (there are json-schema to doc tools already). > > > + aux-bus: > > + $ref: ../dp-aux-bus.yaml# > > Use the full path. (Same method as above) +1 > This removes the need for ../../... .... > > You do it here: > > > ports: > > $ref: /schemas/graph.yaml#/properties/ports > > Other than that I think it looks all right! > > Yours, > Linus Walleij
On Wed, Jun 02, 2021 at 01:06:09PM -0500, Rob Herring wrote: > On Fri, May 28, 2021 at 02:29:53AM +0200, Linus Walleij wrote: > > On Tue, May 25, 2021 at 2:02 AM Douglas Anderson <dianders@chromium.org> wrote: > > > > > The patch ("dt-bindings: drm: Introduce the DP AUX bus") talks about > > > how using the DP AUX bus is better than learning how to slice > > > bread. Let's add it to the ti-sn65dsi86 bindings. > > > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > (...) > > > description: See ../../pwm/pwm.yaml for description of the cell formats.> > > > > Just use the full path: > > /schemas/pwm/pwm.yaml > > Really, just drop it. If we want have generic references and/or > descriptions for common properties, we should generate that in pretty > documentation (there are json-schema to doc tools already). Ah, now I see this was just context, so no need for you to fix/change this here. Rob
On Mon, 24 May 2021 17:01:51 -0700, Douglas Anderson wrote: > The patch ("dt-bindings: drm: Introduce the DP AUX bus") talks about > how using the DP AUX bus is better than learning how to slice > bread. Let's add it to the ti-sn65dsi86 bindings. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > Changes in v8: > - ti-sn65dsi86 references the new aux bus bindings. > > Changes in v7: > - ti-sn65dsi86: Add aux-bus child patch new for v7. > > .../bindings/display/bridge/ti,sn65dsi86.yaml | 20 ++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > With the path updated, Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml index 26932d2e86ab..4007f36d04ba 100644 --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml @@ -70,6 +70,9 @@ properties: const: 1 description: See ../../pwm/pwm.yaml for description of the cell formats. + aux-bus: + $ref: ../dp-aux-bus.yaml# + ports: $ref: /schemas/graph.yaml#/properties/ports @@ -201,11 +204,26 @@ examples: port@1 { reg = <1>; - endpoint { + sn65dsi86_out: endpoint { remote-endpoint = <&panel_in_edp>; }; }; }; + + aux-bus { + panel { + compatible = "boe,nv133fhm-n62"; + power-supply = <&pp3300_dx_edp>; + backlight = <&backlight>; + hpd-gpios = <&sn65dsi86_bridge 2 GPIO_ACTIVE_HIGH>; + + port { + panel_in_edp: endpoint { + remote-endpoint = <&sn65dsi86_out>; + }; + }; + }; + }; }; }; - |
The patch ("dt-bindings: drm: Introduce the DP AUX bus") talks about how using the DP AUX bus is better than learning how to slice bread. Let's add it to the ti-sn65dsi86 bindings. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- Changes in v8: - ti-sn65dsi86 references the new aux bus bindings. Changes in v7: - ti-sn65dsi86: Add aux-bus child patch new for v7. .../bindings/display/bridge/ti,sn65dsi86.yaml | 20 ++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-)