| Message ID | 20210518232858.1535403-7-robh@kernel.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | dt-bindings: Convert mux bindings to schema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
Hi Rob, Thank you for the patch. On Tue, May 18, 2021 at 06:28:58PM -0500, Rob Herring wrote: > Use the i2c-mux.yaml schema in the maxim,max9286 binding schema. With this, > several properties can be dropped as they are defined in i2c-mux.yaml > already. > > Cc: Jacopo Mondi <jacopo+renesas@jmondi.org> > Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > Cc: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > .../bindings/media/i2c/maxim,max9286.yaml | 23 +++---------------- > 1 file changed, 3 insertions(+), 20 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml > index ee16102fdfe7..02f656e78700 100644 > --- a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml > @@ -111,17 +111,10 @@ properties: > > i2c-mux: > type: object > + $ref: /schemas/i2c/i2c-mux.yaml# > + unevaluatedProperties: false > description: | > - Each GMSL link is modelled as a child bus of an i2c bus > - multiplexer/switch, in accordance with bindings described in > - Documentation/devicetree/bindings/i2c/i2c-mux.txt. > - > - properties: > - '#address-cells': > - const: 1 > - > - '#size-cells': > - const: 0 > + Each GMSL link is modelled as a child bus of an i2c bus multiplexer/switch. > > patternProperties: > "^i2c@[0-3]$": > @@ -133,12 +126,6 @@ properties: > channels. > > properties: > - '#address-cells': > - const: 1 > - > - '#size-cells': > - const: 0 > - > reg: > description: The index of the GMSL channel. > maxItems: 1 > @@ -173,10 +160,6 @@ properties: > > additionalProperties: false > > - additionalProperties: false > - > - additionalProperties: false > - > required: > - compatible > - reg
diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml index ee16102fdfe7..02f656e78700 100644 --- a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml @@ -111,17 +111,10 @@ properties: i2c-mux: type: object + $ref: /schemas/i2c/i2c-mux.yaml# + unevaluatedProperties: false description: | - Each GMSL link is modelled as a child bus of an i2c bus - multiplexer/switch, in accordance with bindings described in - Documentation/devicetree/bindings/i2c/i2c-mux.txt. - - properties: - '#address-cells': - const: 1 - - '#size-cells': - const: 0 + Each GMSL link is modelled as a child bus of an i2c bus multiplexer/switch. patternProperties: "^i2c@[0-3]$": @@ -133,12 +126,6 @@ properties: channels. properties: - '#address-cells': - const: 1 - - '#size-cells': - const: 0 - reg: description: The index of the GMSL channel. maxItems: 1 @@ -173,10 +160,6 @@ properties: additionalProperties: false - additionalProperties: false - - additionalProperties: false - required: - compatible - reg
Use the i2c-mux.yaml schema in the maxim,max9286 binding schema. With this, several properties can be dropped as they are defined in i2c-mux.yaml already. Cc: Jacopo Mondi <jacopo+renesas@jmondi.org> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Cc: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Signed-off-by: Rob Herring <robh@kernel.org> --- .../bindings/media/i2c/maxim,max9286.yaml | 23 +++---------------- 1 file changed, 3 insertions(+), 20 deletions(-)