| Message ID | 20210508193654.2596119-1-clabbe@baylibre.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | dt-bindings: leds: common: add disk write/read and usb-host | expand |
| Context | Check | Description |
|---|---|---|
| robh/dt-meta-schema | success | |
| robh/dtbs-check | success | |
| robh/checkpatch | warning | total: 0 errors, 3 warnings, 16 lines checked |
On Sat, May 8, 2021 at 9:37 PM Corentin Labbe <clabbe@baylibre.com> wrote: > The triggers enum misses 3 cases used by gemini DT. > usb-host was added via commit 0cfbd328d60f ("usb: Add LED triggers for USB activity") > so we add also as valid trigger usb-gadget which was added along in this > commit. > > disk-read/disk-write were added by commit d1ed7c558612 ("leds: Extends disk trigger for reads and writes") > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> Good catch! Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Sat, 08 May 2021 19:36:54 +0000, Corentin Labbe wrote: > The triggers enum misses 3 cases used by gemini DT. > usb-host was added via commit 0cfbd328d60f ("usb: Add LED triggers for USB activity") > so we add also as valid trigger usb-gadget which was added along in this > commit. > > disk-read/disk-write were added by commit d1ed7c558612 ("leds: Extends disk trigger for reads and writes") > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > --- > Documentation/devicetree/bindings/leds/common.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml index b1f363747a62..a9b8c21779e3 100644 --- a/Documentation/devicetree/bindings/leds/common.yaml +++ b/Documentation/devicetree/bindings/leds/common.yaml @@ -89,6 +89,8 @@ properties: - heartbeat # LED indicates disk activity - disk-activity + - disk-read + - disk-write # LED indicates IDE disk activity (deprecated), in new implementations # use "disk-activity" - ide-disk @@ -97,6 +99,8 @@ properties: # LED alters the brightness for the specified duration with one software # timer (requires "led-pattern" property) - pattern + - usb-gadget + - usb-host led-pattern: description: |
The triggers enum misses 3 cases used by gemini DT. usb-host was added via commit 0cfbd328d60f ("usb: Add LED triggers for USB activity") so we add also as valid trigger usb-gadget which was added along in this commit. disk-read/disk-write were added by commit d1ed7c558612 ("leds: Extends disk trigger for reads and writes") Signed-off-by: Corentin Labbe <clabbe@baylibre.com> --- Documentation/devicetree/bindings/leds/common.yaml | 4 ++++ 1 file changed, 4 insertions(+)